From: "Mark A. Greer" <mgreer@animalcreek.com>
To: Juha Kuikka <juha.kuikka@gmail.com>
Cc: Joe Woodward <jw@terrafix.co.uk>, Paul Walmsley <paul@pwsan.com>,
Kevin Hilman <khilman@ti.com>,
linux-omap@vger.kernel.org
Subject: Re: PM/RTC 3.5-rc5: System suspends fails when not built with RTC?
Date: Thu, 26 Jul 2012 16:08:24 -0700 [thread overview]
Message-ID: <20120726230824.GB20413@animalcreek.com> (raw)
In-Reply-To: <20120726230630.GA21004@animalcreek.com>
On Thu, Jul 26, 2012 at 04:06:30PM -0700, Mark A. Greer wrote:
> On Thu, Jul 26, 2012 at 02:09:33PM -0700, Juha Kuikka wrote:
> > Just applying Mark's patch on top of
> > 55936cdfaaf11ac352b56bc58e42d6661e65ee13 (linux-omap) is not enough, I
> > also need to set the OMAP3_HAS_IVA_REGS for the 3430 as well.
> >
> > Inlined patch:
> >
> > diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> > index 4072fbd..45d3eb4 100644
> > --- a/arch/arm/mach-omap2/id.c
> > +++ b/arch/arm/mach-omap2/id.c
> > @@ -244,7 +244,7 @@ void __init omap3xxx_check_features(void)
> > if (cpu_is_omap3630())
> > omap_features |= OMAP3_HAS_192MHZ_CLK | OMAP3_HAS_IVA_REGS;
> > if (cpu_is_omap3430() || cpu_is_omap3630())
> > - omap_features |= OMAP3_HAS_IO_WAKEUP;
> > + omap_features |= OMAP3_HAS_IO_WAKEUP | OMAP3_HAS_IVA_REGS;
> > if (cpu_is_omap3630() || omap_rev() == OMAP3430_REV_ES3_1 ||
> > omap_rev() == OMAP3430_REV_ES3_1_2)
> > omap_features |= OMAP3_HAS_IO_CHAIN_CTRL;
>
> Thank you.
I meant to add, "Please make a formal patch for review so you can
get credit for your work."
Mark
next prev parent reply other threads:[~2012-07-26 23:08 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-12 8:15 PM/RTC 3.5-rc5: System suspends fails when not built with RTC? Joe Woodward
2012-07-12 10:59 ` Paul Walmsley
2012-07-12 14:43 ` Joe Woodward
2012-07-12 19:35 ` Paul Walmsley
2012-07-13 10:57 ` Joe Woodward
2012-07-13 18:26 ` Paul Walmsley
2012-07-13 21:28 ` Mark A. Greer
2012-07-17 0:40 ` Mark A. Greer
2012-07-17 0:43 ` Paul Walmsley
2012-07-17 10:08 ` Joe Woodward
2012-07-17 19:28 ` Paul Walmsley
2012-07-18 2:20 ` Mark A. Greer
2012-07-18 10:06 ` Joe Woodward
2012-07-18 17:26 ` Mark A. Greer
2012-07-26 21:09 ` Juha Kuikka
2012-07-26 23:06 ` Mark A. Greer
2012-07-26 23:08 ` Mark A. Greer [this message]
2012-07-12 18:25 ` Kevin Hilman
-- strict thread matches above, loose matches on Subject: below --
2012-07-05 15:03 Joe Woodward
2012-07-10 23:58 ` Kevin Hilman
2012-07-11 10:50 ` Joe Woodward
2012-07-11 15:31 ` T Krishnamoorthy, Balaji
2012-07-11 17:07 ` Kevin Hilman
2012-07-11 17:51 ` Mark A. Greer
2012-07-11 18:38 ` Kevin Hilman
2012-07-11 18:48 ` Kevin Hilman
2012-07-11 20:52 ` Omar Ramirez Luna
2012-07-11 21:29 ` Kevin Hilman
2012-07-12 5:56 ` Shubhrajyoti
2012-07-13 6:34 ` Tony Lindgren
2012-07-16 17:18 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120726230824.GB20413@animalcreek.com \
--to=mgreer@animalcreek.com \
--cc=juha.kuikka@gmail.com \
--cc=jw@terrafix.co.uk \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.