From: Paul Cercueil <paul@crapouillou.net> To: Christophe Branchereau <cbranchereau@gmail.com> Cc: devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mips@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org> Subject: Re: [PATCH v4 1/4] drm/ingenic : add ingenic_drm_bridge_atomic_enable Date: Mon, 14 Mar 2022 19:57:32 +0000 [thread overview] Message-ID: <WF3R8R.TU622OO0WUTK3@crapouillou.net> (raw) In-Reply-To: <20220311170240.173846-2-cbranchereau@gmail.com> Hi Christophe, Le ven., mars 11 2022 at 18:02:37 +0100, Christophe Branchereau <cbranchereau@gmail.com> a écrit : > This allows the CRTC to be enabled after panels have slept out, > and before their display is turned on, solving a graphical bug > on the newvision nv3502c > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > --- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index dcf44cb00821..51512f41263e 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct > notifier_block *nb, > } > } > > +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge > *bridge, > + struct drm_bridge_state *old_bridge_state) > +{ > + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); > + > + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > + > + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > + JZ_LCD_CTRL_ENABLE); > +} > + > static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > struct drm_atomic_state *state) > { > @@ -237,17 +249,11 @@ static void > ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > if (WARN_ON(IS_ERR(priv_state))) > return; > > - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > - > /* Set addresses of our DMA descriptor chains */ > next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; > regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, > next_id)); > regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); > > - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > - JZ_LCD_CTRL_ENABLE); > - > drm_crtc_vblank_on(crtc); > } > > @@ -968,6 +974,7 @@ static const struct drm_encoder_helper_funcs > ingenic_drm_encoder_helper_funcs = > > static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { > .attach = ingenic_drm_bridge_attach, > + .atomic_enable = ingenic_drm_bridge_atomic_enable, Shouldn't we have a .atomic_disable() as well? If the CRTC is now enabled in the bridge's .atomic_enable, it would make sense to have it disabled in the .atomic_disable(). Cheers, -Paul > .atomic_check = ingenic_drm_bridge_atomic_check, > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > -- > 2.35.1 >
WARNING: multiple messages have this Message-ID (diff)
From: Paul Cercueil <paul@crapouillou.net> To: Christophe Branchereau <cbranchereau@gmail.com> Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Thierry Reding <thierry.reding@gmail.com>, Sam Ravnborg <sam@ravnborg.org>, Rob Herring <robh+dt@kernel.org>, linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v4 1/4] drm/ingenic : add ingenic_drm_bridge_atomic_enable Date: Mon, 14 Mar 2022 19:57:32 +0000 [thread overview] Message-ID: <WF3R8R.TU622OO0WUTK3@crapouillou.net> (raw) In-Reply-To: <20220311170240.173846-2-cbranchereau@gmail.com> Hi Christophe, Le ven., mars 11 2022 at 18:02:37 +0100, Christophe Branchereau <cbranchereau@gmail.com> a écrit : > This allows the CRTC to be enabled after panels have slept out, > and before their display is turned on, solving a graphical bug > on the newvision nv3502c > > Signed-off-by: Christophe Branchereau <cbranchereau@gmail.com> > --- > drivers/gpu/drm/ingenic/ingenic-drm-drv.c | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > index dcf44cb00821..51512f41263e 100644 > --- a/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > +++ b/drivers/gpu/drm/ingenic/ingenic-drm-drv.c > @@ -226,6 +226,18 @@ static int ingenic_drm_update_pixclk(struct > notifier_block *nb, > } > } > > +static void ingenic_drm_bridge_atomic_enable(struct drm_bridge > *bridge, > + struct drm_bridge_state *old_bridge_state) > +{ > + struct ingenic_drm *priv = drm_device_get_priv(bridge->dev); > + > + regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > + > + regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > + JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > + JZ_LCD_CTRL_ENABLE); > +} > + > static void ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > struct drm_atomic_state *state) > { > @@ -237,17 +249,11 @@ static void > ingenic_drm_crtc_atomic_enable(struct drm_crtc *crtc, > if (WARN_ON(IS_ERR(priv_state))) > return; > > - regmap_write(priv->map, JZ_REG_LCD_STATE, 0); > - > /* Set addresses of our DMA descriptor chains */ > next_id = priv_state->use_palette ? HWDESC_PALETTE : 0; > regmap_write(priv->map, JZ_REG_LCD_DA0, dma_hwdesc_addr(priv, > next_id)); > regmap_write(priv->map, JZ_REG_LCD_DA1, dma_hwdesc_addr(priv, 1)); > > - regmap_update_bits(priv->map, JZ_REG_LCD_CTRL, > - JZ_LCD_CTRL_ENABLE | JZ_LCD_CTRL_DISABLE, > - JZ_LCD_CTRL_ENABLE); > - > drm_crtc_vblank_on(crtc); > } > > @@ -968,6 +974,7 @@ static const struct drm_encoder_helper_funcs > ingenic_drm_encoder_helper_funcs = > > static const struct drm_bridge_funcs ingenic_drm_bridge_funcs = { > .attach = ingenic_drm_bridge_attach, > + .atomic_enable = ingenic_drm_bridge_atomic_enable, Shouldn't we have a .atomic_disable() as well? If the CRTC is now enabled in the bridge's .atomic_enable, it would make sense to have it disabled in the .atomic_disable(). Cheers, -Paul > .atomic_check = ingenic_drm_bridge_atomic_check, > .atomic_reset = drm_atomic_helper_bridge_reset, > .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, > -- > 2.35.1 >
next prev parent reply other threads:[~2022-03-14 19:57 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-03-11 17:02 [PATCH v4 0/4] Ingenic DRM bridge_atomic_enable proposal Christophe Branchereau 2022-03-11 17:02 ` Christophe Branchereau 2022-03-11 17:02 ` [PATCH v4 1/4] drm/ingenic : add ingenic_drm_bridge_atomic_enable Christophe Branchereau 2022-03-11 17:02 ` Christophe Branchereau 2022-03-14 19:57 ` Paul Cercueil [this message] 2022-03-14 19:57 ` Paul Cercueil 2022-03-11 17:02 ` [PATCH v4 2/4] drm/panel: Add panel driver for NewVision NV3052C based LCDs Christophe Branchereau 2022-03-11 17:02 ` Christophe Branchereau 2022-03-14 19:54 ` Paul Cercueil 2022-03-14 19:54 ` Paul Cercueil 2022-03-21 13:14 ` Christophe Branchereau 2022-03-21 13:14 ` Christophe Branchereau 2022-03-15 20:23 ` Sam Ravnborg 2022-03-15 20:23 ` Sam Ravnborg 2022-03-21 9:36 ` Christophe Branchereau 2022-03-21 9:36 ` Christophe Branchereau 2022-03-21 11:40 ` Sam Ravnborg 2022-03-21 11:40 ` Sam Ravnborg 2022-03-11 17:02 ` [PATCH v4 3/4] drm/panel : innolux-ej030na and abt-y030xx067a : add .enable and .disable Christophe Branchereau 2022-03-11 17:02 ` Christophe Branchereau 2022-03-11 17:02 ` [PATCH v4 4/4] dt-bindings: display/panel: Add Leadtek ltk035c5444t Christophe Branchereau 2022-03-11 17:02 ` Christophe Branchereau 2022-03-12 3:47 ` Rob Herring 2022-03-12 3:47 ` Rob Herring 2022-03-17 20:10 ` Paul Cercueil 2022-03-17 20:10 ` Paul Cercueil
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=WF3R8R.TU622OO0WUTK3@crapouillou.net \ --to=paul@crapouillou.net \ --cc=airlied@linux.ie \ --cc=cbranchereau@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=thierry.reding@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.