From: Greg KH <gregkh@linuxfoundation.org> To: Adrian Catangiu <acatan@amazon.com> Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, qemu-devel@nongnu.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, graf@amazon.com, arnd@arndb.de, ebiederm@xmission.com, rppt@kernel.org, 0x7f454c46@gmail.com, borntraeger@de.ibm.com, Jason@zx2c4.com, jannh@google.com, w@1wt.eu, colmmacc@amazon.com, luto@kernel.org, tytso@mit.edu, ebiggers@kernel.org, dwmw@amazon.co.uk, bonzini@gnu.org, sblbir@amazon.com, raduweis@amazon.com, corbet@lwn.net, mst@redhat.com, mhocko@kernel.org, rafael@kernel.org, pavel@ucw.cz, mpe@ellerman.id.au, areber@redhat.com, ovzxemul@gmail.com, avagin@gmail.com, ptikhomirov@virtuozzo.com, gil@azul.com, asmehra@redhat.com, dgunigun@redhat.com, vijaysun@ca.ibm.com, oridgar@gmail.com, ghammer@redhat.com Subject: Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver Date: Tue, 12 Jan 2021 14:08:15 +0100 [thread overview] Message-ID: <X/2fP9LNWXvp7up9@kroah.com> (raw) In-Reply-To: <1610453760-13812-2-git-send-email-acatan@amazon.com> On Tue, Jan 12, 2021 at 02:15:59PM +0200, Adrian Catangiu wrote: > +``read()``: > + Read is meant to provide the *new* system generation counter when a > + generation change takes place. The read operation blocks until the > + associated counter is no longer up to date, at which point the new > + counter is provided/returned. > + Nonblocking ``read()`` uses ``EAGAIN`` to signal that there is no > + *new* counter value available. The generation counter is considered > + *new* for each open file descriptor that hasn't confirmed the new > + value following a generation change. Therefore, once a generation > + change takes place, all ``read()`` calls will immediately return the > + new generation counter and will continue to do so until the > + new value is confirmed back to the driver through ``write()``. > + Partial reads are not allowed - read buffer needs to be at least > + ``sizeof(unsigned)`` in size. "sizeof(unsigned)"? How about being specific and making this a real "X bits big" value please. "unsigned" does not work well across user/kernel boundries. Ok, that's on understatement, the correct thing is "does not work at all". Please be specific in your apis. This is listed elsewhere also. > +``write()``: > + Write is used to confirm the up-to-date Sys Gen counter back to the > + driver. > + Following a VM generation change, all existing watchers are marked > + as *outdated*. Each file descriptor will maintain the *outdated* > + status until a ``write()`` confirms the up-to-date counter back to > + the driver. > + Partial writes are not allowed - write buffer should be exactly > + ``sizeof(unsigned)`` in size. > + > +``poll()``: > + Poll is implemented to allow polling for generation counter updates. > + Such updates result in ``EPOLLIN`` polling status until the new > + up-to-date counter is confirmed back to the driver through a > + ``write()``. > + > +``ioctl()``: > + The driver also adds support for tracking count of open file > + descriptors that haven't acknowledged a generation counter update, > + as well as a mechanism for userspace to *force* a generation update: > + > + - SYSGENID_GET_OUTDATED_WATCHERS: immediately returns the number of > + *outdated* watchers - number of file descriptors that were open > + during a system generation change, and which have not yet confirmed > + the new generation counter. But this number can instantly change after it is read, what good is it? It should never be relied on, so why is this needed at all? What can userspace do with this information? thanks, greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org> To: Adrian Catangiu <acatan@amazon.com> Cc: Jason@zx2c4.com, dgunigun@redhat.com, kvm@vger.kernel.org, linux-doc@vger.kernel.org, ghammer@redhat.com, vijaysun@ca.ibm.com, 0x7f454c46@gmail.com, qemu-devel@nongnu.org, mhocko@kernel.org, oridgar@gmail.com, avagin@gmail.com, pavel@ucw.cz, ptikhomirov@virtuozzo.com, linux-s390@vger.kernel.org, corbet@lwn.net, mpe@ellerman.id.au, mst@redhat.com, ebiggers@kernel.org, borntraeger@de.ibm.com, sblbir@amazon.com, bonzini@gnu.org, arnd@arndb.de, jannh@google.com, raduweis@amazon.com, asmehra@redhat.com, graf@amazon.com, rppt@kernel.org, luto@kernel.org, gil@azul.com, colmmacc@amazon.com, tytso@mit.edu, ovzxemul@gmail.com, areber@redhat.com, linux-kernel@vger.kernel.org, ebiederm@xmission.com, rafael@kernel.org, w@1wt.eu, dwmw@amazon.co.uk Subject: Re: [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver Date: Tue, 12 Jan 2021 14:08:15 +0100 [thread overview] Message-ID: <X/2fP9LNWXvp7up9@kroah.com> (raw) In-Reply-To: <1610453760-13812-2-git-send-email-acatan@amazon.com> On Tue, Jan 12, 2021 at 02:15:59PM +0200, Adrian Catangiu wrote: > +``read()``: > + Read is meant to provide the *new* system generation counter when a > + generation change takes place. The read operation blocks until the > + associated counter is no longer up to date, at which point the new > + counter is provided/returned. > + Nonblocking ``read()`` uses ``EAGAIN`` to signal that there is no > + *new* counter value available. The generation counter is considered > + *new* for each open file descriptor that hasn't confirmed the new > + value following a generation change. Therefore, once a generation > + change takes place, all ``read()`` calls will immediately return the > + new generation counter and will continue to do so until the > + new value is confirmed back to the driver through ``write()``. > + Partial reads are not allowed - read buffer needs to be at least > + ``sizeof(unsigned)`` in size. "sizeof(unsigned)"? How about being specific and making this a real "X bits big" value please. "unsigned" does not work well across user/kernel boundries. Ok, that's on understatement, the correct thing is "does not work at all". Please be specific in your apis. This is listed elsewhere also. > +``write()``: > + Write is used to confirm the up-to-date Sys Gen counter back to the > + driver. > + Following a VM generation change, all existing watchers are marked > + as *outdated*. Each file descriptor will maintain the *outdated* > + status until a ``write()`` confirms the up-to-date counter back to > + the driver. > + Partial writes are not allowed - write buffer should be exactly > + ``sizeof(unsigned)`` in size. > + > +``poll()``: > + Poll is implemented to allow polling for generation counter updates. > + Such updates result in ``EPOLLIN`` polling status until the new > + up-to-date counter is confirmed back to the driver through a > + ``write()``. > + > +``ioctl()``: > + The driver also adds support for tracking count of open file > + descriptors that haven't acknowledged a generation counter update, > + as well as a mechanism for userspace to *force* a generation update: > + > + - SYSGENID_GET_OUTDATED_WATCHERS: immediately returns the number of > + *outdated* watchers - number of file descriptors that were open > + during a system generation change, and which have not yet confirmed > + the new generation counter. But this number can instantly change after it is read, what good is it? It should never be relied on, so why is this needed at all? What can userspace do with this information? thanks, greg k-h
next prev parent reply other threads:[~2021-01-12 13:08 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-12 12:15 [PATCH v4 0/2] System Generation ID driver and VMGENID backend Adrian Catangiu 2021-01-12 12:15 ` Adrian Catangiu via 2021-01-12 12:15 ` Adrian Catangiu 2021-01-12 12:15 ` [PATCH v4 1/2] drivers/misc: sysgenid: add system generation id driver Adrian Catangiu 2021-01-12 12:15 ` Adrian Catangiu via 2021-01-12 12:15 ` Adrian Catangiu 2021-01-12 13:08 ` Greg KH [this message] 2021-01-12 13:08 ` Greg KH 2021-01-21 9:54 ` Catangiu, Adrian Costin 2021-01-21 9:54 ` acatan--- via 2021-01-12 13:08 ` Michael S. Tsirkin 2021-01-12 13:08 ` Michael S. Tsirkin 2021-01-21 12:48 ` Catangiu, Adrian Costin 2021-01-21 12:48 ` acatan--- via 2021-01-19 22:34 ` Randy Dunlap 2021-01-19 22:34 ` Randy Dunlap 2021-01-27 22:15 ` Pavel Machek 2021-01-27 22:15 ` Pavel Machek 2021-02-02 14:32 ` Michael S. Tsirkin 2021-02-02 14:32 ` Michael S. Tsirkin 2021-01-12 12:16 ` [PATCH v4 2/2] drivers/virt: vmgenid: add vm " Adrian Catangiu 2021-01-12 12:16 ` Adrian Catangiu via 2021-01-12 12:16 ` Adrian Catangiu 2021-01-12 12:48 ` [PATCH v4 0/2] System Generation ID driver and VMGENID backend Michael S. Tsirkin 2021-01-12 12:48 ` Michael S. Tsirkin 2021-01-21 10:28 ` Catangiu, Adrian Costin 2021-01-21 10:28 ` acatan--- via 2021-01-27 12:47 ` Michael S. Tsirkin 2021-01-27 12:47 ` Michael S. Tsirkin 2021-01-28 12:58 ` Alexander Graf 2021-01-28 12:58 ` graf--- via 2021-02-02 14:34 ` Michael S. Tsirkin 2021-02-02 14:34 ` Michael S. Tsirkin
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X/2fP9LNWXvp7up9@kroah.com \ --to=gregkh@linuxfoundation.org \ --cc=0x7f454c46@gmail.com \ --cc=Jason@zx2c4.com \ --cc=acatan@amazon.com \ --cc=areber@redhat.com \ --cc=arnd@arndb.de \ --cc=asmehra@redhat.com \ --cc=avagin@gmail.com \ --cc=bonzini@gnu.org \ --cc=borntraeger@de.ibm.com \ --cc=colmmacc@amazon.com \ --cc=corbet@lwn.net \ --cc=dgunigun@redhat.com \ --cc=dwmw@amazon.co.uk \ --cc=ebiederm@xmission.com \ --cc=ebiggers@kernel.org \ --cc=ghammer@redhat.com \ --cc=gil@azul.com \ --cc=graf@amazon.com \ --cc=jannh@google.com \ --cc=kvm@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-s390@vger.kernel.org \ --cc=luto@kernel.org \ --cc=mhocko@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=mst@redhat.com \ --cc=oridgar@gmail.com \ --cc=ovzxemul@gmail.com \ --cc=pavel@ucw.cz \ --cc=ptikhomirov@virtuozzo.com \ --cc=qemu-devel@nongnu.org \ --cc=raduweis@amazon.com \ --cc=rafael@kernel.org \ --cc=rppt@kernel.org \ --cc=sblbir@amazon.com \ --cc=tytso@mit.edu \ --cc=vijaysun@ca.ibm.com \ --cc=w@1wt.eu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.