All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Andrej Valek <andrej.valek@siemens.com>,
	Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-input@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] Input: st1232 - do not read more bytes than needed
Date: Sun, 3 Jan 2021 17:45:13 -0800	[thread overview]
Message-ID: <X/JzKWMVkfskc4M+@google.com> (raw)
In-Reply-To: <20201229162601.2154566-3-geert+renesas@glider.be>

On Tue, Dec 29, 2020 at 05:26:00PM +0100, Geert Uytterhoeven wrote:
> st1232_ts_read_data() already reads ts->read_buf_len bytes (8 or 20
> bytes) from the touchscreen controller.  This was fine when it was used
> to read touch point coordinates only, but is overkill for reading the
> touchscreen resolution, which just needs 3 bytes.
> 
> Optimize transfers by passing the wanted number of bytes.
> 
> Fixes: 3a54a215410b1650 ("Input: st1232 - add support resolution reading")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Applied, thank you.

-- 
Dmitry

  reply	other threads:[~2021-01-04  1:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-29 16:25 [PATCH 0/3] Input: st1232 - fixes for resolution reading Geert Uytterhoeven
2020-12-29 16:25 ` [PATCH 1/3] Input: st1232 - fix off-by-one error in resolution handling Geert Uytterhoeven
2021-01-04  1:44   ` Dmitry Torokhov
2020-12-29 16:26 ` [PATCH 2/3] Input: st1232 - do not read more bytes than needed Geert Uytterhoeven
2021-01-04  1:45   ` Dmitry Torokhov [this message]
2020-12-29 16:26 ` [PATCH 3/3] Input: st1232 - wait until device is ready before reading resolution Geert Uytterhoeven
2021-01-04  1:45   ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X/JzKWMVkfskc4M+@google.com \
    --to=dmitry.torokhov@gmail.com \
    --cc=andrej.valek@siemens.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=wsa+renesas@sang-engineering.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.