From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Andrej Valek <andrej.valek@siemens.com>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
linux-input@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] Input: st1232 - wait until device is ready before reading resolution
Date: Sun, 3 Jan 2021 17:45:59 -0800 [thread overview]
Message-ID: <X/JzV6+EF58kysci@google.com> (raw)
In-Reply-To: <20201229162601.2154566-4-geert+renesas@glider.be>
On Tue, Dec 29, 2020 at 05:26:01PM +0100, Geert Uytterhoeven wrote:
> According to the st1232 datasheet, the host has to wait for the device
> to change into Normal state before accessing registers other than the
> Status Register.
>
> If the reset GPIO is wired, the device is powered on during driver
> probe, just before reading the resolution. However, the latter may
> happen before the device is ready, leading to a probe failure:
>
> st1232-ts 1-0055: Failed to read resolution: -6
>
> Fix this by waiting until the device is ready, by trying to read the
> Status Register until it indicates so, or until timeout.
>
> On Armadillo 800 EVA, typically the first read fails with an I2C
> transfer error, while the second read indicates the device is ready.
>
> Fixes: 3a54a215410b1650 ("Input: st1232 - add support resolution reading")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Applied, thank you.
--
Dmitry
prev parent reply other threads:[~2021-01-04 1:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-29 16:25 [PATCH 0/3] Input: st1232 - fixes for resolution reading Geert Uytterhoeven
2020-12-29 16:25 ` [PATCH 1/3] Input: st1232 - fix off-by-one error in resolution handling Geert Uytterhoeven
2021-01-04 1:44 ` Dmitry Torokhov
2020-12-29 16:26 ` [PATCH 2/3] Input: st1232 - do not read more bytes than needed Geert Uytterhoeven
2021-01-04 1:45 ` Dmitry Torokhov
2020-12-29 16:26 ` [PATCH 3/3] Input: st1232 - wait until device is ready before reading resolution Geert Uytterhoeven
2021-01-04 1:45 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/JzV6+EF58kysci@google.com \
--to=dmitry.torokhov@gmail.com \
--cc=andrej.valek@siemens.com \
--cc=geert+renesas@glider.be \
--cc=linux-input@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.