All of lore.kernel.org
 help / color / mirror / Atom feed
* [Intel-gfx] [PATCH 1/6] drm/i915/selftests: Set error returns
@ 2021-01-04 11:51 Chris Wilson
  2021-01-04 11:51 ` [Intel-gfx] [PATCH 2/6] drm/i915: Set rawclk earlier during mmio probe Chris Wilson
                   ` (11 more replies)
  0 siblings, 12 replies; 20+ messages in thread
From: Chris Wilson @ 2021-01-04 11:51 UTC (permalink / raw)
  To: intel-gfx; +Cc: Chris Wilson

A few missed PTR_ERR() upon create_gang() errors.

Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/selftest_execlists.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/selftest_execlists.c b/drivers/gpu/drm/i915/gt/selftest_execlists.c
index 080b63000a4e..3854da5a4e65 100644
--- a/drivers/gpu/drm/i915/gt/selftest_execlists.c
+++ b/drivers/gpu/drm/i915/gt/selftest_execlists.c
@@ -2658,8 +2658,10 @@ static int create_gang(struct intel_engine_cs *engine,
 		goto err_obj;
 
 	cs = i915_gem_object_pin_map(obj, I915_MAP_WC);
-	if (IS_ERR(cs))
+	if (IS_ERR(cs)) {
+		err = PTR_ERR(cs);
 		goto err_obj;
+	}
 
 	/* Semaphore target: spin until zero */
 	*cs++ = MI_ARB_ON_OFF | MI_ARB_ENABLE;
@@ -2686,8 +2688,10 @@ static int create_gang(struct intel_engine_cs *engine,
 	i915_gem_object_unpin_map(obj);
 
 	rq = intel_context_create_request(ce);
-	if (IS_ERR(rq))
+	if (IS_ERR(rq)) {
+		err = PTR_ERR(rq);
 		goto err_obj;
+	}
 
 	rq->batch = i915_vma_get(vma);
 	i915_request_get(rq);
-- 
2.20.1

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2021-01-06  3:49 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-04 11:51 [Intel-gfx] [PATCH 1/6] drm/i915/selftests: Set error returns Chris Wilson
2021-01-04 11:51 ` [Intel-gfx] [PATCH 2/6] drm/i915: Set rawclk earlier during mmio probe Chris Wilson
2021-01-05  1:53   ` Andi Shyti
2021-01-04 11:51 ` [Intel-gfx] [PATCH 3/6] drm/i915/gt: Allow failed resets without assertion Chris Wilson
2021-01-05  1:55   ` Andi Shyti
2021-01-04 11:51 ` [Intel-gfx] [PATCH 4/6] drm/i915/gt: Check the virtual still matches upon locking Chris Wilson
2021-01-05  1:55   ` Andi Shyti
2021-01-04 11:51 ` [Intel-gfx] [PATCH 5/6] drm/i915/gt: Restore ce->signal flush before releasing virtual engine Chris Wilson
2021-01-05  1:57   ` Andi Shyti
2021-01-04 11:51 ` [Intel-gfx] [PATCH 6/6] drm/i915/gt: Remove timeslice suppression Chris Wilson
2021-01-06  0:07   ` Andi Shyti
2021-01-06  0:27     ` Chris Wilson
2021-01-06  0:29   ` [Intel-gfx] [PATCH] " Chris Wilson
2021-01-04 12:35 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915/selftests: Set error returns Patchwork
2021-01-04 13:05 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-04 15:04 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-01-05  1:53 ` [Intel-gfx] [PATCH 1/6] " Andi Shyti
2021-01-06  1:07 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/i915/selftests: Set error returns (rev2) Patchwork
2021-01-06  1:36 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-01-06  3:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.