* [PATCH net-next] net: mvneta: fix error message when MTU too large for XDP
@ 2021-01-05 16:38 Marek Behún
2021-01-05 17:15 ` Marek Behún
2021-01-05 20:06 ` Andrew Lunn
0 siblings, 2 replies; 3+ messages in thread
From: Marek Behún @ 2021-01-05 16:38 UTC (permalink / raw)
To: netdev
Cc: davem, Jakub Kicinski, Marek Behún, Lorenzo Bianconi,
Thomas Petazzoni
The error message says that "Jumbo frames are not supported on XDP", but
the code checks for mtu > MVNETA_MAX_RX_BUF_SIZE, not mtu > 1500.
Fix this error message.
Signed-off-by: Marek Behún <kabel@kernel.org>
Fixes: 0db51da7a8e9 ("net: mvneta: add basic XDP support")
Cc: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
drivers/net/ethernet/marvell/mvneta.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index 563ceac3060f..8adbfa25465d 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -4432,7 +4432,7 @@ static int mvneta_xdp_setup(struct net_device *dev, struct bpf_prog *prog,
struct bpf_prog *old_prog;
if (prog && dev->mtu > MVNETA_MAX_RX_BUF_SIZE) {
- NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not supported on XDP");
+ NL_SET_ERR_MSG_MOD(extack, "XDP is not supported with MTU > %d", dev->mtu);
return -EOPNOTSUPP;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mvneta: fix error message when MTU too large for XDP
2021-01-05 16:38 [PATCH net-next] net: mvneta: fix error message when MTU too large for XDP Marek Behún
@ 2021-01-05 17:15 ` Marek Behún
2021-01-05 20:06 ` Andrew Lunn
1 sibling, 0 replies; 3+ messages in thread
From: Marek Behún @ 2021-01-05 17:15 UTC (permalink / raw)
To: netdev; +Cc: davem, Jakub Kicinski, Lorenzo Bianconi, Thomas Petazzoni
OMG, please ignore this, I thought that NL_SET_ERR_MSG_MOD takes printf
like arguments.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH net-next] net: mvneta: fix error message when MTU too large for XDP
2021-01-05 16:38 [PATCH net-next] net: mvneta: fix error message when MTU too large for XDP Marek Behún
2021-01-05 17:15 ` Marek Behún
@ 2021-01-05 20:06 ` Andrew Lunn
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2021-01-05 20:06 UTC (permalink / raw)
To: Marek Behún
Cc: netdev, davem, Jakub Kicinski, Lorenzo Bianconi, Thomas Petazzoni
On Tue, Jan 05, 2021 at 05:38:33PM +0100, Marek Behún wrote:
> The error message says that "Jumbo frames are not supported on XDP", but
> the code checks for mtu > MVNETA_MAX_RX_BUF_SIZE, not mtu > 1500.
>
> Fix this error message.
>
> Signed-off-by: Marek Behún <kabel@kernel.org>
> Fixes: 0db51da7a8e9 ("net: mvneta: add basic XDP support")
> Cc: Lorenzo Bianconi <lorenzo@kernel.org>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
> drivers/net/ethernet/marvell/mvneta.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
> index 563ceac3060f..8adbfa25465d 100644
> --- a/drivers/net/ethernet/marvell/mvneta.c
> +++ b/drivers/net/ethernet/marvell/mvneta.c
> @@ -4432,7 +4432,7 @@ static int mvneta_xdp_setup(struct net_device *dev, struct bpf_prog *prog,
> struct bpf_prog *old_prog;
>
> if (prog && dev->mtu > MVNETA_MAX_RX_BUF_SIZE) {
> - NL_SET_ERR_MSG_MOD(extack, "Jumbo frames not supported on XDP");
> + NL_SET_ERR_MSG_MOD(extack, "XDP is not supported with MTU > %d", dev->mtu);
> return -EOPNOTSUPP;
Hi Marek
In addition to the OMG, don't you actually want to print
MVNETA_MAX_RX_BUF_SIZE, not the dev->mtu?
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-01-05 20:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-05 16:38 [PATCH net-next] net: mvneta: fix error message when MTU too large for XDP Marek Behún
2021-01-05 17:15 ` Marek Behún
2021-01-05 20:06 ` Andrew Lunn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.