From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> To: conor.dooley@microchip.com Cc: robh+dt@kernel.org, damien.lemoal@wdc.com, jassisinghbrar@gmail.com, aou@eecs.berkeley.edu, paul.walmsley@sifive.com, palmer@dabbelt.com, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, lewis.hanly@microchip.com, cyril.jean@microchip.com, daire.mcnamara@microchip.com, atish.patra@wdc.com, anup.patel@wdc.com, david.abdurachmanov@gmail.com, j.neuschaefer@gmx.net Subject: Re: [PATCH v3 4/5] dt-bindings: add bindings for polarfire soc system controller Date: Tue, 5 Jan 2021 22:25:25 +0100 [thread overview] Message-ID: <X/TZRXPQv0wXvT+0@latitude> (raw) In-Reply-To: <20201223163316.29186-1-conor.dooley@microchip.com> [-- Attachment #1: Type: text/plain, Size: 2285 bytes --] Hi, On Wed, Dec 23, 2020 at 04:33:16PM +0000, conor.dooley@microchip.com wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > Add device tree bindings for the MSS system controller on > the Microchip PolarFire SoC. "MSS" doesn't appear below, so perhaps an expansion in parentheses would be nice, e.g.: "MSS (microprocessor subsystem)" > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../microchip,mpfs_sys_controller.yaml | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml > > diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml > new file mode 100644 > index 000000000000..60fde1925910 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/microchip/microchip,mpfs_sys_controller.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Microchip PolarFire SoC (MPFS) system controller > + > +maintainers: > + - Conor Dooley <conor.dooley@microchip.com> > + > +properties: > + compatible: > + const: microchip,polarfire-soc-sys-controller The file name and compatible string are inconsistent in phrasing (mpfs- vs. polarfire-soc-). If possible, please align them. > + > + mboxes: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + description: | > + phandle and index of the mailbox controller device node. > + See: ../mailbox/mailbox.txt for more information. > + maxItems: 1 > + > +required: > + - compatible > + - "mboxes" Quotation marks are unnecessary here, because there are no special characters in "mboxes". > + > +additionalProperties: false > + > +examples: > + - | > + syscontroller: syscontroller { > + compatible = "microchip,polarfire-soc-sys-controller"; > + mboxes = <&mbox 0>; > + }; > -- Best regards, Jonathan Neuschäfer [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Jonathan Neuschäfer" <j.neuschaefer@gmx.net> To: conor.dooley@microchip.com Cc: devicetree@vger.kernel.org, damien.lemoal@wdc.com, aou@eecs.berkeley.edu, lewis.hanly@microchip.com, david.abdurachmanov@gmail.com, daire.mcnamara@microchip.com, jassisinghbrar@gmail.com, j.neuschaefer@gmx.net, atish.patra@wdc.com, anup.patel@wdc.com, robh+dt@kernel.org, palmer@dabbelt.com, paul.walmsley@sifive.com, cyril.jean@microchip.com, linux-riscv@lists.infradead.org Subject: Re: [PATCH v3 4/5] dt-bindings: add bindings for polarfire soc system controller Date: Tue, 5 Jan 2021 22:25:25 +0100 [thread overview] Message-ID: <X/TZRXPQv0wXvT+0@latitude> (raw) In-Reply-To: <20201223163316.29186-1-conor.dooley@microchip.com> [-- Attachment #1.1: Type: text/plain, Size: 2285 bytes --] Hi, On Wed, Dec 23, 2020 at 04:33:16PM +0000, conor.dooley@microchip.com wrote: > From: Conor Dooley <conor.dooley@microchip.com> > > Add device tree bindings for the MSS system controller on > the Microchip PolarFire SoC. "MSS" doesn't appear below, so perhaps an expansion in parentheses would be nice, e.g.: "MSS (microprocessor subsystem)" > > Signed-off-by: Conor Dooley <conor.dooley@microchip.com> > --- > .../microchip,mpfs_sys_controller.yaml | 34 +++++++++++++++++++ > 1 file changed, 34 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml > > diff --git a/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml > new file mode 100644 > index 000000000000..60fde1925910 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/microchip/microchip,mpfs_sys_controller.yaml > @@ -0,0 +1,34 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/microchip/microchip,mpfs_sys_controller.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Microchip PolarFire SoC (MPFS) system controller > + > +maintainers: > + - Conor Dooley <conor.dooley@microchip.com> > + > +properties: > + compatible: > + const: microchip,polarfire-soc-sys-controller The file name and compatible string are inconsistent in phrasing (mpfs- vs. polarfire-soc-). If possible, please align them. > + > + mboxes: > + $ref: '/schemas/types.yaml#/definitions/phandle-array' > + description: | > + phandle and index of the mailbox controller device node. > + See: ../mailbox/mailbox.txt for more information. > + maxItems: 1 > + > +required: > + - compatible > + - "mboxes" Quotation marks are unnecessary here, because there are no special characters in "mboxes". > + > +additionalProperties: false > + > +examples: > + - | > + syscontroller: syscontroller { > + compatible = "microchip,polarfire-soc-sys-controller"; > + mboxes = <&mbox 0>; > + }; > -- Best regards, Jonathan Neuschäfer [-- Attachment #1.2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] [-- Attachment #2: Type: text/plain, Size: 161 bytes --] _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2021-01-05 21:27 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-23 16:32 [PATCH v3 0/5] Add support for the PolarFire SoC system controller conor.dooley 2020-12-23 16:32 ` conor.dooley 2020-12-23 16:32 ` [PATCH v3 1/5] mbox: add polarfire soc system controller mailbox conor.dooley 2020-12-23 16:32 ` conor.dooley 2021-01-02 13:01 ` Jonathan Neuschäfer 2021-01-02 13:01 ` Jonathan Neuschäfer 2021-01-21 12:46 ` Conor.Dooley 2021-01-21 12:46 ` Conor.Dooley 2021-01-21 13:38 ` Jonathan Neuschäfer 2021-01-21 13:38 ` Jonathan Neuschäfer 2020-12-23 16:33 ` [PATCH v3 2/5] dt-bindings: add bindings for polarfire soc mailbox conor.dooley 2020-12-23 16:33 ` conor.dooley 2020-12-31 18:34 ` Rob Herring 2020-12-31 18:34 ` Rob Herring 2021-01-02 11:30 ` Jonathan Neuschäfer 2021-01-02 11:30 ` Jonathan Neuschäfer 2020-12-23 16:33 ` [PATCH v3 4/5] dt-bindings: add bindings for polarfire soc system controller conor.dooley 2020-12-23 16:33 ` conor.dooley 2021-01-05 21:25 ` Jonathan Neuschäfer [this message] 2021-01-05 21:25 ` Jonathan Neuschäfer 2021-01-08 2:31 ` Rob Herring 2021-01-08 2:31 ` Rob Herring 2021-01-06 19:25 ` [PATCH v3 0/5] Add support for the PolarFire SoC " Atish Patra 2021-01-06 19:25 ` Atish Patra 2021-01-07 11:49 ` Cyril.Jean 2021-01-07 11:49 ` Cyril.Jean
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X/TZRXPQv0wXvT+0@latitude \ --to=j.neuschaefer@gmx.net \ --cc=anup.patel@wdc.com \ --cc=aou@eecs.berkeley.edu \ --cc=atish.patra@wdc.com \ --cc=conor.dooley@microchip.com \ --cc=cyril.jean@microchip.com \ --cc=daire.mcnamara@microchip.com \ --cc=damien.lemoal@wdc.com \ --cc=david.abdurachmanov@gmail.com \ --cc=devicetree@vger.kernel.org \ --cc=jassisinghbrar@gmail.com \ --cc=lewis.hanly@microchip.com \ --cc=linux-riscv@lists.infradead.org \ --cc=palmer@dabbelt.com \ --cc=paul.walmsley@sifive.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.