From: Andrew Lunn <andrew@lunn.ch>
To: M Chetan Kumar <m.chetan.kumar@intel.com>
Cc: netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
johannes@sipsolutions.net, krishna.c.sudi@intel.com
Subject: Re: [PATCH 11/18] net: iosm: encode or decode datagram
Date: Thu, 7 Jan 2021 22:56:19 +0100 [thread overview]
Message-ID: <X/eDg7jNQ6/VIY5K@lunn.ch> (raw)
In-Reply-To: <20210107170523.26531-12-m.chetan.kumar@intel.com>
> +/* Pass the DL packet to the netif layer. */
> +static int mux_net_receive(struct iosm_mux *ipc_mux, int if_id,
> + struct iosm_wwan *wwan, u32 offset, u8 service_class,
> + struct sk_buff *skb)
> +{
> + /* for "zero copy" use clone */
> + struct sk_buff *dest_skb = skb_clone(skb, GFP_ATOMIC);
> +
> + if (!dest_skb)
> + return -1;
> +
> + skb_pull(dest_skb, offset);
> +
> + skb_set_tail_pointer(dest_skb, dest_skb->len);
> +
> + /* Goto the start of the Ethernet header. */
> + skb_push(dest_skb, ETH_HLEN);
> +
> + /* map session to vlan */
> + __vlan_hwaccel_put_tag(dest_skb, htons(ETH_P_8021Q), if_id + 1);
Well, that explains a bit, my comments on the netdev patch. So there
is no Ethernet header on the 'wire'. This is not an Ethernet device at
all.
More in the documentation patch...
Andrew
next prev parent reply other threads:[~2021-01-07 21:57 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-07 17:05 [PATCH 00/18] net: iosm: PCIe Driver for Intel M.2 Modem M Chetan Kumar
2021-01-07 17:05 ` [PATCH 01/18] net: iosm: entry point M Chetan Kumar
2021-01-07 17:05 ` [PATCH 02/18] net: iosm: irq handling M Chetan Kumar
2021-01-07 17:05 ` [PATCH 03/18] net: iosm: mmio scratchpad M Chetan Kumar
2021-01-07 17:05 ` [PATCH 04/18] net: iosm: shared memory IPC interface M Chetan Kumar
2021-01-07 17:05 ` [PATCH 05/18] net: iosm: shared memory I/O operations M Chetan Kumar
2021-01-07 17:05 ` [PATCH 06/18] net: iosm: channel configuration M Chetan Kumar
2021-01-07 17:05 ` [PATCH 07/18] net: iosm: char device for FW flash & coredump M Chetan Kumar
2021-01-07 19:35 ` Andrew Lunn
2021-01-07 17:05 ` [PATCH 08/18] net: iosm: MBIM control device M Chetan Kumar
2021-01-07 17:05 ` [PATCH 09/18] net: iosm: bottom half M Chetan Kumar
2021-01-07 17:05 ` [PATCH 10/18] net: iosm: multiplex IP sessions M Chetan Kumar
2021-01-07 17:05 ` [PATCH 11/18] net: iosm: encode or decode datagram M Chetan Kumar
2021-01-07 21:56 ` Andrew Lunn [this message]
2021-01-07 17:05 ` [PATCH 12/18] net: iosm: power management M Chetan Kumar
2021-01-07 17:05 ` [PATCH 13/18] net: iosm: shared memory protocol M Chetan Kumar
2021-01-07 17:05 ` [PATCH 14/18] net: iosm: protocol operations M Chetan Kumar
2021-01-07 17:05 ` [PATCH 15/18] net: iosm: uevent support M Chetan Kumar
2021-01-07 17:05 ` [PATCH 16/18] net: iosm: net driver M Chetan Kumar
2021-01-07 20:11 ` Andrew Lunn
2021-01-07 17:05 ` [PATCH 17/18] net: iosm: readme file M Chetan Kumar
2021-01-07 22:23 ` Andrew Lunn
2021-01-15 9:15 ` Johannes Berg
2021-01-17 17:26 ` Bjørn Mork
2021-01-20 19:34 ` Andrew Lunn
2021-01-20 23:32 ` Jakub Kicinski
2021-01-21 1:34 ` Dan Williams
2021-01-22 23:45 ` Andrew Lunn
2021-01-07 17:05 ` [PATCH 18/18] net: iosm: infrastructure M Chetan Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X/eDg7jNQ6/VIY5K@lunn.ch \
--to=andrew@lunn.ch \
--cc=johannes@sipsolutions.net \
--cc=krishna.c.sudi@intel.com \
--cc=linux-wireless@vger.kernel.org \
--cc=m.chetan.kumar@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.