From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Xin Ji <xji@analogixsemi.com> Cc: "Rob Herring" <robh+dt@kernel.org>, "David Airlie" <airlied@linux.ie>, "Nicolas Boichat" <drinkcat@google.com>, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Daniel Vetter" <daniel@ffwll.ch>, "Sam Ravnborg" <sam@ravnborg.org>, "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>, "Maxime Ripard" <mripard@kernel.org>, "Mark Brown" <broonie@kernel.org>, "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, "Sheng Pan" <span@analogixsemi.com>, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting Date: Mon, 28 Dec 2020 17:08:56 +0200 [thread overview] Message-ID: <X+n1COtS8nrCFUHd@pendragon.ideasonboard.com> (raw) In-Reply-To: <c29b7d9fda9ce8619d1c718b077250998a8600b8.1608883950.git.xji@analogixsemi.com> Hi Xin Ji, Thank you for the patch. On Fri, Dec 25, 2020 at 07:01:09PM +0800, Xin Ji wrote: > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > swing setting for adjusting DP tx PHY swing > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 60585a4..34a7faf 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,14 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + anx,swing-setting: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: an array of swing register setting for DP tx PHY Register values in DT are frowned upon. > + anx,mipi-dpi-in: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: indicate the MIPI rx signal type is DPI or DSI This sounds similar to the bus-type property defined in Documentation/devicetree/bindings/media/video-interfaces.txt (which is getting converted to YAML, Rob has posted a patch series, I expect it to land in v5.13). I think it would make sense to extend bus-type to support DSI, and use that property. > + > ports: > type: object > > @@ -72,6 +80,17 @@ examples: > reg = <0x58>; > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > + anx,swing-setting = <0x00 0x14>, <0x01 0x54>, > + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, > + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, > + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>, > + <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, > + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, > + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, > + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, > + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, > + <0x26 0x40>, <0x27 0x60>; > + anx,mipi-dpi-in = <0>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Xin Ji <xji@analogixsemi.com> Cc: "Nicolas Boichat" <drinkcat@google.com>, "Laurent Pinchart" <laurent.pinchart+renesas@ideasonboard.com>, devicetree@vger.kernel.org, "David Airlie" <airlied@linux.ie>, "Ricardo Cañuelo" <ricardo.canuelo@collabora.com>, "Mark Brown" <broonie@kernel.org>, linux-kernel@vger.kernel.org, "Rob Herring" <robh+dt@kernel.org>, dri-devel@lists.freedesktop.org, "Hsin-Yi Wang" <hsinyi@chromium.org>, "Sam Ravnborg" <sam@ravnborg.org>, "Sheng Pan" <span@analogixsemi.com> Subject: Re: [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting Date: Mon, 28 Dec 2020 17:08:56 +0200 [thread overview] Message-ID: <X+n1COtS8nrCFUHd@pendragon.ideasonboard.com> (raw) In-Reply-To: <c29b7d9fda9ce8619d1c718b077250998a8600b8.1608883950.git.xji@analogixsemi.com> Hi Xin Ji, Thank you for the patch. On Fri, Dec 25, 2020 at 07:01:09PM +0800, Xin Ji wrote: > Add DPI flag for distinguish MIPI input signal type, DSI or DPI. Add > swing setting for adjusting DP tx PHY swing > > Signed-off-by: Xin Ji <xji@analogixsemi.com> > --- > .../bindings/display/bridge/analogix,anx7625.yaml | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > index 60585a4..34a7faf 100644 > --- a/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/analogix,anx7625.yaml > @@ -34,6 +34,14 @@ properties: > description: used for reset chip control, RESET_N pin B7. > maxItems: 1 > > + anx,swing-setting: > + $ref: /schemas/types.yaml#/definitions/uint32-array > + description: an array of swing register setting for DP tx PHY Register values in DT are frowned upon. > + anx,mipi-dpi-in: > + $ref: /schemas/types.yaml#/definitions/uint32 > + description: indicate the MIPI rx signal type is DPI or DSI This sounds similar to the bus-type property defined in Documentation/devicetree/bindings/media/video-interfaces.txt (which is getting converted to YAML, Rob has posted a patch series, I expect it to land in v5.13). I think it would make sense to extend bus-type to support DSI, and use that property. > + > ports: > type: object > > @@ -72,6 +80,17 @@ examples: > reg = <0x58>; > enable-gpios = <&pio 45 GPIO_ACTIVE_HIGH>; > reset-gpios = <&pio 73 GPIO_ACTIVE_HIGH>; > + anx,swing-setting = <0x00 0x14>, <0x01 0x54>, > + <0x02 0x64>, <0x03 0x74>, <0x04 0x29>, > + <0x05 0x7b>, <0x06 0x77>, <0x07 0x5b>, > + <0x08 0x7f>, <0x0c 0x20>, <0x0d 0x60>, > + <0x10 0x60>, <0x12 0x40>, <0x13 0x60>, > + <0x14 0x14>, <0x15 0x54>, <0x16 0x64>, > + <0x17 0x74>, <0x18 0x29>, <0x19 0x7b>, > + <0x1a 0x77>, <0x1b 0x5b>, <0x1c 0x7f>, > + <0x20 0x20>, <0x21 0x60>, <0x24 0x60>, > + <0x26 0x40>, <0x27 0x60>; > + anx,mipi-dpi-in = <0>; > > ports { > #address-cells = <1>; -- Regards, Laurent Pinchart _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-12-28 15:10 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-25 10:58 [PATCH v1 0/2] Add MIPI rx DPI support Xin Ji 2020-12-25 10:58 ` Xin Ji 2020-12-25 10:58 ` Xin Ji 2020-12-25 11:01 ` [PATCH v1 1/2] dt-bindings: drm/bridge: anx7625: add DPI flag and swing setting Xin Ji 2020-12-25 11:01 ` Xin Ji 2020-12-26 0:16 ` Rob Herring 2020-12-26 0:16 ` Rob Herring 2020-12-27 16:56 ` Rob Herring 2020-12-27 16:56 ` Rob Herring 2020-12-29 5:55 ` Xin Ji 2020-12-29 5:55 ` Xin Ji 2020-12-28 15:08 ` Laurent Pinchart [this message] 2020-12-28 15:08 ` Laurent Pinchart 2020-12-29 6:50 ` Xin Ji 2020-12-29 6:50 ` Xin Ji 2020-12-29 14:34 ` Laurent Pinchart 2020-12-29 14:34 ` Laurent Pinchart 2020-12-30 6:52 ` Xin Ji 2020-12-30 6:52 ` Xin Ji 2020-12-25 11:02 ` [PATCH v1 2/2] drm/bridge: anx7625: add MIPI DPI input feature support Xin Ji 2020-12-25 11:02 ` Xin Ji 2020-12-25 11:02 ` Xin Ji 2020-12-29 5:37 ` kernel test robot 2020-12-30 15:42 ` kernel test robot 2021-01-04 14:50 ` Dan Carpenter 2021-01-04 14:50 ` Dan Carpenter 2021-01-04 14:50 ` Dan Carpenter 2021-01-12 8:20 ` Xin Ji 2021-01-12 8:20 ` Xin Ji 2021-01-12 8:20 ` Xin Ji
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X+n1COtS8nrCFUHd@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=airlied@linux.ie \ --cc=broonie@kernel.org \ --cc=daniel@ffwll.ch \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=drinkcat@google.com \ --cc=hsinyi@chromium.org \ --cc=laurent.pinchart+renesas@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mripard@kernel.org \ --cc=ricardo.canuelo@collabora.com \ --cc=robh+dt@kernel.org \ --cc=sam@ravnborg.org \ --cc=span@analogixsemi.com \ --cc=xji@analogixsemi.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.