All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
@ 2020-11-20 23:46 ` David Gow
  0 siblings, 0 replies; 4+ messages in thread
From: David Gow @ 2020-11-20 23:46 UTC (permalink / raw)
  To: Moritz Fischer, Xu Yilun, Tom Rix
  Cc: David Gow, linux-fpga, Linux Kernel Mailing List, linux-um,
	Brendan Higgins

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
HAS_IOMEM.

Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
Signed-off-by: David Gow <davidgow@google.com>
---

Changes since v1:
( https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-davidgow@google.com/ )
- Add Fixes tag

 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 7cd5a29fc437..5645226ca3ce 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
-- 
2.29.2.454.gaff20da3a2-goog


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
@ 2020-11-20 23:46 ` David Gow
  0 siblings, 0 replies; 4+ messages in thread
From: David Gow @ 2020-11-20 23:46 UTC (permalink / raw)
  To: Moritz Fischer, Xu Yilun, Tom Rix
  Cc: Brendan Higgins, linux-fpga, linux-um, Linux Kernel Mailing List,
	David Gow

Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
functions, it should depend on HAS_IOMEM.

This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
HAS_IOMEM.

Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
Signed-off-by: David Gow <davidgow@google.com>
---

Changes since v1:
( https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-davidgow@google.com/ )
- Add Fixes tag

 drivers/fpga/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
index 7cd5a29fc437..5645226ca3ce 100644
--- a/drivers/fpga/Kconfig
+++ b/drivers/fpga/Kconfig
@@ -142,6 +142,7 @@ config FPGA_DFL
 	tristate "FPGA Device Feature List (DFL) support"
 	select FPGA_BRIDGE
 	select FPGA_REGION
+	depends on HAS_IOMEM
 	help
 	  Device Feature List (DFL) defines a feature list structure that
 	  creates a linked list of feature headers within the MMIO space
-- 
2.29.2.454.gaff20da3a2-goog


_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
  2020-11-20 23:46 ` David Gow
@ 2020-11-22  0:18   ` Moritz Fischer
  -1 siblings, 0 replies; 4+ messages in thread
From: Moritz Fischer @ 2020-11-22  0:18 UTC (permalink / raw)
  To: David Gow
  Cc: Moritz Fischer, Xu Yilun, Tom Rix, linux-fpga,
	Linux Kernel Mailing List, linux-um, Brendan Higgins

On Fri, Nov 20, 2020 at 03:46:48PM -0800, David Gow wrote:
> Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> functions, it should depend on HAS_IOMEM.
> 
> This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> HAS_IOMEM.
> 
> Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
> Signed-off-by: David Gow <davidgow@google.com>
> ---
> 
> Changes since v1:
> ( https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-davidgow@google.com/ )
> - Add Fixes tag
> 
>  drivers/fpga/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 7cd5a29fc437..5645226ca3ce 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -142,6 +142,7 @@ config FPGA_DFL
>  	tristate "FPGA Device Feature List (DFL) support"
>  	select FPGA_BRIDGE
>  	select FPGA_REGION
> +	depends on HAS_IOMEM
>  	help
>  	  Device Feature List (DFL) defines a feature list structure that
>  	  creates a linked list of feature headers within the MMIO space
> -- 
> 2.29.2.454.gaff20da3a2-goog
> 

Applied to for-5.10,

I fixed up your commit message (dropped the drivers:)

- Moritz

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL
@ 2020-11-22  0:18   ` Moritz Fischer
  0 siblings, 0 replies; 4+ messages in thread
From: Moritz Fischer @ 2020-11-22  0:18 UTC (permalink / raw)
  To: David Gow
  Cc: Tom Rix, linux-fpga, linux-um, Linux Kernel Mailing List,
	Moritz Fischer, Xu Yilun, Brendan Higgins

On Fri, Nov 20, 2020 at 03:46:48PM -0800, David Gow wrote:
> Because dfl.c uses the 'devm_ioremap', 'devm_iounmap',
> 'devm_ioremap_resource', and 'devm_platform_ioremap_resource'
> functions, it should depend on HAS_IOMEM.
> 
> This fixes make allyesconfig under UML (ARCH=um), which doesn't provide
> HAS_IOMEM.
> 
> Fixes: 89eb35e810a8 ("fpga: dfl: map feature mmio resources in their own feature drivers")
> Signed-off-by: David Gow <davidgow@google.com>
> ---
> 
> Changes since v1:
> ( https://lore.kernel.org/linux-fpga/20201119082209.3598354-1-davidgow@google.com/ )
> - Add Fixes tag
> 
>  drivers/fpga/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/fpga/Kconfig b/drivers/fpga/Kconfig
> index 7cd5a29fc437..5645226ca3ce 100644
> --- a/drivers/fpga/Kconfig
> +++ b/drivers/fpga/Kconfig
> @@ -142,6 +142,7 @@ config FPGA_DFL
>  	tristate "FPGA Device Feature List (DFL) support"
>  	select FPGA_BRIDGE
>  	select FPGA_REGION
> +	depends on HAS_IOMEM
>  	help
>  	  Device Feature List (DFL) defines a feature list structure that
>  	  creates a linked list of feature headers within the MMIO space
> -- 
> 2.29.2.454.gaff20da3a2-goog
> 

Applied to for-5.10,

I fixed up your commit message (dropped the drivers:)

- Moritz

_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um


^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-22  0:18 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-20 23:46 [PATCH v2] drivers: fpga: Specify HAS_IOMEM dependency for FPGA_DFL David Gow
2020-11-20 23:46 ` David Gow
2020-11-22  0:18 ` Moritz Fischer
2020-11-22  0:18   ` Moritz Fischer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.