From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Michal Simek <michal.simek@xilinx.com> Cc: linux-kernel@vger.kernel.org, monstr@monstr.eu, git@xilinx.com, Kalyani Akula <kalyani.akula@xilinx.com>, Krzysztof Kozlowski <krzk@kernel.org>, Manish Narani <manish.narani@xilinx.com>, Rajan Vaja <rajan.vaja@xilinx.com>, Rob Herring <robh+dt@kernel.org>, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi Date: Tue, 8 Dec 2020 00:16:02 +0200 [thread overview] Message-ID: <X86poiQSzv5Uva1r@pendragon.ideasonboard.com> (raw) In-Reply-To: <99008851-6c12-3acc-6530-25af08429ff5@xilinx.com> Hi Michal, On Mon, Dec 07, 2020 at 10:39:25AM +0100, Michal Simek wrote: > On 06. 12. 20 23:46, Laurent Pinchart wrote: > > On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote: > >> Add label which is used by bootloader for adding bootloader specific flag. > >> > >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > >> --- > >> > >> U-Boot needs to add u-boot,dm-pre-reloc; property > > > > I'm not entirely sure what best practice rules are in this area, but > > shouldn't U-Boot locate the node by name instead of label ? > > Labels are not listed in dt binding and there are two approaches how to > reference nodes. Via full path with node name or via labels. > I do normally use labels which are much simple. Note that labels require the DTB to be compiled with the -@ option, otherwise they're not present in the binary. > And also if you take a look how dtb looks like (convert back to dts) you > can see that for example aliases are using full path (just &label) but > clocks/gic which is the part of <> is handled via phandles as numbers. > > And labels names can vary and shouldn't be the part of binding doc as > far as I know. But I can be wrong of course. The DT bindings should document the interface with the operating system, and if applicable, the boot loader. If the boot loader requires a particular label, then it becomes part of the ABI, and I think it should be documented in the bindings. -- Regards, Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: Michal Simek <michal.simek@xilinx.com> Cc: devicetree@vger.kernel.org, monstr@monstr.eu, Rajan Vaja <rajan.vaja@xilinx.com>, linux-kernel@vger.kernel.org, Krzysztof Kozlowski <krzk@kernel.org>, Rob Herring <robh+dt@kernel.org>, Manish Narani <manish.narani@xilinx.com>, git@xilinx.com, Kalyani Akula <kalyani.akula@xilinx.com>, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi Date: Tue, 8 Dec 2020 00:16:02 +0200 [thread overview] Message-ID: <X86poiQSzv5Uva1r@pendragon.ideasonboard.com> (raw) In-Reply-To: <99008851-6c12-3acc-6530-25af08429ff5@xilinx.com> Hi Michal, On Mon, Dec 07, 2020 at 10:39:25AM +0100, Michal Simek wrote: > On 06. 12. 20 23:46, Laurent Pinchart wrote: > > On Wed, Dec 02, 2020 at 03:06:05PM +0100, Michal Simek wrote: > >> Add label which is used by bootloader for adding bootloader specific flag. > >> > >> Signed-off-by: Michal Simek <michal.simek@xilinx.com> > >> --- > >> > >> U-Boot needs to add u-boot,dm-pre-reloc; property > > > > I'm not entirely sure what best practice rules are in this area, but > > shouldn't U-Boot locate the node by name instead of label ? > > Labels are not listed in dt binding and there are two approaches how to > reference nodes. Via full path with node name or via labels. > I do normally use labels which are much simple. Note that labels require the DTB to be compiled with the -@ option, otherwise they're not present in the binary. > And also if you take a look how dtb looks like (convert back to dts) you > can see that for example aliases are using full path (just &label) but > clocks/gic which is the part of <> is handled via phandles as numbers. > > And labels names can vary and shouldn't be the part of binding doc as > far as I know. But I can be wrong of course. The DT bindings should document the interface with the operating system, and if applicable, the boot loader. If the boot loader requires a particular label, then it becomes part of the ABI, and I think it should be documented in the bindings. -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-07 22:17 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-12-02 14:05 [PATCH 00/12] arm64: dts: zynqmp: DT updates to match latest drivers Michal Simek 2020-12-02 14:05 ` Michal Simek 2020-12-02 14:06 ` [PATCH 01/12] arm64: dts: zynqmp: Fix u48 si5382 chip on zcu111 Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 02/12] arm64: dts: zynqmp: Add DT description for si5328 for zcu102/zcu106 Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 03/12] arm64: dts: zynqmp: Enable si5341 driver for zcu102/106/111 Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 04/12] arm64: dts: zynqmp: Enable and wire reset controller Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-06 22:38 ` Laurent Pinchart 2020-12-06 22:38 ` Laurent Pinchart 2020-12-07 9:32 ` Michal Simek 2020-12-07 9:32 ` Michal Simek 2021-01-21 10:10 ` Michal Simek 2021-01-21 10:10 ` Michal Simek 2020-12-02 14:06 ` [PATCH 05/12] arm64: dts: zynqmp: Enable phy driver for Sata on zcu102/zcu104/zcu106 Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 06/12] arm64: dts: zynqmp: Add label for zynqmp_ipi Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-06 22:46 ` Laurent Pinchart 2020-12-06 22:46 ` Laurent Pinchart 2020-12-06 22:48 ` Laurent Pinchart 2020-12-06 22:48 ` Laurent Pinchart 2020-12-07 9:43 ` Michal Simek 2020-12-07 9:43 ` Michal Simek 2020-12-07 9:39 ` Michal Simek 2020-12-07 9:39 ` Michal Simek 2020-12-07 22:16 ` Laurent Pinchart [this message] 2020-12-07 22:16 ` Laurent Pinchart 2020-12-08 7:26 ` Michal Simek 2020-12-08 7:26 ` Michal Simek 2021-01-21 22:29 ` Laurent Pinchart 2021-01-21 22:29 ` Laurent Pinchart 2021-01-22 9:00 ` Michal Simek 2021-01-22 9:00 ` Michal Simek 2020-12-02 14:06 ` [PATCH 07/12] arm64: dts: zynqmp: Add missing mio-bank properties to sdhcis Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 08/12] arm64: dts: zynqmp: Wire arasan nand controller Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 09/12] arm64: dts: zynqmp: Wire zynqmp qspi controller Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 10/12] arm64: dts: zynqmp: Add missing lpd watchdog node Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 11/12] arm64: dts: zynqmp: Add missing iommu IDs Michal Simek 2020-12-02 14:06 ` Michal Simek 2020-12-02 14:06 ` [PATCH 12/12] arm64: dts: zynqmp: Add description for zcu104 revC Michal Simek 2020-12-02 14:06 ` Michal Simek
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=X86poiQSzv5Uva1r@pendragon.ideasonboard.com \ --to=laurent.pinchart@ideasonboard.com \ --cc=devicetree@vger.kernel.org \ --cc=git@xilinx.com \ --cc=kalyani.akula@xilinx.com \ --cc=krzk@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=manish.narani@xilinx.com \ --cc=michal.simek@xilinx.com \ --cc=monstr@monstr.eu \ --cc=rajan.vaja@xilinx.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.