From: Roman Bolshakov <r.bolshakov@yadro.com>
To: Peter Krempa <pkrempa@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Eduardo Habkost" <ehabkost@redhat.com>,
libvir-list@redhat.com,
"Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [PATCH for-6.0] accel: Wire accel to /machine
Date: Tue, 8 Dec 2020 11:13:07 +0300 [thread overview]
Message-ID: <X881k+IdAzs5O1yQ@SPB-NB-133.local> (raw)
In-Reply-To: <20201207175007.GO105758@angien.pipo.sk>
On Mon, Dec 07, 2020 at 06:50:07PM +0100, Peter Krempa wrote:
> On Mon, Dec 07, 2020 at 12:38:49 -0500, Eduardo Habkost wrote:
> > On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote:
> > > There's no generic way to query current accel and its properties via QOM
> > > because there's no link between an accel and current machine.
> > >
> > > The change adds the link, i.e. if HVF is enabled the following will be
> > > available in QOM:
> > >
> > > (qemu) qom-get /machine/accel type
> > > "hvf-accel"
> > >
> > > Suggested-by: Markus Armbruster <armbru@redhat.com>
> > > Suggested-by: Paolo Bonzini <pbonzini@redhat.com>
> > > Signed-off-by: Roman Bolshakov <r.bolshakov@yadro.com>
> > > ---
> > >
> > > Hi,
> > >
> > > this is a follow up patch that deprecates earlier series [1].
> > >
> >
> > Is there a reference to the reasoning for dropping the earlier
> > approach? Your previous approach seems preferable.
>
> The gist of the discussion before was that deprecating old commands in
> the same release cycle as introducing the replacement might be
> problematic if libvirt wants to adapt ASAP and that the new command
> should be elevated to a intermediate tier of stability, where ACK from
> libvirt is needed to change it during the same release cycle
> incompatibly.
>
> That was meant generally for any command, and was started because we had
> a similar issue recently.
>
> My intention definitely was not to change the patch itself, but more a
> process change so that we can keep cooperating on new stuff rapidly, but
> without actually breaking what we do.
>
Thanks Peter,
I'll drop deprecation patch in v2 of query-accel QMP command.
Ragards,
Roman
next prev parent reply other threads:[~2020-12-08 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-07 8:46 [PATCH for-6.0] accel: Wire accel to /machine Roman Bolshakov
2020-12-07 17:38 ` Eduardo Habkost
2020-12-07 17:50 ` Peter Krempa
2020-12-08 8:13 ` Roman Bolshakov [this message]
2020-12-08 8:19 ` Peter Krempa
2020-12-08 8:11 ` Roman Bolshakov
2020-12-07 17:44 ` Daniel P. Berrangé
2020-12-08 7:40 ` Roman Bolshakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=X881k+IdAzs5O1yQ@SPB-NB-133.local \
--to=r.bolshakov@yadro.com \
--cc=armbru@redhat.com \
--cc=cfontana@suse.de \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kwolf@redhat.com \
--cc=libvir-list@redhat.com \
--cc=pbonzini@redhat.com \
--cc=philmd@redhat.com \
--cc=pkrempa@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.