Re: [PATCH for-6.0] accel: Wire accel to /machine

From: Roman Bolshakov <r.bolshakov@yadro.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Krempa" <pkrempa@redhat.com>,
	Richard@redhat.com, "Eduardo Habkost" <ehabkost@redhat.com>,
	libvir-list@redhat.com,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>,
	Henderson <richard.henderson@linaro.org>,
	qemu-devel@nongnu.org,
	"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Fontana <cfontana@suse.de>,
	Markus@redhat.com, "Paolo Bonzini" <pbonzini@redhat.com>,
	Claudio@redhat.com
Subject: Re: [PATCH for-6.0] accel: Wire accel to /machine
Date: Tue, 8 Dec 2020 10:40:16 +0300	[thread overview]
Message-ID: <X88t4CKMyDfhvdyb@SPB-NB-133.local> (raw)
In-Reply-To: <20201207174419.GP3102898@redhat.com>

On Mon, Dec 07, 2020 at 05:44:19PM +0000, Daniel P. Berrangé wrote:
> On Mon, Dec 07, 2020 at 11:46:22AM +0300, Roman Bolshakov wrote:
> > An outstanding issue is whether management applications can rely on the
> > value of /machine/accel/type and output of qom-list-types command [2][3]
> > to get current and present accels?
> > 
> > i.e. would it be ok if libvirt assumes that everything up to the first
> > dash in the accel type is the name of the accel (as specified via -M
> > accel=ACCEL flag) when it performs QEMU probing?
> 
> Hmm, I think it is not nice - we shouldn't have to parse the
> accel type names - IMHO typenames should be considered arbitrary
> opaque strings, even if they'll not be expected to change.
> 

Thanks Daniel. I'll then send v2 of ad-hoc QMP/HMP query. By the way, do
we need the HMP query if we get accel in QOM?

Regards,
Roman