* [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"
@ 2020-12-09 15:42 Alex Deucher
2020-12-09 16:19 ` Greg KH
0 siblings, 1 reply; 5+ messages in thread
From: Alex Deucher @ 2020-12-09 15:42 UTC (permalink / raw)
To: stable; +Cc: Alex Deucher, Sasha Levin
This patch should not have been applied to stable. It depends
on changes in newer drivers.
This reverts commit 756fec062e4b823bbbe10b95cbcfa84f948131c6.
Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1402
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Cc: Sasha Levin <sashal@kernel.org>
Cc: stable@vger.kernel.org
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index 254ab2ada70a..c28ebf41530a 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -1220,7 +1220,8 @@ static int soc15_common_early_init(void *handle)
adev->pg_flags = AMD_PG_SUPPORT_SDMA |
AMD_PG_SUPPORT_MMHUB |
- AMD_PG_SUPPORT_VCN;
+ AMD_PG_SUPPORT_VCN |
+ AMD_PG_SUPPORT_VCN_DPG;
} else {
adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
AMD_CG_SUPPORT_GFX_MGLS |
--
2.25.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"
2020-12-09 15:42 [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso" Alex Deucher
@ 2020-12-09 16:19 ` Greg KH
0 siblings, 0 replies; 5+ messages in thread
From: Greg KH @ 2020-12-09 16:19 UTC (permalink / raw)
To: Alex Deucher; +Cc: stable, Alex Deucher, Sasha Levin
On Wed, Dec 09, 2020 at 10:42:22AM -0500, Alex Deucher wrote:
> This patch should not have been applied to stable. It depends
> on changes in newer drivers.
>
> This reverts commit 756fec062e4b823bbbe10b95cbcfa84f948131c6.
>
> Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1402
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> Cc: Sasha Levin <sashal@kernel.org>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 254ab2ada70a..c28ebf41530a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -1220,7 +1220,8 @@ static int soc15_common_early_init(void *handle)
>
> adev->pg_flags = AMD_PG_SUPPORT_SDMA |
> AMD_PG_SUPPORT_MMHUB |
> - AMD_PG_SUPPORT_VCN;
> + AMD_PG_SUPPORT_VCN |
> + AMD_PG_SUPPORT_VCN_DPG;
> } else {
> adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
> AMD_CG_SUPPORT_GFX_MGLS |
> --
> 2.25.4
>
Now queued up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"
2021-03-11 14:19 Alex Deucher
2021-03-29 17:41 ` Alex Deucher
@ 2021-03-31 2:20 ` Quan, Evan
1 sibling, 0 replies; 5+ messages in thread
From: Quan, Evan @ 2021-03-31 2:20 UTC (permalink / raw)
To: Deucher, Alexander, amd-gfx
Cc: Deucher, Alexander, Gopalakrishnan, Veerabadhran (Veera), Liu, Leo
[AMD Public Use]
Acked-by: Evan Quan <evan.quan@amd.com>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex
> Deucher
> Sent: Thursday, March 11, 2021 10:20 PM
> To: amd-gfx@lists.freedesktop.org
> Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Gopalakrishnan,
> Veerabadhran (Veera) <Veerabadhran.Gopalakrishnan@amd.com>; Liu, Leo
> <Leo.Liu@amd.com>
> Subject: [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"
>
> This reverts commit c6d2b0fbb893d5c7dda405aa0e7bcbecf1c75f98.
>
> This patch is a workaround for a hardware bug, but I don't know that we've
> actually seen the hw bug triggered in practice, meanwhile a number of
> people have reported that this causes suspend and resume issues.
>
> Bug:
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugz
> illa.kernel.org%2Fshow_bug.cgi%3Fid%3D211277&data=04%7C01%7Cev
> an.quan%40amd.com%7C106f649374b14dc3383108d8e498c485%7C3dd8961f
> e4884e608e11a82d994e183d%7C0%7C0%7C637510692088534999%7CUnknow
> n%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1ha
> WwiLCJXVCI6Mn0%3D%7C1000&sdata=yLxYzonL8VrQui3MrFzsgA2FIM
> mRYt3e40jtvNCtRRM%3D&reserved=0
> Cc: Veerabadhran Gopalakrishnan <veerabadhran.gopalakrishnan@amd.com>
> Cc: Leo Liu <leo.liu@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c
> b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 3808402cd964..1a0c3a816863 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -1405,7 +1405,8 @@ static int soc15_common_early_init(void *handle)
>
> adev->pg_flags = AMD_PG_SUPPORT_SDMA |
> AMD_PG_SUPPORT_MMHUB |
> - AMD_PG_SUPPORT_VCN;
> + AMD_PG_SUPPORT_VCN |
> + AMD_PG_SUPPORT_VCN_DPG;
> } else {
> adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
> AMD_CG_SUPPORT_GFX_MGLS |
> --
> 2.29.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.
> freedesktop.org%2Fmailman%2Flistinfo%2Famd-
> gfx&data=04%7C01%7Cevan.quan%40amd.com%7C106f649374b14dc33
> 83108d8e498c485%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C63
> 7510692088534999%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMD
> AiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=
> hG2dxaaaNNQEqgpKP5opDH3reYhZYKY%2B7q1n4aEPoqA%3D&reserve
> d=0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"
2021-03-11 14:19 Alex Deucher
@ 2021-03-29 17:41 ` Alex Deucher
2021-03-31 2:20 ` Quan, Evan
1 sibling, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2021-03-29 17:41 UTC (permalink / raw)
To: Alex Deucher; +Cc: Veerabadhran Gopalakrishnan, Leo Liu, amd-gfx list
Ping?
Alex
On Thu, Mar 11, 2021 at 9:20 AM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> This reverts commit c6d2b0fbb893d5c7dda405aa0e7bcbecf1c75f98.
>
> This patch is a workaround for a hardware bug, but I don't
> know that we've actually seen the hw bug triggered in practice,
> meanwhile a number of people have reported that this causes
> suspend and resume issues.
>
> Bug: https://bugzilla.kernel.org/show_bug.cgi?id=211277
> Cc: Veerabadhran Gopalakrishnan <veerabadhran.gopalakrishnan@amd.com>
> Cc: Leo Liu <leo.liu@amd.com>
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
> index 3808402cd964..1a0c3a816863 100644
> --- a/drivers/gpu/drm/amd/amdgpu/soc15.c
> +++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
> @@ -1405,7 +1405,8 @@ static int soc15_common_early_init(void *handle)
>
> adev->pg_flags = AMD_PG_SUPPORT_SDMA |
> AMD_PG_SUPPORT_MMHUB |
> - AMD_PG_SUPPORT_VCN;
> + AMD_PG_SUPPORT_VCN |
> + AMD_PG_SUPPORT_VCN_DPG;
> } else {
> adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
> AMD_CG_SUPPORT_GFX_MGLS |
> --
> 2.29.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso"
@ 2021-03-11 14:19 Alex Deucher
2021-03-29 17:41 ` Alex Deucher
2021-03-31 2:20 ` Quan, Evan
0 siblings, 2 replies; 5+ messages in thread
From: Alex Deucher @ 2021-03-11 14:19 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, Veerabadhran Gopalakrishnan, Leo Liu
This reverts commit c6d2b0fbb893d5c7dda405aa0e7bcbecf1c75f98.
This patch is a workaround for a hardware bug, but I don't
know that we've actually seen the hw bug triggered in practice,
meanwhile a number of people have reported that this causes
suspend and resume issues.
Bug: https://bugzilla.kernel.org/show_bug.cgi?id=211277
Cc: Veerabadhran Gopalakrishnan <veerabadhran.gopalakrishnan@amd.com>
Cc: Leo Liu <leo.liu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
drivers/gpu/drm/amd/amdgpu/soc15.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/soc15.c b/drivers/gpu/drm/amd/amdgpu/soc15.c
index 3808402cd964..1a0c3a816863 100644
--- a/drivers/gpu/drm/amd/amdgpu/soc15.c
+++ b/drivers/gpu/drm/amd/amdgpu/soc15.c
@@ -1405,7 +1405,8 @@ static int soc15_common_early_init(void *handle)
adev->pg_flags = AMD_PG_SUPPORT_SDMA |
AMD_PG_SUPPORT_MMHUB |
- AMD_PG_SUPPORT_VCN;
+ AMD_PG_SUPPORT_VCN |
+ AMD_PG_SUPPORT_VCN_DPG;
} else {
adev->cg_flags = AMD_CG_SUPPORT_GFX_MGCG |
AMD_CG_SUPPORT_GFX_MGLS |
--
2.29.2
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-03-31 2:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-09 15:42 [PATCH] Revert "amd/amdgpu: Disable VCN DPG mode for Picasso" Alex Deucher
2020-12-09 16:19 ` Greg KH
2021-03-11 14:19 Alex Deucher
2021-03-29 17:41 ` Alex Deucher
2021-03-31 2:20 ` Quan, Evan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.