All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bloomfield <ginge264@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
Date: Thu, 10 Dec 2020 10:28:12 +0100	[thread overview]
Message-ID: <X9HqLFwjHSPXqRgZ@kroah.com> (raw)
In-Reply-To: <20201210100657.22562-1-ginge264@gmail.com>

On Thu, Dec 10, 2020 at 10:06:57AM +0000, Chris Bloomfield wrote:
> Fix a coding style issue as identified by checkpatch.pl
> 
> Signed-off-by: Chris Bloomfield <ginge264@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 655df317d0ee..a6181a167814 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;
>  

With your knowledge of C, do you think the above change looks correct?

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <gregkh@linuxfoundation.org>
To: Chris Bloomfield <ginge264@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue
Date: Thu, 10 Dec 2020 10:28:12 +0100	[thread overview]
Message-ID: <X9HqLFwjHSPXqRgZ@kroah.com> (raw)
In-Reply-To: <20201210100657.22562-1-ginge264@gmail.com>

On Thu, Dec 10, 2020 at 10:06:57AM +0000, Chris Bloomfield wrote:
> Fix a coding style issue as identified by checkpatch.pl
> 
> Signed-off-by: Chris Bloomfield <ginge264@gmail.com>
> ---
>  drivers/staging/ralink-gdma/ralink-gdma.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/ralink-gdma/ralink-gdma.c b/drivers/staging/ralink-gdma/ralink-gdma.c
> index 655df317d0ee..a6181a167814 100644
> --- a/drivers/staging/ralink-gdma/ralink-gdma.c
> +++ b/drivers/staging/ralink-gdma/ralink-gdma.c
> @@ -122,6 +122,7 @@ struct gdma_dma_dev {
>  	struct gdma_data *data;
>  	void __iomem *base;
>  	struct tasklet_struct task;
> +
>  	volatile unsigned long chan_issued;
>  	atomic_t cnt;
>  

With your knowledge of C, do you think the above change looks correct?

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel

  reply	other threads:[~2020-12-10  9:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-10 10:06 [PATCH] Staging: ralink-gdma: ralink-gdma: Fix a blank line coding style issue Chris Bloomfield
2020-12-10 10:06 ` Chris Bloomfield
2020-12-10  9:28 ` Greg KH [this message]
2020-12-10  9:28   ` Greg KH
  -- strict thread matches above, loose matches on Subject: below --
2020-12-10  1:32 Triplehx3
2020-12-10  1:32 ` Triplehx3
2020-12-10  7:57 ` Greg KH
2020-12-10  7:57   ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=X9HqLFwjHSPXqRgZ@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=ginge264@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.