* [PATCH net] qlcnic: Fix error code in probe
@ 2020-12-16 8:38 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-12-16 8:38 UTC (permalink / raw)
To: Shahed Shaikh, Sony Chacko
Cc: Manish Chopra, GR-Linux-NIC-Dev, David S. Miller, Jakub Kicinski,
Sucheta Chakraborty, Sritej Velaga, netdev, kernel-janitors
Return -EINVAL if we can't find the correct device. Currently it
returns success.
Fixes: 13159183ec7a ("qlcnic: 83xx base driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 5a7e240fd469..c2faf96fcade 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2492,6 +2492,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
qlcnic_sriov_vf_register_map(ahw);
break;
default:
+ err = -EINVAL;
goto err_out_free_hw_res;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH net] qlcnic: Fix error code in probe
@ 2020-12-16 8:38 ` Dan Carpenter
0 siblings, 0 replies; 3+ messages in thread
From: Dan Carpenter @ 2020-12-16 8:38 UTC (permalink / raw)
To: Shahed Shaikh, Sony Chacko
Cc: Manish Chopra, GR-Linux-NIC-Dev, David S. Miller, Jakub Kicinski,
Sucheta Chakraborty, Sritej Velaga, netdev, kernel-janitors
Return -EINVAL if we can't find the correct device. Currently it
returns success.
Fixes: 13159183ec7a ("qlcnic: 83xx base driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
index 5a7e240fd469..c2faf96fcade 100644
--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c
@@ -2492,6 +2492,7 @@ qlcnic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
qlcnic_sriov_vf_register_map(ahw);
break;
default:
+ err = -EINVAL;
goto err_out_free_hw_res;
}
--
2.29.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH net] qlcnic: Fix error code in probe
2020-12-16 8:38 ` Dan Carpenter
(?)
@ 2020-12-17 19:00 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2020-12-17 19:00 UTC (permalink / raw)
To: Dan Carpenter
Cc: shshaikh, sony.chacko, manishc, GR-Linux-NIC-Dev, davem, kuba,
sucheta.chakraborty, sritej.velaga, netdev, kernel-janitors
Hello:
This patch was applied to netdev/net.git (refs/heads/master):
On Wed, 16 Dec 2020 11:38:04 +0300 you wrote:
> Return -EINVAL if we can't find the correct device. Currently it
> returns success.
>
> Fixes: 13159183ec7a ("qlcnic: 83xx base driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_main.c | 1 +
> 1 file changed, 1 insertion(+)
Here is the summary with links:
- [net] qlcnic: Fix error code in probe
https://git.kernel.org/netdev/net/c/0d52848632a3
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-17 19:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-16 8:38 [PATCH net] qlcnic: Fix error code in probe Dan Carpenter
2020-12-16 8:38 ` Dan Carpenter
2020-12-17 19:00 ` patchwork-bot+netdevbpf
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.