* [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode
@ 2014-11-17 18:53 Yann E. MORIN
2014-11-17 19:09 ` Yann E. MORIN
2014-11-17 19:10 ` Bernd Kuhls
0 siblings, 2 replies; 4+ messages in thread
From: Yann E. MORIN @ 2014-11-17 18:53 UTC (permalink / raw)
To: buildroot
When in debug mode, ./configure forces -Werror, which uncovers a
constness issue in the speex decoder.
Add a patch to fix this.
Fixes:
http://autobuild.buildroot.net/results/6f5/6f5e1b782923d6e69e929466f0ddd3eeba28c6f1/
http://autobuild.buildroot.net/results/c1b/c1b31dc37fe62cb6901edad02bf50d73072b7cf0/
http://autobuild.buildroot.net/results/162/162e6d77e5812060001ea22faff99055aae3122a/
...
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
---
package/sdl_sound/0001-fix-constness.patch | 16 ++++++++++++++++
package/sdl_sound/sdl_sound.mk | 3 +++
2 files changed, 19 insertions(+)
create mode 100644 package/sdl_sound/0001-fix-constness.patch
diff --git a/package/sdl_sound/0001-fix-constness.patch b/package/sdl_sound/0001-fix-constness.patch
new file mode 100644
index 0000000..1f27a07
--- /dev/null
+++ b/package/sdl_sound/0001-fix-constness.patch
@@ -0,0 +1,16 @@
+decoders/speex: fix constness of speex mode
+
+Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
+
+diff -durN sdl_sound-1.0.3.orig/decoders/speex.c sdl_sound-1.0.3/decoders/speex.c
+--- sdl_sound-1.0.3.orig/decoders/speex.c 2014-11-17 19:40:09.543553556 +0100
++++ sdl_sound-1.0.3/decoders/speex.c 2014-11-17 19:40:37.119864580 +0100
+@@ -124,7 +124,7 @@
+
+ static int process_header(speex_t *speex, Sound_Sample *sample)
+ {
+- SpeexMode *mode;
++ const SpeexMode * mode;
+ SpeexHeader *hptr;
+ SpeexHeader header;
+ int enh_enabled = SPEEX_USE_PERCEPTUAL_ENHANCER;
diff --git a/package/sdl_sound/sdl_sound.mk b/package/sdl_sound/sdl_sound.mk
index 416f381..6180b42 100644
--- a/package/sdl_sound/sdl_sound.mk
+++ b/package/sdl_sound/sdl_sound.mk
@@ -12,6 +12,9 @@ SDL_SOUND_LICENSE_FILES = COPYING
SDL_SOUND_INSTALL_STAGING = YES
SDL_SOUND_DEPENDENCIES = sdl
+# Patch touching configure.in
+SDL_SOUND_AUTORECONF = YES
+
ifneq ($(BR2_ENABLE_LOCALE),y)
SDL_SOUND_DEPENDENCIES += libiconv
endif
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode
2014-11-17 18:53 [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode Yann E. MORIN
@ 2014-11-17 19:09 ` Yann E. MORIN
2014-11-17 19:10 ` Bernd Kuhls
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2014-11-17 19:09 UTC (permalink / raw)
To: buildroot
All,
On 2014-11-17 19:53 +0100, Yann E. MORIN spake thusly:
> When in debug mode, ./configure forces -Werror, which uncovers a
> constness issue in the speex decoder.
>
> Add a patch to fix this.
Patch was submitted upstream, but is help in moderation because I am not
subscribed to their mailing list. As soon as I have an answer, I'll post
it here (at least a pointer to the thread).
Regards,
Yann E. MORIN.
> Fixes:
> http://autobuild.buildroot.net/results/6f5/6f5e1b782923d6e69e929466f0ddd3eeba28c6f1/
> http://autobuild.buildroot.net/results/c1b/c1b31dc37fe62cb6901edad02bf50d73072b7cf0/
> http://autobuild.buildroot.net/results/162/162e6d77e5812060001ea22faff99055aae3122a/
> ...
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Bernd Kuhls <bernd.kuhls@t-online.de>
> Cc: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> ---
> package/sdl_sound/0001-fix-constness.patch | 16 ++++++++++++++++
> package/sdl_sound/sdl_sound.mk | 3 +++
> 2 files changed, 19 insertions(+)
> create mode 100644 package/sdl_sound/0001-fix-constness.patch
>
> diff --git a/package/sdl_sound/0001-fix-constness.patch b/package/sdl_sound/0001-fix-constness.patch
> new file mode 100644
> index 0000000..1f27a07
> --- /dev/null
> +++ b/package/sdl_sound/0001-fix-constness.patch
> @@ -0,0 +1,16 @@
> +decoders/speex: fix constness of speex mode
> +
> +Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> +
> +diff -durN sdl_sound-1.0.3.orig/decoders/speex.c sdl_sound-1.0.3/decoders/speex.c
> +--- sdl_sound-1.0.3.orig/decoders/speex.c 2014-11-17 19:40:09.543553556 +0100
> ++++ sdl_sound-1.0.3/decoders/speex.c 2014-11-17 19:40:37.119864580 +0100
> +@@ -124,7 +124,7 @@
> +
> + static int process_header(speex_t *speex, Sound_Sample *sample)
> + {
> +- SpeexMode *mode;
> ++ const SpeexMode * mode;
> + SpeexHeader *hptr;
> + SpeexHeader header;
> + int enh_enabled = SPEEX_USE_PERCEPTUAL_ENHANCER;
> diff --git a/package/sdl_sound/sdl_sound.mk b/package/sdl_sound/sdl_sound.mk
> index 416f381..6180b42 100644
> --- a/package/sdl_sound/sdl_sound.mk
> +++ b/package/sdl_sound/sdl_sound.mk
> @@ -12,6 +12,9 @@ SDL_SOUND_LICENSE_FILES = COPYING
> SDL_SOUND_INSTALL_STAGING = YES
> SDL_SOUND_DEPENDENCIES = sdl
>
> +# Patch touching configure.in
> +SDL_SOUND_AUTORECONF = YES
> +
> ifneq ($(BR2_ENABLE_LOCALE),y)
> SDL_SOUND_DEPENDENCIES += libiconv
> endif
> --
> 1.9.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode
2014-11-17 18:53 [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode Yann E. MORIN
2014-11-17 19:09 ` Yann E. MORIN
@ 2014-11-17 19:10 ` Bernd Kuhls
2014-11-17 20:35 ` Yann E. MORIN
1 sibling, 1 reply; 4+ messages in thread
From: Bernd Kuhls @ 2014-11-17 19:10 UTC (permalink / raw)
To: buildroot
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote in
news:1416250380-24029-1-git-send-email-yann.morin.1998 at free.fr:
> +# Patch touching configure.in
> +SDL_SOUND_AUTORECONF = YES
> +
Hi,
I think this part of the patch is not necessary anymore ;)
Regards, Bernd
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode
2014-11-17 19:10 ` Bernd Kuhls
@ 2014-11-17 20:35 ` Yann E. MORIN
0 siblings, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2014-11-17 20:35 UTC (permalink / raw)
To: buildroot
Bernd, All,
On 2014-11-17 20:10 +0100, Bernd Kuhls spake thusly:
> "Yann E. MORIN" <yann.morin.1998@free.fr> wrote in
> news:1416250380-24029-1-git-send-email-yann.morin.1998 at free.fr:
>
> > +# Patch touching configure.in
> > +SDL_SOUND_AUTORECONF = YES
>
> I think this part of the patch is not necessary anymore ;)
Damn, yes. Will resend. Thanks.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 223 225 172 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-11-17 20:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-17 18:53 [Buildroot] [PATCHv2] package/sdl_sound: fix constness in debug mode Yann E. MORIN
2014-11-17 19:09 ` Yann E. MORIN
2014-11-17 19:10 ` Bernd Kuhls
2014-11-17 20:35 ` Yann E. MORIN
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.