[Buildroot] [PATCH 1/2] package/kodi: Add suboption to control MySQL support

[Buildroot] [PATCH 1/2] package/kodi: Add suboption to control MySQL support

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi/Config.in | 6 ++++++
 package/kodi/kodi.mk   | 2 +-
 2 files changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index a44ef5a..281de24 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -173,6 +173,12 @@ config BR2_PACKAGE_KODI_LIBNFS
 comment "nfs support needs a toolchain w/ threads support"
 	depends on !(BR2_TOOLCHAIN_HAS_THREADS || BR2_TOOLCHAIN_HAS_NATIVE_RPC)
 
+config BR2_PACKAGE_KODI_MYSQL
+	bool "mysql"
+	select BR2_PACKAGE_MYSQL
+	help
+	  Enable MySQL support
+
 config BR2_PACKAGE_KODI_RTMPDUMP
 	bool "rtmp"
 	select BR2_PACKAGE_RTMPDUMP
diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index e163c24..17d20a9 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -37,7 +37,7 @@ KODI_CONF_OPTS +=  \
 	--disable-vtbdecoder \
 	--enable-optimizations
 
-ifeq ($(BR2_PACKAGE_MYSQL),y)
+ifeq ($(BR2_PACKAGE_KODI_MYSQL),y)
 KODI_CONF_OPTS += --enable-mysql
 KODI_CONF_ENV += ac_cv_path_MYSQL_CONFIG="$(STAGING_DIR)/usr/bin/mysql_config"
 KODI_DEPENDENCIES += mysql
-- 
2.8.1

[Buildroot] [PATCH 2/2] package/kodi: Add suboption to control UPnP support

[Bernd Kuhls]

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
 package/kodi/Config.in | 5 +++++
 package/kodi/kodi.mk   | 6 ++++++
 2 files changed, 11 insertions(+)

diff --git a/package/kodi/Config.in b/package/kodi/Config.in
index 281de24..984f7bb 100644
--- a/package/kodi/Config.in
+++ b/package/kodi/Config.in
@@ -232,6 +232,11 @@ config BR2_PACKAGE_KODI_LIBVA
 	help
 	  Enable libva support.
 
+config BR2_PACKAGE_KODI_UPNP
+	bool "upnp"
+	help
+	  Enable UPnP support
+
 config BR2_PACKAGE_KODI_OPTICALDRIVE
 	bool
 
diff --git a/package/kodi/kodi.mk b/package/kodi/kodi.mk
index 17d20a9..c72c5d1 100644
--- a/package/kodi/kodi.mk
+++ b/package/kodi/kodi.mk
@@ -187,6 +187,12 @@ else
 KODI_CONF_OPTS += --disable-vaapi
 endif
 
+ifeq ($(BR2_PACKAGE_KODI_UPNP),y)
+KODI_CONF_OPTS += --enable-upnp
+else
+KODI_CONF_OPTS += --disable-upnp
+endif
+
 ifeq ($(BR2_PACKAGE_KODI_OPTICALDRIVE),y)
 KODI_CONF_OPTS += --enable-optical-drive --enable-dvdcss
 else
-- 
2.8.1

[Buildroot] [PATCH 1/2] package/kodi: Add suboption to control MySQL support

[Thomas Petazzoni]

Hello,

On Tue, 14 Jun 2016 23:00:27 +0200, Bernd Kuhls wrote:
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
>  package/kodi/Config.in | 6 ++++++
>  package/kodi/kodi.mk   | 2 +-
>  2 files changed, 7 insertions(+), 1 deletion(-)

What is the motivation for switching from an "automatic" enabling to an
explicit sub-option ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[Buildroot] [PATCH 1/2] package/kodi: Add suboption to control MySQL support

[Bernd Kuhls]

[posted and mailed]

Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote
in news:20160615150946.7bef4659 at free-electrons.com: 

> Hello,
> 
> On Tue, 14 Jun 2016 23:00:27 +0200, Bernd Kuhls wrote:
>> Signed-off-by: Bernd Kuhls
>> <bernd.kuhls@t-online.de> ---
>>  package/kodi/Config.in | 6 ++++++
>>  package/kodi/kodi.mk   | 2 +-
>>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> What is the motivation for switching from an "automatic" enabling to an
> explicit sub-option ?

Hi Thomas,

in a buildroot defconfig with mysql enabled I would like to be able to
build Kodi without mysql support because I do not need it during runtime. 

Kodi can store its internal databases not only localy using sqlite but also 
on a mysql server, this allows several local Kodi machines to use the same 
databases. Because I do only use one Kodi instance I do not need mysql 
support and would like to reduce build time when testing/installing Kodi 
while not touching other packages.

Regards, Bernd