* [PATCH v2 0/2] Some debugfs refactoring and improvements
@ 2023-03-01 11:02 ` Andi Shyti
0 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 11:02 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Tvrtko Ursulin, Andi Shyti, Maciej Patelczyk, Andi Shyti,
Michal Wajdeczko
Hi,
These two patches aim to enhance the multi-GT capabilities of the
debugfs.
The first patch reorganizes the file structure, while the second
patch extends the functionality of the original files in the
upper directories to operate on all tiles with a single write,
providing an or'ed value among them in the read case.
Andi
Changelog
=========
v1 -> v2
- add patch 2 for multiplexing
- improve commit log in patch 1.
Andi Shyti (2):
drm/i915/gt: Create per-tile debugfs files
drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +-
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++-
drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 +
drivers/gpu/drm/i915/i915_debugfs.c | 38 +++++++++++++++++--
5 files changed, 45 insertions(+), 6 deletions(-)
--
2.39.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH v2 0/2] Some debugfs refactoring and improvements
@ 2023-03-01 11:02 ` Andi Shyti
0 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 11:02 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Maciej Patelczyk
Hi,
These two patches aim to enhance the multi-GT capabilities of the
debugfs.
The first patch reorganizes the file structure, while the second
patch extends the functionality of the original files in the
upper directories to operate on all tiles with a single write,
providing an or'ed value among them in the read case.
Andi
Changelog
=========
v1 -> v2
- add patch 2 for multiplexing
- improve commit log in patch 1.
Andi Shyti (2):
drm/i915/gt: Create per-tile debugfs files
drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +-
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 +
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++-
drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 +
drivers/gpu/drm/i915/i915_debugfs.c | 38 +++++++++++++++++--
5 files changed, 45 insertions(+), 6 deletions(-)
--
2.39.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
@ 2023-03-01 11:02 ` Andi Shyti
-1 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 11:02 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Tvrtko Ursulin, Andi Shyti, Maciej Patelczyk, Andi Shyti,
Michal Wajdeczko
To support multi-GT configurations, we need to generate
independent debug files for each GT.
To achieve this create a separate directory for each GT under the
debugfs directory. For instance, in a system with two tiles, the
debugfs structure would look like this:
/sys/kernel/debug/dri
└── 0
├── gt0
│ ├── drpc
│ ├── engines
│ ├── forcewake
│ ├── frequency
│ └── rps_boost
└── gt1
: ├── drpc
: ├── engines
: ├── forcewake
├── frequency
└── rps_boost
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
4 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
index 5fc2df01aa0df..4dc23b8d3aa2d 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
@@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt, struct dentry *root)
void intel_gt_debugfs_register(struct intel_gt *gt)
{
struct dentry *root;
+ char gtname[4];
if (!gt->i915->drm.primary->debugfs_root)
return;
- root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
+ snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
+ root = debugfs_create_dir(gtname, gt->i915->drm.primary->debugfs_root);
if (IS_ERR(root))
return;
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
index bb4dfe707a7d0..e46aac1a41e6d 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
@@ -42,6 +42,8 @@ struct intel_guc {
/** @capture: the error-state-capture module's data and objects */
struct intel_guc_state_capture *capture;
+ struct dentry *dbgfs_node;
+
/** @sched_engine: Global engine used to submit requests to GuC */
struct i915_sched_engine *sched_engine;
/**
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 195db8c9d4200..55bc8b55fbc05 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log *log)
*/
n_subbufs = 8;
+ if (!guc->dbgfs_node)
+ return -ENOENT;
+
guc_log_relay_chan = relay_open("guc_log",
- i915->drm.primary->debugfs_root,
+ guc->dbgfs_node,
subbuf_size, n_subbufs,
&relay_callbacks, i915);
if (!guc_log_relay_chan) {
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
index 284d6fbc2d08c..2f93cc4e408a8 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
@@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct dentry *gt_root)
if (IS_ERR(root))
return;
+ uc->guc.dbgfs_node = root;
+
intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
intel_guc_debugfs_register(&uc->guc, root);
--
2.39.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
@ 2023-03-01 11:02 ` Andi Shyti
0 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 11:02 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Maciej Patelczyk
To support multi-GT configurations, we need to generate
independent debug files for each GT.
To achieve this create a separate directory for each GT under the
debugfs directory. For instance, in a system with two tiles, the
debugfs structure would look like this:
/sys/kernel/debug/dri
└── 0
├── gt0
│ ├── drpc
│ ├── engines
│ ├── forcewake
│ ├── frequency
│ └── rps_boost
└── gt1
: ├── drpc
: ├── engines
: ├── forcewake
├── frequency
└── rps_boost
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
---
drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
4 files changed, 11 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
index 5fc2df01aa0df..4dc23b8d3aa2d 100644
--- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
@@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt, struct dentry *root)
void intel_gt_debugfs_register(struct intel_gt *gt)
{
struct dentry *root;
+ char gtname[4];
if (!gt->i915->drm.primary->debugfs_root)
return;
- root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
+ snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
+ root = debugfs_create_dir(gtname, gt->i915->drm.primary->debugfs_root);
if (IS_ERR(root))
return;
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
index bb4dfe707a7d0..e46aac1a41e6d 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
@@ -42,6 +42,8 @@ struct intel_guc {
/** @capture: the error-state-capture module's data and objects */
struct intel_guc_state_capture *capture;
+ struct dentry *dbgfs_node;
+
/** @sched_engine: Global engine used to submit requests to GuC */
struct i915_sched_engine *sched_engine;
/**
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
index 195db8c9d4200..55bc8b55fbc05 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
@@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log *log)
*/
n_subbufs = 8;
+ if (!guc->dbgfs_node)
+ return -ENOENT;
+
guc_log_relay_chan = relay_open("guc_log",
- i915->drm.primary->debugfs_root,
+ guc->dbgfs_node,
subbuf_size, n_subbufs,
&relay_callbacks, i915);
if (!guc_log_relay_chan) {
diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
index 284d6fbc2d08c..2f93cc4e408a8 100644
--- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
+++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
@@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct dentry *gt_root)
if (IS_ERR(root))
return;
+ uc->guc.dbgfs_node = root;
+
intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
intel_guc_debugfs_register(&uc->guc, root);
--
2.39.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [PATCH v2 2/2] drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
@ 2023-03-01 11:02 ` Andi Shyti
-1 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 11:02 UTC (permalink / raw)
To: intel-gfx, dri-devel
Cc: Tvrtko Ursulin, Andi Shyti, Maciej Patelczyk, Andi Shyti,
Michal Wajdeczko
The commit 82a149a62b6b5 ('drm/i915/gt: move remaining debugfs
interfaces into gt') moved gt-related debugfs files in the gtX/
directories to operate on individual gt's.
However, the original files were only functioning on the root
tile (tile 0) and have been left in the same location to maintain
compatibility with userspace users.
Add multiplexing functionality to the higher directories' files.
This enables the operations to be performed on all the tiles with
a single write. In the case of reads, the files provide an or'ed
value across all the tiles.
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 38 ++++++++++++++++++++++++++---
1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 45773ce1deac2..90663f251fd10 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -575,14 +575,36 @@ static int i915_wa_registers(struct seq_file *m, void *unused)
static int i915_wedged_get(void *data, u64 *val)
{
struct drm_i915_private *i915 = data;
+ struct intel_gt *gt;
+ unsigned int i;
- return intel_gt_debugfs_reset_show(to_gt(i915), val);
+ *val = 0;
+
+ for_each_gt(gt, i915, i) {
+ int ret;
+ u64 v;
+
+ ret = intel_gt_debugfs_reset_show(gt, &v);
+ if (ret)
+ return ret;
+
+ /* at least one tile should be wedged */
+ *val |= !!v;
+ if (*val)
+ break;
+ }
+
+ return 0;
}
static int i915_wedged_set(void *data, u64 val)
{
struct drm_i915_private *i915 = data;
- intel_gt_debugfs_reset_store(to_gt(i915), val);
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_debugfs_reset_store(gt, val);
return 0;
}
@@ -733,7 +755,11 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
static int i915_forcewake_open(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- intel_gt_pm_debugfs_forcewake_user_open(to_gt(i915));
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_pm_debugfs_forcewake_user_open(gt);
return 0;
}
@@ -741,7 +767,11 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
static int i915_forcewake_release(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- intel_gt_pm_debugfs_forcewake_user_release(to_gt(i915));
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_pm_debugfs_forcewake_user_release(gt);
return 0;
}
--
2.39.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Intel-gfx] [PATCH v2 2/2] drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
@ 2023-03-01 11:02 ` Andi Shyti
0 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 11:02 UTC (permalink / raw)
To: intel-gfx, dri-devel; +Cc: Maciej Patelczyk
The commit 82a149a62b6b5 ('drm/i915/gt: move remaining debugfs
interfaces into gt') moved gt-related debugfs files in the gtX/
directories to operate on individual gt's.
However, the original files were only functioning on the root
tile (tile 0) and have been left in the same location to maintain
compatibility with userspace users.
Add multiplexing functionality to the higher directories' files.
This enables the operations to be performed on all the tiles with
a single write. In the case of reads, the files provide an or'ed
value across all the tiles.
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
---
drivers/gpu/drm/i915/i915_debugfs.c | 38 ++++++++++++++++++++++++++---
1 file changed, 34 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
index 45773ce1deac2..90663f251fd10 100644
--- a/drivers/gpu/drm/i915/i915_debugfs.c
+++ b/drivers/gpu/drm/i915/i915_debugfs.c
@@ -575,14 +575,36 @@ static int i915_wa_registers(struct seq_file *m, void *unused)
static int i915_wedged_get(void *data, u64 *val)
{
struct drm_i915_private *i915 = data;
+ struct intel_gt *gt;
+ unsigned int i;
- return intel_gt_debugfs_reset_show(to_gt(i915), val);
+ *val = 0;
+
+ for_each_gt(gt, i915, i) {
+ int ret;
+ u64 v;
+
+ ret = intel_gt_debugfs_reset_show(gt, &v);
+ if (ret)
+ return ret;
+
+ /* at least one tile should be wedged */
+ *val |= !!v;
+ if (*val)
+ break;
+ }
+
+ return 0;
}
static int i915_wedged_set(void *data, u64 val)
{
struct drm_i915_private *i915 = data;
- intel_gt_debugfs_reset_store(to_gt(i915), val);
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_debugfs_reset_store(gt, val);
return 0;
}
@@ -733,7 +755,11 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
static int i915_forcewake_open(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- intel_gt_pm_debugfs_forcewake_user_open(to_gt(i915));
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_pm_debugfs_forcewake_user_open(gt);
return 0;
}
@@ -741,7 +767,11 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
static int i915_forcewake_release(struct inode *inode, struct file *file)
{
struct drm_i915_private *i915 = inode->i_private;
- intel_gt_pm_debugfs_forcewake_user_release(to_gt(i915));
+ struct intel_gt *gt;
+ unsigned int i;
+
+ for_each_gt(gt, i915, i)
+ intel_gt_pm_debugfs_forcewake_user_release(gt);
return 0;
}
--
2.39.1
^ permalink raw reply related [flat|nested] 21+ messages in thread
* [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Some debugfs refactoring and improvements
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
` (2 preceding siblings ...)
(?)
@ 2023-03-01 18:57 ` Patchwork
-1 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2023-03-01 18:57 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
== Series Details ==
Series: Some debugfs refactoring and improvements
URL : https://patchwork.freedesktop.org/series/114510/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for Some debugfs refactoring and improvements
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
` (3 preceding siblings ...)
(?)
@ 2023-03-01 19:22 ` Patchwork
-1 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2023-03-01 19:22 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 8158 bytes --]
== Series Details ==
Series: Some debugfs refactoring and improvements
URL : https://patchwork.freedesktop.org/series/114510/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12799 -> Patchwork_114510v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/index.html
Participating hosts (40 -> 39)
------------------------------
Missing (1): fi-snb-2520m
Known issues
------------
Here are the changes found in Patchwork_114510v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@i915_selftest@live@gt_heartbeat:
- fi-apl-guc: [PASS][1] -> [DMESG-FAIL][2] ([i915#5334])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
* igt@i915_selftest@live@gt_pm:
- bat-adln-1: [PASS][3] -> [DMESG-FAIL][4] ([i915#4258])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-adln-1/igt@i915_selftest@live@gt_pm.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-adln-1/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@guc:
- bat-rpls-2: [PASS][5] -> [DMESG-WARN][6] ([i915#7852])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-rpls-2/igt@i915_selftest@live@guc.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-rpls-2/igt@i915_selftest@live@guc.html
* igt@i915_selftest@live@requests:
- bat-rpls-1: [PASS][7] -> [ABORT][8] ([i915#7694] / [i915#7911] / [i915#7982])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-rpls-1/igt@i915_selftest@live@requests.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-rpls-1/igt@i915_selftest@live@requests.html
#### Possible fixes ####
* igt@i915_pm_rps@basic-api:
- bat-rpls-2: [SKIP][9] ([i915#6621]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-rpls-2/igt@i915_pm_rps@basic-api.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-rpls-2/igt@i915_pm_rps@basic-api.html
- bat-dg1-6: [SKIP][11] ([i915#6621]) -> [PASS][12]
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-dg1-6/igt@i915_pm_rps@basic-api.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-dg1-6/igt@i915_pm_rps@basic-api.html
- bat-adlp-6: [SKIP][13] ([i915#6621]) -> [PASS][14]
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-adlp-6/igt@i915_pm_rps@basic-api.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-adlp-6/igt@i915_pm_rps@basic-api.html
- bat-atsm-1: [SKIP][15] ([i915#6621]) -> [PASS][16]
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-atsm-1/igt@i915_pm_rps@basic-api.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-atsm-1/igt@i915_pm_rps@basic-api.html
- bat-dg2-11: [SKIP][17] ([i915#6621]) -> [PASS][18]
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-dg2-11/igt@i915_pm_rps@basic-api.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-dg2-11/igt@i915_pm_rps@basic-api.html
- bat-dg2-8: [SKIP][19] ([i915#6621]) -> [PASS][20]
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-dg2-8/igt@i915_pm_rps@basic-api.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-dg2-8/igt@i915_pm_rps@basic-api.html
- bat-adlm-1: [SKIP][21] ([i915#6621]) -> [PASS][22]
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-adlm-1/igt@i915_pm_rps@basic-api.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-adlm-1/igt@i915_pm_rps@basic-api.html
- bat-rpls-1: [SKIP][23] ([i915#6621]) -> [PASS][24]
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-rpls-1/igt@i915_pm_rps@basic-api.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-rpls-1/igt@i915_pm_rps@basic-api.html
- bat-dg1-7: [SKIP][25] ([i915#6621]) -> [PASS][26]
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-dg1-7/igt@i915_pm_rps@basic-api.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-dg1-7/igt@i915_pm_rps@basic-api.html
- bat-adlp-9: [SKIP][27] ([i915#6621]) -> [PASS][28]
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-adlp-9/igt@i915_pm_rps@basic-api.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-adlp-9/igt@i915_pm_rps@basic-api.html
- bat-rplp-1: [SKIP][29] ([i915#6621]) -> [PASS][30]
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-rplp-1/igt@i915_pm_rps@basic-api.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-rplp-1/igt@i915_pm_rps@basic-api.html
- bat-dg1-5: [SKIP][31] ([i915#6621]) -> [PASS][32]
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-dg1-5/igt@i915_pm_rps@basic-api.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-dg1-5/igt@i915_pm_rps@basic-api.html
- bat-dg2-9: [SKIP][33] ([i915#6621]) -> [PASS][34]
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-dg2-9/igt@i915_pm_rps@basic-api.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-dg2-9/igt@i915_pm_rps@basic-api.html
- bat-adln-1: [SKIP][35] ([i915#6621]) -> [PASS][36]
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-adln-1/igt@i915_pm_rps@basic-api.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-adln-1/igt@i915_pm_rps@basic-api.html
* igt@i915_selftest@live@migrate:
- bat-atsm-1: [DMESG-FAIL][37] ([i915#7699]) -> [PASS][38]
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-atsm-1/igt@i915_selftest@live@migrate.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-atsm-1/igt@i915_selftest@live@migrate.html
#### Warnings ####
* igt@i915_selftest@live@slpc:
- bat-rpls-2: [DMESG-FAIL][39] ([i915#6997] / [i915#7913]) -> [DMESG-FAIL][40] ([i915#6367] / [i915#7913])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/bat-rpls-2/igt@i915_selftest@live@slpc.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/bat-rpls-2/igt@i915_selftest@live@slpc.html
[i915#4258]: https://gitlab.freedesktop.org/drm/intel/issues/4258
[i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
[i915#6367]: https://gitlab.freedesktop.org/drm/intel/issues/6367
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6997]: https://gitlab.freedesktop.org/drm/intel/issues/6997
[i915#7694]: https://gitlab.freedesktop.org/drm/intel/issues/7694
[i915#7699]: https://gitlab.freedesktop.org/drm/intel/issues/7699
[i915#7852]: https://gitlab.freedesktop.org/drm/intel/issues/7852
[i915#7911]: https://gitlab.freedesktop.org/drm/intel/issues/7911
[i915#7913]: https://gitlab.freedesktop.org/drm/intel/issues/7913
[i915#7982]: https://gitlab.freedesktop.org/drm/intel/issues/7982
Build changes
-------------
* Linux: CI_DRM_12799 -> Patchwork_114510v1
CI-20190529: 20190529
CI_DRM_12799: 5f6631c00a7f226c990aecc643bc9fa70da1599a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7178: ffe3f6670b91ab975f90799ab3fd0941b6eae019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114510v1: 5f6631c00a7f226c990aecc643bc9fa70da1599a @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
e3a0d848e6f3 drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
fc19d7881d23 drm/i915/gt: Create per-tile debugfs files
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/index.html
[-- Attachment #2: Type: text/html, Size: 10011 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
@ 2023-03-01 21:32 ` Sripada, Radhakrishna
-1 siblings, 0 replies; 21+ messages in thread
From: Sripada, Radhakrishna @ 2023-03-01 21:32 UTC (permalink / raw)
To: Andi Shyti, intel-gfx, dri-devel
Cc: Tvrtko Ursulin, Patelczyk, Maciej, Andi Shyti, Wajdeczko, Michal
> -----Original Message-----
> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> Shyti
> Sent: Wednesday, March 1, 2023 3:03 AM
> To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> <Michal.Wajdeczko@intel.com>
> Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
>
> To support multi-GT configurations, we need to generate
> independent debug files for each GT.
>
> To achieve this create a separate directory for each GT under the
> debugfs directory. For instance, in a system with two tiles, the
> debugfs structure would look like this:
>
> /sys/kernel/debug/dri
> └── 0
> ├── gt0
> │ ├── drpc
> │ ├── engines
> │ ├── forcewake
> │ ├── frequency
> │ └── rps_boost
> └── gt1
> : ├── drpc
> : ├── engines
> : ├── forcewake
> ├── frequency
> └── rps_boost
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
LGTM,
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> 4 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> struct dentry *root)
> void intel_gt_debugfs_register(struct intel_gt *gt)
> {
> struct dentry *root;
> + char gtname[4];
>
> if (!gt->i915->drm.primary->debugfs_root)
> return;
>
> - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> >debugfs_root);
> if (IS_ERR(root))
> return;
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> index bb4dfe707a7d0..e46aac1a41e6d 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -42,6 +42,8 @@ struct intel_guc {
> /** @capture: the error-state-capture module's data and objects */
> struct intel_guc_state_capture *capture;
>
> + struct dentry *dbgfs_node;
> +
> /** @sched_engine: Global engine used to submit requests to GuC */
> struct i915_sched_engine *sched_engine;
> /**
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 195db8c9d4200..55bc8b55fbc05 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> *log)
> */
> n_subbufs = 8;
>
> + if (!guc->dbgfs_node)
> + return -ENOENT;
> +
> guc_log_relay_chan = relay_open("guc_log",
> - i915->drm.primary->debugfs_root,
> + guc->dbgfs_node,
> subbuf_size, n_subbufs,
> &relay_callbacks, i915);
> if (!guc_log_relay_chan) {
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> index 284d6fbc2d08c..2f93cc4e408a8 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> dentry *gt_root)
> if (IS_ERR(root))
> return;
>
> + uc->guc.dbgfs_node = root;
> +
> intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
>
> intel_guc_debugfs_register(&uc->guc, root);
> --
> 2.39.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
@ 2023-03-01 21:32 ` Sripada, Radhakrishna
0 siblings, 0 replies; 21+ messages in thread
From: Sripada, Radhakrishna @ 2023-03-01 21:32 UTC (permalink / raw)
To: Andi Shyti, intel-gfx, dri-devel; +Cc: Patelczyk, Maciej
> -----Original Message-----
> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> Shyti
> Sent: Wednesday, March 1, 2023 3:03 AM
> To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> <Michal.Wajdeczko@intel.com>
> Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
>
> To support multi-GT configurations, we need to generate
> independent debug files for each GT.
>
> To achieve this create a separate directory for each GT under the
> debugfs directory. For instance, in a system with two tiles, the
> debugfs structure would look like this:
>
> /sys/kernel/debug/dri
> └── 0
> ├── gt0
> │ ├── drpc
> │ ├── engines
> │ ├── forcewake
> │ ├── frequency
> │ └── rps_boost
> └── gt1
> : ├── drpc
> : ├── engines
> : ├── forcewake
> ├── frequency
> └── rps_boost
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
LGTM,
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> 4 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> struct dentry *root)
> void intel_gt_debugfs_register(struct intel_gt *gt)
> {
> struct dentry *root;
> + char gtname[4];
>
> if (!gt->i915->drm.primary->debugfs_root)
> return;
>
> - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> >debugfs_root);
> if (IS_ERR(root))
> return;
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> index bb4dfe707a7d0..e46aac1a41e6d 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -42,6 +42,8 @@ struct intel_guc {
> /** @capture: the error-state-capture module's data and objects */
> struct intel_guc_state_capture *capture;
>
> + struct dentry *dbgfs_node;
> +
> /** @sched_engine: Global engine used to submit requests to GuC */
> struct i915_sched_engine *sched_engine;
> /**
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 195db8c9d4200..55bc8b55fbc05 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> *log)
> */
> n_subbufs = 8;
>
> + if (!guc->dbgfs_node)
> + return -ENOENT;
> +
> guc_log_relay_chan = relay_open("guc_log",
> - i915->drm.primary->debugfs_root,
> + guc->dbgfs_node,
> subbuf_size, n_subbufs,
> &relay_callbacks, i915);
> if (!guc_log_relay_chan) {
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> index 284d6fbc2d08c..2f93cc4e408a8 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> dentry *gt_root)
> if (IS_ERR(root))
> return;
>
> + uc->guc.dbgfs_node = root;
> +
> intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
>
> intel_guc_debugfs_register(&uc->guc, root);
> --
> 2.39.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
@ 2023-03-01 21:35 ` Sripada, Radhakrishna
-1 siblings, 0 replies; 21+ messages in thread
From: Sripada, Radhakrishna @ 2023-03-01 21:35 UTC (permalink / raw)
To: Andi Shyti, intel-gfx, dri-devel
Cc: Tvrtko Ursulin, Patelczyk, Maciej, Andi Shyti, Wajdeczko, Michal
I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles.
Shouldn't we be using gt instead of tile in our usage?
With s/tile/gt/g,
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> -----Original Message-----
> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> Shyti
> Sent: Wednesday, March 1, 2023 3:03 AM
> To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> <Michal.Wajdeczko@intel.com>
> Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
>
> To support multi-GT configurations, we need to generate
> independent debug files for each GT.
>
> To achieve this create a separate directory for each GT under the
> debugfs directory. For instance, in a system with two tiles, the
> debugfs structure would look like this:
>
> /sys/kernel/debug/dri
> └── 0
> ├── gt0
> │ ├── drpc
> │ ├── engines
> │ ├── forcewake
> │ ├── frequency
> │ └── rps_boost
> └── gt1
> : ├── drpc
> : ├── engines
> : ├── forcewake
> ├── frequency
> └── rps_boost
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> 4 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> struct dentry *root)
> void intel_gt_debugfs_register(struct intel_gt *gt)
> {
> struct dentry *root;
> + char gtname[4];
>
> if (!gt->i915->drm.primary->debugfs_root)
> return;
>
> - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> >debugfs_root);
> if (IS_ERR(root))
> return;
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> index bb4dfe707a7d0..e46aac1a41e6d 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -42,6 +42,8 @@ struct intel_guc {
> /** @capture: the error-state-capture module's data and objects */
> struct intel_guc_state_capture *capture;
>
> + struct dentry *dbgfs_node;
> +
> /** @sched_engine: Global engine used to submit requests to GuC */
> struct i915_sched_engine *sched_engine;
> /**
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 195db8c9d4200..55bc8b55fbc05 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> *log)
> */
> n_subbufs = 8;
>
> + if (!guc->dbgfs_node)
> + return -ENOENT;
> +
> guc_log_relay_chan = relay_open("guc_log",
> - i915->drm.primary->debugfs_root,
> + guc->dbgfs_node,
> subbuf_size, n_subbufs,
> &relay_callbacks, i915);
> if (!guc_log_relay_chan) {
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> index 284d6fbc2d08c..2f93cc4e408a8 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> dentry *gt_root)
> if (IS_ERR(root))
> return;
>
> + uc->guc.dbgfs_node = root;
> +
> intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
>
> intel_guc_debugfs_register(&uc->guc, root);
> --
> 2.39.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
@ 2023-03-01 21:35 ` Sripada, Radhakrishna
0 siblings, 0 replies; 21+ messages in thread
From: Sripada, Radhakrishna @ 2023-03-01 21:35 UTC (permalink / raw)
To: Andi Shyti, intel-gfx, dri-devel; +Cc: Patelczyk, Maciej
I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles.
Shouldn't we be using gt instead of tile in our usage?
With s/tile/gt/g,
Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
> -----Original Message-----
> From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> Shyti
> Sent: Wednesday, March 1, 2023 3:03 AM
> To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> <Michal.Wajdeczko@intel.com>
> Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
>
> To support multi-GT configurations, we need to generate
> independent debug files for each GT.
>
> To achieve this create a separate directory for each GT under the
> debugfs directory. For instance, in a system with two tiles, the
> debugfs structure would look like this:
>
> /sys/kernel/debug/dri
> └── 0
> ├── gt0
> │ ├── drpc
> │ ├── engines
> │ ├── forcewake
> │ ├── frequency
> │ └── rps_boost
> └── gt1
> : ├── drpc
> : ├── engines
> : ├── forcewake
> ├── frequency
> └── rps_boost
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> 4 files changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> struct dentry *root)
> void intel_gt_debugfs_register(struct intel_gt *gt)
> {
> struct dentry *root;
> + char gtname[4];
>
> if (!gt->i915->drm.primary->debugfs_root)
> return;
>
> - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> >debugfs_root);
> if (IS_ERR(root))
> return;
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> index bb4dfe707a7d0..e46aac1a41e6d 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> @@ -42,6 +42,8 @@ struct intel_guc {
> /** @capture: the error-state-capture module's data and objects */
> struct intel_guc_state_capture *capture;
>
> + struct dentry *dbgfs_node;
> +
> /** @sched_engine: Global engine used to submit requests to GuC */
> struct i915_sched_engine *sched_engine;
> /**
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> index 195db8c9d4200..55bc8b55fbc05 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> *log)
> */
> n_subbufs = 8;
>
> + if (!guc->dbgfs_node)
> + return -ENOENT;
> +
> guc_log_relay_chan = relay_open("guc_log",
> - i915->drm.primary->debugfs_root,
> + guc->dbgfs_node,
> subbuf_size, n_subbufs,
> &relay_callbacks, i915);
> if (!guc_log_relay_chan) {
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> index 284d6fbc2d08c..2f93cc4e408a8 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> dentry *gt_root)
> if (IS_ERR(root))
> return;
>
> + uc->guc.dbgfs_node = root;
> +
> intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
>
> intel_guc_debugfs_register(&uc->guc, root);
> --
> 2.39.1
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
2023-03-01 21:35 ` [Intel-gfx] " Sripada, Radhakrishna
@ 2023-03-01 22:04 ` Andi Shyti
-1 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 22:04 UTC (permalink / raw)
To: Sripada, Radhakrishna
Cc: Tvrtko Ursulin, Andi Shyti, intel-gfx, dri-devel, Andi Shyti,
Wajdeczko, Michal, Patelczyk, Maciej
> I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles.
> Shouldn't we be using gt instead of tile in our usage?
>
> With s/tile/gt/g,
> Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
yes, GT is preferred to tile, generally. Thanks for the review, I
will change the commit log according to your comment.
Thanks!
Andi
> > -----Original Message-----
> > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> > Shyti
> > Sent: Wednesday, March 1, 2023 3:03 AM
> > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> > <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> > Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> > <Michal.Wajdeczko@intel.com>
> > Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
> >
> > To support multi-GT configurations, we need to generate
> > independent debug files for each GT.
> >
> > To achieve this create a separate directory for each GT under the
> > debugfs directory. For instance, in a system with two tiles, the
> > debugfs structure would look like this:
> >
> > /sys/kernel/debug/dri
> > └── 0
> > ├── gt0
> > │ ├── drpc
> > │ ├── engines
> > │ ├── forcewake
> > │ ├── frequency
> > │ └── rps_boost
> > └── gt1
> > : ├── drpc
> > : ├── engines
> > : ├── forcewake
> > ├── frequency
> > └── rps_boost
> >
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> > 4 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> > struct dentry *root)
> > void intel_gt_debugfs_register(struct intel_gt *gt)
> > {
> > struct dentry *root;
> > + char gtname[4];
> >
> > if (!gt->i915->drm.primary->debugfs_root)
> > return;
> >
> > - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> > + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> > + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> > >debugfs_root);
> > if (IS_ERR(root))
> > return;
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > index bb4dfe707a7d0..e46aac1a41e6d 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > @@ -42,6 +42,8 @@ struct intel_guc {
> > /** @capture: the error-state-capture module's data and objects */
> > struct intel_guc_state_capture *capture;
> >
> > + struct dentry *dbgfs_node;
> > +
> > /** @sched_engine: Global engine used to submit requests to GuC */
> > struct i915_sched_engine *sched_engine;
> > /**
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > index 195db8c9d4200..55bc8b55fbc05 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> > *log)
> > */
> > n_subbufs = 8;
> >
> > + if (!guc->dbgfs_node)
> > + return -ENOENT;
> > +
> > guc_log_relay_chan = relay_open("guc_log",
> > - i915->drm.primary->debugfs_root,
> > + guc->dbgfs_node,
> > subbuf_size, n_subbufs,
> > &relay_callbacks, i915);
> > if (!guc_log_relay_chan) {
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > index 284d6fbc2d08c..2f93cc4e408a8 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> > dentry *gt_root)
> > if (IS_ERR(root))
> > return;
> >
> > + uc->guc.dbgfs_node = root;
> > +
> > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
> >
> > intel_guc_debugfs_register(&uc->guc, root);
> > --
> > 2.39.1
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
@ 2023-03-01 22:04 ` Andi Shyti
0 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-01 22:04 UTC (permalink / raw)
To: Sripada, Radhakrishna; +Cc: intel-gfx, dri-devel, Patelczyk, Maciej
> I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles.
> Shouldn't we be using gt instead of tile in our usage?
>
> With s/tile/gt/g,
> Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
yes, GT is preferred to tile, generally. Thanks for the review, I
will change the commit log according to your comment.
Thanks!
Andi
> > -----Original Message-----
> > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> > Shyti
> > Sent: Wednesday, March 1, 2023 3:03 AM
> > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> > <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> > Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> > <Michal.Wajdeczko@intel.com>
> > Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
> >
> > To support multi-GT configurations, we need to generate
> > independent debug files for each GT.
> >
> > To achieve this create a separate directory for each GT under the
> > debugfs directory. For instance, in a system with two tiles, the
> > debugfs structure would look like this:
> >
> > /sys/kernel/debug/dri
> > └── 0
> > ├── gt0
> > │ ├── drpc
> > │ ├── engines
> > │ ├── forcewake
> > │ ├── frequency
> > │ └── rps_boost
> > └── gt1
> > : ├── drpc
> > : ├── engines
> > : ├── forcewake
> > ├── frequency
> > └── rps_boost
> >
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> > 4 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> > struct dentry *root)
> > void intel_gt_debugfs_register(struct intel_gt *gt)
> > {
> > struct dentry *root;
> > + char gtname[4];
> >
> > if (!gt->i915->drm.primary->debugfs_root)
> > return;
> >
> > - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> > + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> > + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> > >debugfs_root);
> > if (IS_ERR(root))
> > return;
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > index bb4dfe707a7d0..e46aac1a41e6d 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > @@ -42,6 +42,8 @@ struct intel_guc {
> > /** @capture: the error-state-capture module's data and objects */
> > struct intel_guc_state_capture *capture;
> >
> > + struct dentry *dbgfs_node;
> > +
> > /** @sched_engine: Global engine used to submit requests to GuC */
> > struct i915_sched_engine *sched_engine;
> > /**
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > index 195db8c9d4200..55bc8b55fbc05 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> > *log)
> > */
> > n_subbufs = 8;
> >
> > + if (!guc->dbgfs_node)
> > + return -ENOENT;
> > +
> > guc_log_relay_chan = relay_open("guc_log",
> > - i915->drm.primary->debugfs_root,
> > + guc->dbgfs_node,
> > subbuf_size, n_subbufs,
> > &relay_callbacks, i915);
> > if (!guc_log_relay_chan) {
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > index 284d6fbc2d08c..2f93cc4e408a8 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> > dentry *gt_root)
> > if (IS_ERR(root))
> > return;
> >
> > + uc->guc.dbgfs_node = root;
> > +
> > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
> >
> > intel_guc_debugfs_register(&uc->guc, root);
> > --
> > 2.39.1
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for Some debugfs refactoring and improvements
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
` (4 preceding siblings ...)
(?)
@ 2023-03-03 15:01 ` Patchwork
-1 siblings, 0 replies; 21+ messages in thread
From: Patchwork @ 2023-03-03 15:01 UTC (permalink / raw)
To: Andi Shyti; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 44692 bytes --]
== Series Details ==
Series: Some debugfs refactoring and improvements
URL : https://patchwork.freedesktop.org/series/114510/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_12799_full -> Patchwork_114510v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Participating hosts (19 -> 19)
------------------------------
No changes in participating hosts
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_114510v1_full:
### IGT changes ###
#### Suppressed ####
The following results come from untrusted machines, tests, or statuses.
They do not affect the overall result.
* igt@gem_create@create-ext-cpu-access-big:
- {shard-dg2-1}: NOTRUN -> [ABORT][1] +1 similar issue
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-dg2-1/igt@gem_create@create-ext-cpu-access-big.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu:
- {shard-dg2-3}: NOTRUN -> [FAIL][2]
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-dg2-3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-pri-indfb-draw-mmap-cpu.html
* igt@kms_hdr@static-toggle-suspend@pipe-a-dp-1:
- {shard-dg2-11}: NOTRUN -> [FAIL][3]
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-dg2-11/igt@kms_hdr@static-toggle-suspend@pipe-a-dp-1.html
* {igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-d-dp-4}:
- {shard-dg2-11}: NOTRUN -> [SKIP][4]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-dg2-11/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-d-dp-4.html
New tests
---------
New tests have been introduced between CI_DRM_12799_full and Patchwork_114510v1_full:
### New IGT tests (5) ###
* igt@kms_flip@flip-vs-suspend-interruptible@d-dp4:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-0-25@pipe-a-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-0-25@pipe-c-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_plane_scaling@planes-downscale-factor-0-75-upscale-0-25@pipe-d-dp-2:
- Statuses : 1 pass(s)
- Exec time: [0.0] s
* igt@kms_rotation_crc:
- Statuses :
- Exec time: [None] s
Known issues
------------
Here are the changes found in Patchwork_114510v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@fbdev@write:
- shard-tglu-9: NOTRUN -> [SKIP][5] ([i915#2582])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@fbdev@write.html
* igt@feature_discovery@display-3x:
- shard-tglu-10: NOTRUN -> [SKIP][6] ([i915#1839]) +1 similar issue
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@feature_discovery@display-3x.html
* igt@gem_ccs@ctrl-surf-copy:
- shard-tglu-10: NOTRUN -> [SKIP][7] ([i915#3555] / [i915#5325])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_ccs@ctrl-surf-copy.html
* igt@gem_create@create-ext-cpu-access-sanity-check:
- shard-tglu-9: NOTRUN -> [SKIP][8] ([i915#6335])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@gem_create@create-ext-cpu-access-sanity-check.html
* igt@gem_ctx_persistence@engines-hostile-preempt:
- shard-snb: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#1099])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-snb1/igt@gem_ctx_persistence@engines-hostile-preempt.html
* igt@gem_ctx_sseu@engines:
- shard-tglu-9: NOTRUN -> [SKIP][10] ([i915#280])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@gem_ctx_sseu@engines.html
* igt@gem_exec_fair@basic-none-solo@rcs0:
- shard-tglu-10: NOTRUN -> [FAIL][11] ([i915#2842])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_exec_fair@basic-none-solo@rcs0.html
* igt@gem_exec_fair@basic-none@vcs0:
- shard-glk: [PASS][12] -> [FAIL][13] ([i915#2842]) +1 similar issue
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-glk2/igt@gem_exec_fair@basic-none@vcs0.html
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-glk1/igt@gem_exec_fair@basic-none@vcs0.html
* igt@gem_exec_gttfill@multigpu-basic:
- shard-tglu-10: NOTRUN -> [SKIP][14] ([i915#7697]) +1 similar issue
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_exec_gttfill@multigpu-basic.html
* igt@gem_lmem_swapping@massive-random:
- shard-tglu-10: NOTRUN -> [SKIP][15] ([i915#4613]) +2 similar issues
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_lmem_swapping@massive-random.html
* igt@gem_pread@exhaustion:
- shard-tglu-10: NOTRUN -> [WARN][16] ([i915#2658])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_pread@exhaustion.html
* igt@gem_pxp@reject-modify-context-protection-off-2:
- shard-tglu-10: NOTRUN -> [SKIP][17] ([i915#4270])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_pxp@reject-modify-context-protection-off-2.html
* igt@gem_pxp@verify-pxp-stale-buf-optout-execution:
- shard-tglu-9: NOTRUN -> [SKIP][18] ([i915#4270])
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@gem_pxp@verify-pxp-stale-buf-optout-execution.html
* igt@gem_userptr_blits@coherency-sync:
- shard-tglu-10: NOTRUN -> [SKIP][19] ([fdo#110542])
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_userptr_blits@coherency-sync.html
* igt@gem_userptr_blits@coherency-unsync:
- shard-tglu-10: NOTRUN -> [SKIP][20] ([i915#3297])
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gem_userptr_blits@coherency-unsync.html
* igt@gem_userptr_blits@unsync-unmap-after-close:
- shard-tglu-9: NOTRUN -> [SKIP][21] ([i915#3297])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@gem_userptr_blits@unsync-unmap-after-close.html
* igt@gen9_exec_parse@basic-rejected-ctx-param:
- shard-tglu-10: NOTRUN -> [SKIP][22] ([i915#2527] / [i915#2856]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@gen9_exec_parse@basic-rejected-ctx-param.html
* igt@gen9_exec_parse@unaligned-jump:
- shard-tglu-9: NOTRUN -> [SKIP][23] ([i915#2527] / [i915#2856])
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@gen9_exec_parse@unaligned-jump.html
* igt@i915_pm_backlight@fade:
- shard-tglu-10: NOTRUN -> [SKIP][24] ([i915#7561])
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@i915_pm_backlight@fade.html
* igt@i915_pm_backlight@fade-with-dpms:
- shard-tglu-9: NOTRUN -> [SKIP][25] ([i915#7561])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@i915_pm_backlight@fade-with-dpms.html
* igt@i915_pm_dc@dc6-dpms:
- shard-tglu-10: NOTRUN -> [FAIL][26] ([i915#3989] / [i915#454])
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@i915_pm_dc@dc6-dpms.html
* igt@i915_pm_freq_mult@media-freq@gt0:
- shard-tglu-9: NOTRUN -> [SKIP][27] ([i915#6590])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@i915_pm_freq_mult@media-freq@gt0.html
* igt@i915_pm_rc6_residency@rc6-idle@rcs0:
- shard-tglu-10: NOTRUN -> [WARN][28] ([i915#2681]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@i915_pm_rc6_residency@rc6-idle@rcs0.html
* igt@i915_pm_rpm@modeset-lpsp-stress-no-wait:
- shard-tglu-9: NOTRUN -> [SKIP][29] ([i915#1397])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@i915_pm_rpm@modeset-lpsp-stress-no-wait.html
* igt@i915_pm_rpm@modeset-pc8-residency-stress:
- shard-tglu-10: NOTRUN -> [SKIP][30] ([fdo#109506])
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@i915_pm_rpm@modeset-pc8-residency-stress.html
* igt@i915_pm_rps@reset:
- shard-snb: [PASS][31] -> [INCOMPLETE][32] ([i915#7790])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-snb1/igt@i915_pm_rps@reset.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-snb1/igt@i915_pm_rps@reset.html
* igt@i915_query@hwconfig_table:
- shard-tglu-9: NOTRUN -> [SKIP][33] ([i915#6245])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@i915_query@hwconfig_table.html
* igt@i915_query@query-topology-unsupported:
- shard-tglu-9: NOTRUN -> [SKIP][34] ([fdo#109302])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@i915_query@query-topology-unsupported.html
* igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip:
- shard-tglu-10: NOTRUN -> [SKIP][35] ([i915#5286]) +3 similar issues
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_big_fb@4-tiled-max-hw-stride-32bpp-rotate-0-hflip-async-flip.html
* igt@kms_big_fb@linear-16bpp-rotate-90:
- shard-tglu-10: NOTRUN -> [SKIP][36] ([fdo#111614]) +1 similar issue
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_big_fb@linear-16bpp-rotate-90.html
* igt@kms_big_fb@yf-tiled-32bpp-rotate-180:
- shard-tglu-10: NOTRUN -> [SKIP][37] ([fdo#111615]) +2 similar issues
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_big_fb@yf-tiled-32bpp-rotate-180.html
* igt@kms_big_joiner@2x-modeset:
- shard-tglu-10: NOTRUN -> [SKIP][38] ([i915#2705])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_big_joiner@2x-modeset.html
* igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs:
- shard-tglu-9: NOTRUN -> [SKIP][39] ([i915#1845] / [i915#7651]) +21 similar issues
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_ccs@pipe-a-crc-primary-rotation-180-y_tiled_gen12_rc_ccs.html
* igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][40] ([i915#6095]) +2 similar issues
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_ccs@pipe-b-bad-rotation-90-4_tiled_dg2_mc_ccs.html
* igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][41] ([i915#3689]) +8 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_ccs@pipe-b-missing-ccs-buffer-y_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][42] ([fdo#111615] / [i915#3689]) +3 similar issues
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_ccs@pipe-c-bad-pixel-format-yf_tiled_ccs.html
* igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][43] ([i915#3689] / [i915#3886]) +4 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_ccs@pipe-c-bad-rotation-90-y_tiled_gen12_mc_ccs.html
* igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs:
- shard-tglu-10: NOTRUN -> [SKIP][44] ([i915#3689] / [i915#6095]) +1 similar issue
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_ccs@pipe-c-crc-sprite-planes-basic-4_tiled_dg2_rc_ccs.html
* igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs:
- shard-tglu-9: NOTRUN -> [SKIP][45] ([fdo#111615] / [i915#1845] / [i915#7651]) +2 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_ccs@pipe-c-random-ccs-data-yf_tiled_ccs.html
* igt@kms_cdclk@mode-transition-all-outputs:
- shard-tglu-10: NOTRUN -> [SKIP][46] ([i915#3742])
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_cdclk@mode-transition-all-outputs.html
* igt@kms_chamelium_color@ctm-blue-to-red:
- shard-tglu-9: NOTRUN -> [SKIP][47] ([fdo#111827])
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_chamelium_color@ctm-blue-to-red.html
* igt@kms_chamelium_hpd@dp-hpd-storm-disable:
- shard-tglu-9: NOTRUN -> [SKIP][48] ([i915#7828]) +1 similar issue
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_chamelium_hpd@dp-hpd-storm-disable.html
* igt@kms_chamelium_hpd@hdmi-hpd:
- shard-tglu-10: NOTRUN -> [SKIP][49] ([i915#7828]) +6 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_chamelium_hpd@hdmi-hpd.html
* igt@kms_color@deep-color:
- shard-tglu-9: NOTRUN -> [SKIP][50] ([i915#3546])
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_color@deep-color.html
* igt@kms_content_protection@mei_interface:
- shard-tglu-10: NOTRUN -> [SKIP][51] ([fdo#109300])
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_content_protection@mei_interface.html
* igt@kms_cursor_crc@cursor-sliding-max-size:
- shard-tglu-10: NOTRUN -> [SKIP][52] ([i915#3555]) +2 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_cursor_crc@cursor-sliding-max-size.html
* igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
- shard-tglu-10: NOTRUN -> [SKIP][53] ([fdo#109274]) +5 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy.html
* igt@kms_cursor_legacy@cursora-vs-flipb-varying-size:
- shard-tglu-9: NOTRUN -> [SKIP][54] ([i915#1845]) +5 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_cursor_legacy@cursora-vs-flipb-varying-size.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
- shard-glk: [PASS][55] -> [FAIL][56] ([i915#2346])
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-glk9/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-glk7/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html
* igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle:
- shard-tglu-10: NOTRUN -> [SKIP][57] ([i915#4103])
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_cursor_legacy@short-busy-flip-before-cursor-toggle.html
* igt@kms_dsc@dsc-with-bpc-formats:
- shard-tglu-10: NOTRUN -> [SKIP][58] ([i915#3840])
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_dsc@dsc-with-bpc-formats.html
* igt@kms_flip@2x-flip-vs-fences:
- shard-tglu-10: NOTRUN -> [SKIP][59] ([fdo#109274] / [i915#3637]) +2 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_flip@2x-flip-vs-fences.html
* igt@kms_flip@2x-plain-flip-fb-recreate-interruptible:
- shard-tglu-9: NOTRUN -> [SKIP][60] ([fdo#109274] / [i915#3637]) +2 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_flip@2x-plain-flip-fb-recreate-interruptible.html
* igt@kms_flip@flip-vs-dpms-off-vs-modeset:
- shard-tglu-9: NOTRUN -> [SKIP][61] ([i915#3637]) +1 similar issue
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_flip@flip-vs-dpms-off-vs-modeset.html
* igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode:
- shard-tglu-10: NOTRUN -> [SKIP][62] ([i915#2587] / [i915#2672]) +3 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_flip_scaled_crc@flip-32bpp-yftile-to-64bpp-yftile-downscaling@pipe-a-valid-mode.html
* igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling:
- shard-tglu-9: NOTRUN -> [SKIP][63] ([i915#3555]) +2 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_flip_scaled_crc@flip-64bpp-yftile-to-32bpp-yftile-downscaling.html
* igt@kms_frontbuffer_tracking@fbc-tiling-y:
- shard-glk: [PASS][64] -> [DMESG-WARN][65] ([i915#1982])
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-glk2/igt@kms_frontbuffer_tracking@fbc-tiling-y.html
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-glk6/igt@kms_frontbuffer_tracking@fbc-tiling-y.html
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt:
- shard-tglu-9: NOTRUN -> [SKIP][66] ([i915#1849]) +17 similar issues
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-pri-shrfb-draw-blt.html
* igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-wc:
- shard-tglu-10: NOTRUN -> [SKIP][67] ([fdo#109280]) +28 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_frontbuffer_tracking@fbcpsr-2p-scndscrn-pri-shrfb-draw-mmap-wc.html
* igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt:
- shard-tglu-10: NOTRUN -> [SKIP][68] ([fdo#110189]) +20 similar issues
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_frontbuffer_tracking@psr-rgb101010-draw-blt.html
* igt@kms_panel_fitting@legacy:
- shard-tglu-10: NOTRUN -> [SKIP][69] ([i915#6301])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_panel_fitting@legacy.html
* igt@kms_plane_alpha_blend@alpha-basic:
- shard-tglu-9: NOTRUN -> [SKIP][70] ([i915#7128] / [i915#7294])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_plane_alpha_blend@alpha-basic.html
* igt@kms_plane_lowres@tiling-yf:
- shard-tglu-10: NOTRUN -> [SKIP][71] ([fdo#112054] / [i915#5288])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_plane_lowres@tiling-yf.html
* igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1:
- shard-snb: NOTRUN -> [SKIP][72] ([fdo#109271]) +93 similar issues
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-snb6/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-a-vga-1.html
* igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-1:
- shard-tglu-10: NOTRUN -> [SKIP][73] ([i915#5176]) +7 similar issues
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_plane_scaling@plane-upscale-with-rotation-factor-0-25@pipe-a-hdmi-a-1.html
* igt@kms_psr2_sf@primary-plane-update-sf-dmg-area:
- shard-tglu-10: NOTRUN -> [SKIP][74] ([fdo#111068] / [i915#658])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_psr2_sf@primary-plane-update-sf-dmg-area.html
* igt@kms_psr2_su@page_flip-p010:
- shard-tglu-10: NOTRUN -> [SKIP][75] ([fdo#109642] / [fdo#111068] / [i915#658])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_psr2_su@page_flip-p010.html
* igt@kms_psr@cursor_mmap_cpu:
- shard-tglu-9: NOTRUN -> [SKIP][76] ([fdo#110189]) +1 similar issue
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_psr@cursor_mmap_cpu.html
* igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0:
- shard-tglu-10: NOTRUN -> [SKIP][77] ([fdo#111615] / [i915#5289])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@kms_rotation_crc@primary-yf-tiled-reflect-x-0.html
* igt@kms_universal_plane@disable-primary-vs-flip-pipe-d:
- shard-tglu-9: NOTRUN -> [SKIP][78] ([fdo#109274]) +1 similar issue
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@kms_universal_plane@disable-primary-vs-flip-pipe-d.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- shard-tglu-10: NOTRUN -> [SKIP][79] ([fdo#109289]) +2 similar issues
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@perf@gen8-unprivileged-single-ctx-counters.html
* igt@perf@stress-open-close:
- shard-glk: [PASS][80] -> [ABORT][81] ([i915#5213])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-glk9/igt@perf@stress-open-close.html
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-glk4/igt@perf@stress-open-close.html
* igt@perf_pmu@event-wait@rcs0:
- shard-tglu-10: NOTRUN -> [SKIP][82] ([fdo#112283])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@perf_pmu@event-wait@rcs0.html
* igt@v3d/v3d_create_bo@create-bo-0:
- shard-tglu-9: NOTRUN -> [SKIP][83] ([fdo#109315] / [i915#2575]) +1 similar issue
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@v3d/v3d_create_bo@create-bo-0.html
* igt@v3d/v3d_get_param@base-params:
- shard-tglu-10: NOTRUN -> [SKIP][84] ([fdo#109315] / [i915#2575]) +3 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@v3d/v3d_get_param@base-params.html
* igt@vc4/vc4_create_bo@create-bo-4096:
- shard-tglu-10: NOTRUN -> [SKIP][85] ([i915#2575]) +7 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-10/igt@vc4/vc4_create_bo@create-bo-4096.html
* igt@vc4/vc4_purgeable_bo@access-purged-bo-mem:
- shard-tglu-9: NOTRUN -> [SKIP][86] ([i915#2575]) +1 similar issue
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-9/igt@vc4/vc4_purgeable_bo@access-purged-bo-mem.html
#### Possible fixes ####
* igt@drm_fdinfo@virtual-idle:
- {shard-rkl}: [FAIL][87] ([i915#7742]) -> [PASS][88]
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-4/igt@drm_fdinfo@virtual-idle.html
* igt@fbdev@unaligned-read:
- {shard-rkl}: [SKIP][89] ([i915#2582]) -> [PASS][90]
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-2/igt@fbdev@unaligned-read.html
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-6/igt@fbdev@unaligned-read.html
* igt@gem_bad_reloc@negative-reloc-lut:
- {shard-rkl}: [SKIP][91] ([i915#3281]) -> [PASS][92] +6 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-2/igt@gem_bad_reloc@negative-reloc-lut.html
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-5/igt@gem_bad_reloc@negative-reloc-lut.html
* igt@gem_eio@in-flight-suspend:
- {shard-rkl}: [FAIL][93] ([fdo#103375]) -> [PASS][94] +1 similar issue
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-4/igt@gem_eio@in-flight-suspend.html
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-2/igt@gem_eio@in-flight-suspend.html
* igt@gem_exec_fair@basic-pace-solo@rcs0:
- shard-apl: [FAIL][95] ([i915#2842]) -> [PASS][96]
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-apl6/igt@gem_exec_fair@basic-pace-solo@rcs0.html
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- {shard-rkl}: [SKIP][97] ([i915#3282]) -> [PASS][98] +2 similar issues
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-6/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-5/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gen9_exec_parse@unaligned-access:
- {shard-rkl}: [SKIP][99] ([i915#2527]) -> [PASS][100] +1 similar issue
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-6/igt@gen9_exec_parse@unaligned-access.html
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-5/igt@gen9_exec_parse@unaligned-access.html
* igt@i915_hangman@gt-engine-error@bcs0:
- {shard-rkl}: [SKIP][101] ([i915#6258]) -> [PASS][102]
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-5/igt@i915_hangman@gt-engine-error@bcs0.html
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-4/igt@i915_hangman@gt-engine-error@bcs0.html
* igt@i915_pm_rpm@cursor-dpms:
- {shard-tglu}: [SKIP][103] ([i915#1849]) -> [PASS][104] +2 similar issues
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-tglu-6/igt@i915_pm_rpm@cursor-dpms.html
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-7/igt@i915_pm_rpm@cursor-dpms.html
* igt@i915_pm_rps@basic-api:
- {shard-dg2-10}: [SKIP][105] ([i915#6621]) -> [PASS][106]
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-dg2-10/igt@i915_pm_rps@basic-api.html
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-dg2-10/igt@i915_pm_rps@basic-api.html
* igt@kms_big_fb@x-tiled-8bpp-rotate-180:
- {shard-tglu}: [SKIP][107] ([i915#1845] / [i915#7651]) -> [PASS][108] +14 similar issues
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-tglu-6/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-7/igt@kms_big_fb@x-tiled-8bpp-rotate-180.html
* igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip:
- {shard-rkl}: [SKIP][109] ([i915#1845] / [i915#4098]) -> [PASS][110] +7 similar issues
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-2/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-6/igt@kms_big_fb@y-tiled-max-hw-stride-64bpp-rotate-180-hflip.html
* igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
- shard-apl: [FAIL][111] ([i915#2346]) -> [PASS][112]
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-apl1/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-apl4/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html
* igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2:
- shard-glk: [FAIL][113] ([i915#79]) -> [PASS][114]
[113]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-glk8/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
[114]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-glk7/igt@kms_flip@flip-vs-expired-vblank@c-hdmi-a2.html
* igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt:
- {shard-rkl}: [SKIP][115] ([i915#1849] / [i915#4098]) -> [PASS][116] +5 similar issues
[115]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-2/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt.html
[116]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-6/igt@kms_frontbuffer_tracking@psr-1p-primscrn-pri-indfb-draw-blt.html
* igt@kms_universal_plane@universal-plane-pipe-a-functional:
- {shard-rkl}: [SKIP][117] ([i915#1845] / [i915#4070] / [i915#4098]) -> [PASS][118]
[117]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-2/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
[118]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-6/igt@kms_universal_plane@universal-plane-pipe-a-functional.html
* igt@kms_universal_plane@universal-plane-pipe-a-sanity:
- {shard-tglu}: [SKIP][119] ([fdo#109274]) -> [PASS][120] +1 similar issue
[119]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-tglu-6/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
[120]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-tglu-7/igt@kms_universal_plane@universal-plane-pipe-a-sanity.html
* igt@perf@gen8-unprivileged-single-ctx-counters:
- {shard-rkl}: [SKIP][121] ([i915#2436]) -> [PASS][122]
[121]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_12799/shard-rkl-2/igt@perf@gen8-unprivileged-single-ctx-counters.html
[122]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/shard-rkl-5/igt@perf@gen8-unprivileged-single-ctx-counters.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[IGT#2]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/2
[fdo#103375]: https://bugs.freedesktop.org/show_bug.cgi?id=103375
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109274]: https://bugs.freedesktop.org/show_bug.cgi?id=109274
[fdo#109279]: https://bugs.freedesktop.org/show_bug.cgi?id=109279
[fdo#109280]: https://bugs.freedesktop.org/show_bug.cgi?id=109280
[fdo#109283]: https://bugs.freedesktop.org/show_bug.cgi?id=109283
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#109289]: https://bugs.freedesktop.org/show_bug.cgi?id=109289
[fdo#109295]: https://bugs.freedesktop.org/show_bug.cgi?id=109295
[fdo#109300]: https://bugs.freedesktop.org/show_bug.cgi?id=109300
[fdo#109302]: https://bugs.freedesktop.org/show_bug.cgi?id=109302
[fdo#109303]: https://bugs.freedesktop.org/show_bug.cgi?id=109303
[fdo#109309]: https://bugs.freedesktop.org/show_bug.cgi?id=109309
[fdo#109312]: https://bugs.freedesktop.org/show_bug.cgi?id=109312
[fdo#109314]: https://bugs.freedesktop.org/show_bug.cgi?id=109314
[fdo#109315]: https://bugs.freedesktop.org/show_bug.cgi?id=109315
[fdo#109506]: https://bugs.freedesktop.org/show_bug.cgi?id=109506
[fdo#109642]: https://bugs.freedesktop.org/show_bug.cgi?id=109642
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#110542]: https://bugs.freedesktop.org/show_bug.cgi?id=110542
[fdo#110723]: https://bugs.freedesktop.org/show_bug.cgi?id=110723
[fdo#111068]: https://bugs.freedesktop.org/show_bug.cgi?id=111068
[fdo#111614]: https://bugs.freedesktop.org/show_bug.cgi?id=111614
[fdo#111615]: https://bugs.freedesktop.org/show_bug.cgi?id=111615
[fdo#111644]: https://bugs.freedesktop.org/show_bug.cgi?id=111644
[fdo#111656]: https://bugs.freedesktop.org/show_bug.cgi?id=111656
[fdo#111825]: https://bugs.freedesktop.org/show_bug.cgi?id=111825
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[fdo#112054]: https://bugs.freedesktop.org/show_bug.cgi?id=112054
[fdo#112283]: https://bugs.freedesktop.org/show_bug.cgi?id=112283
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1099]: https://gitlab.freedesktop.org/drm/intel/issues/1099
[i915#132]: https://gitlab.freedesktop.org/drm/intel/issues/132
[i915#1397]: https://gitlab.freedesktop.org/drm/intel/issues/1397
[i915#1755]: https://gitlab.freedesktop.org/drm/intel/issues/1755
[i915#1769]: https://gitlab.freedesktop.org/drm/intel/issues/1769
[i915#1825]: https://gitlab.freedesktop.org/drm/intel/issues/1825
[i915#1839]: https://gitlab.freedesktop.org/drm/intel/issues/1839
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
[i915#1902]: https://gitlab.freedesktop.org/drm/intel/issues/1902
[i915#1937]: https://gitlab.freedesktop.org/drm/intel/issues/1937
[i915#1982]: https://gitlab.freedesktop.org/drm/intel/issues/1982
[i915#2346]: https://gitlab.freedesktop.org/drm/intel/issues/2346
[i915#2434]: https://gitlab.freedesktop.org/drm/intel/issues/2434
[i915#2436]: https://gitlab.freedesktop.org/drm/intel/issues/2436
[i915#2437]: https://gitlab.freedesktop.org/drm/intel/issues/2437
[i915#2527]: https://gitlab.freedesktop.org/drm/intel/issues/2527
[i915#2575]: https://gitlab.freedesktop.org/drm/intel/issues/2575
[i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
[i915#2587]: https://gitlab.freedesktop.org/drm/intel/issues/2587
[i915#2658]: https://gitlab.freedesktop.org/drm/intel/issues/2658
[i915#2672]: https://gitlab.freedesktop.org/drm/intel/issues/2672
[i915#2681]: https://gitlab.freedesktop.org/drm/intel/issues/2681
[i915#2705]: https://gitlab.freedesktop.org/drm/intel/issues/2705
[i915#280]: https://gitlab.freedesktop.org/drm/intel/issues/280
[i915#284]: https://gitlab.freedesktop.org/drm/intel/issues/284
[i915#2842]: https://gitlab.freedesktop.org/drm/intel/issues/2842
[i915#2856]: https://gitlab.freedesktop.org/drm/intel/issues/2856
[i915#3116]: https://gitlab.freedesktop.org/drm/intel/issues/3116
[i915#315]: https://gitlab.freedesktop.org/drm/intel/issues/315
[i915#3281]: https://gitlab.freedesktop.org/drm/intel/issues/3281
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3297]: https://gitlab.freedesktop.org/drm/intel/issues/3297
[i915#3299]: https://gitlab.freedesktop.org/drm/intel/issues/3299
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3318]: https://gitlab.freedesktop.org/drm/intel/issues/3318
[i915#3359]: https://gitlab.freedesktop.org/drm/intel/issues/3359
[i915#3361]: https://gitlab.freedesktop.org/drm/intel/issues/3361
[i915#3458]: https://gitlab.freedesktop.org/drm/intel/issues/3458
[i915#3469]: https://gitlab.freedesktop.org/drm/intel/issues/3469
[i915#3528]: https://gitlab.freedesktop.org/drm/intel/issues/3528
[i915#3539]: https://gitlab.freedesktop.org/drm/intel/issues/3539
[i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3558]: https://gitlab.freedesktop.org/drm/intel/issues/3558
[i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
[i915#3638]: https://gitlab.freedesktop.org/drm/intel/issues/3638
[i915#3689]: https://gitlab.freedesktop.org/drm/intel/issues/3689
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3734]: https://gitlab.freedesktop.org/drm/intel/issues/3734
[i915#3742]: https://gitlab.freedesktop.org/drm/intel/issues/3742
[i915#3825]: https://gitlab.freedesktop.org/drm/intel/issues/3825
[i915#3826]: https://gitlab.freedesktop.org/drm/intel/issues/3826
[i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
[i915#3886]: https://gitlab.freedesktop.org/drm/intel/issues/3886
[i915#3936]: https://gitlab.freedesktop.org/drm/intel/issues/3936
[i915#3938]: https://gitlab.freedesktop.org/drm/intel/issues/3938
[i915#3952]: https://gitlab.freedesktop.org/drm/intel/issues/3952
[i915#3955]: https://gitlab.freedesktop.org/drm/intel/issues/3955
[i915#3989]: https://gitlab.freedesktop.org/drm/intel/issues/3989
[i915#4036]: https://gitlab.freedesktop.org/drm/intel/issues/4036
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
[i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
[i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
[i915#4087]: https://gitlab.freedesktop.org/drm/intel/issues/4087
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
[i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
[i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
[i915#4235]: https://gitlab.freedesktop.org/drm/intel/issues/4235
[i915#426]: https://gitlab.freedesktop.org/drm/intel/issues/426
[i915#4270]: https://gitlab.freedesktop.org/drm/intel/issues/4270
[i915#4349]: https://gitlab.freedesktop.org/drm/intel/issues/4349
[i915#4387]: https://gitlab.freedesktop.org/drm/intel/issues/4387
[i915#4537]: https://gitlab.freedesktop.org/drm/intel/issues/4537
[i915#4538]: https://gitlab.freedesktop.org/drm/intel/issues/4538
[i915#454]: https://gitlab.freedesktop.org/drm/intel/issues/454
[i915#4579]: https://gitlab.freedesktop.org/drm/intel/issues/4579
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#4771]: https://gitlab.freedesktop.org/drm/intel/issues/4771
[i915#4812]: https://gitlab.freedesktop.org/drm/intel/issues/4812
[i915#4816]: https://gitlab.freedesktop.org/drm/intel/issues/4816
[i915#4833]: https://gitlab.freedesktop.org/drm/intel/issues/4833
[i915#4852]: https://gitlab.freedesktop.org/drm/intel/issues/4852
[i915#4854]: https://gitlab.freedesktop.org/drm/intel/issues/4854
[i915#4859]: https://gitlab.freedesktop.org/drm/intel/issues/4859
[i915#4860]: https://gitlab.freedesktop.org/drm/intel/issues/4860
[i915#4873]: https://gitlab.freedesktop.org/drm/intel/issues/4873
[i915#4879]: https://gitlab.freedesktop.org/drm/intel/issues/4879
[i915#4880]: https://gitlab.freedesktop.org/drm/intel/issues/4880
[i915#4881]: https://gitlab.freedesktop.org/drm/intel/issues/4881
[i915#4885]: https://gitlab.freedesktop.org/drm/intel/issues/4885
[i915#4958]: https://gitlab.freedesktop.org/drm/intel/issues/4958
[i915#5107]: https://gitlab.freedesktop.org/drm/intel/issues/5107
[i915#5176]: https://gitlab.freedesktop.org/drm/intel/issues/5176
[i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
[i915#5213]: https://gitlab.freedesktop.org/drm/intel/issues/5213
[i915#5234]: https://gitlab.freedesktop.org/drm/intel/issues/5234
[i915#5235]: https://gitlab.freedesktop.org/drm/intel/issues/5235
[i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
[i915#5286]: https://gitlab.freedesktop.org/drm/intel/issues/5286
[i915#5288]: https://gitlab.freedesktop.org/drm/intel/issues/5288
[i915#5289]: https://gitlab.freedesktop.org/drm/intel/issues/5289
[i915#5325]: https://gitlab.freedesktop.org/drm/intel/issues/5325
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
[i915#5410]: https://gitlab.freedesktop.org/drm/intel/issues/5410
[i915#5431]: https://gitlab.freedesktop.org/drm/intel/issues/5431
[i915#5433]: https://gitlab.freedesktop.org/drm/intel/issues/5433
[i915#5439]: https://gitlab.freedesktop.org/drm/intel/issues/5439
[i915#5445]: https://gitlab.freedesktop.org/drm/intel/issues/5445
[i915#5460]: https://gitlab.freedesktop.org/drm/intel/issues/5460
[i915#5461]: https://gitlab.freedesktop.org/drm/intel/issues/5461
[i915#5464]: https://gitlab.freedesktop.org/drm/intel/issues/5464
[i915#5493]: https://gitlab.freedesktop.org/drm/intel/issues/5493
[i915#5563]: https://gitlab.freedesktop.org/drm/intel/issues/5563
[i915#5723]: https://gitlab.freedesktop.org/drm/intel/issues/5723
[i915#5882]: https://gitlab.freedesktop.org/drm/intel/issues/5882
[i915#5892]: https://gitlab.freedesktop.org/drm/intel/issues/5892
[i915#5978]: https://gitlab.freedesktop.org/drm/intel/issues/5978
[i915#6032]: https://gitlab.freedesktop.org/drm/intel/issues/6032
[i915#6095]: https://gitlab.freedesktop.org/drm/intel/issues/6095
[i915#6118]: https://gitlab.freedesktop.org/drm/intel/issues/6118
[i915#6122]: https://gitlab.freedesktop.org/drm/intel/issues/6122
[i915#6188]: https://gitlab.freedesktop.org/drm/intel/issues/6188
[i915#6227]: https://gitlab.freedesktop.org/drm/intel/issues/6227
[i915#6228]: https://gitlab.freedesktop.org/drm/intel/issues/6228
[i915#6245]: https://gitlab.freedesktop.org/drm/intel/issues/6245
[i915#6248]: https://gitlab.freedesktop.org/drm/intel/issues/6248
[i915#6258]: https://gitlab.freedesktop.org/drm/intel/issues/6258
[i915#6301]: https://gitlab.freedesktop.org/drm/intel/issues/6301
[i915#6333]: https://gitlab.freedesktop.org/drm/intel/issues/6333
[i915#6334]: https://gitlab.freedesktop.org/drm/intel/issues/6334
[i915#6335]: https://gitlab.freedesktop.org/drm/intel/issues/6335
[i915#6433]: https://gitlab.freedesktop.org/drm/intel/issues/6433
[i915#6497]: https://gitlab.freedesktop.org/drm/intel/issues/6497
[i915#6524]: https://gitlab.freedesktop.org/drm/intel/issues/6524
[i915#6530]: https://gitlab.freedesktop.org/drm/intel/issues/6530
[i915#658]: https://gitlab.freedesktop.org/drm/intel/issues/658
[i915#6590]: https://gitlab.freedesktop.org/drm/intel/issues/6590
[i915#6596]: https://gitlab.freedesktop.org/drm/intel/issues/6596
[i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
[i915#6768]: https://gitlab.freedesktop.org/drm/intel/issues/6768
[i915#6805]: https://gitlab.freedesktop.org/drm/intel/issues/6805
[i915#6880]: https://gitlab.freedesktop.org/drm/intel/issues/6880
[i915#6944]: https://gitlab.freedesktop.org/drm/intel/issues/6944
[i915#6946]: https://gitlab.freedesktop.org/drm/intel/issues/6946
[i915#6953]: https://gitlab.freedesktop.org/drm/intel/issues/6953
[i915#7091]: https://gitlab.freedesktop.org/drm/intel/issues/7091
[i915#7116]: https://gitlab.freedesktop.org/drm/intel/issues/7116
[i915#7118]: https://gitlab.freedesktop.org/drm/intel/issues/7118
[i915#7128]: https://gitlab.freedesktop.org/drm/intel/issues/7128
[i915#7294]: https://gitlab.freedesktop.org/drm/intel/issues/7294
[i915#7356]: https://gitlab.freedesktop.org/drm/intel/issues/7356
[i915#7387]: https://gitlab.freedesktop.org/drm/intel/issues/7387
[i915#7561]: https://gitlab.freedesktop.org/drm/intel/issues/7561
[i915#7651]: https://gitlab.freedesktop.org/drm/intel/issues/7651
[i915#7679]: https://gitlab.freedesktop.org/drm/intel/issues/7679
[i915#7697]: https://gitlab.freedesktop.org/drm/intel/issues/7697
[i915#7701]: https://gitlab.freedesktop.org/drm/intel/issues/7701
[i915#7711]: https://gitlab.freedesktop.org/drm/intel/issues/7711
[i915#7742]: https://gitlab.freedesktop.org/drm/intel/issues/7742
[i915#7790]: https://gitlab.freedesktop.org/drm/intel/issues/7790
[i915#7828]: https://gitlab.freedesktop.org/drm/intel/issues/7828
[i915#79]: https://gitlab.freedesktop.org/drm/intel/issues/79
[i915#7949]: https://gitlab.freedesktop.org/drm/intel/issues/7949
[i915#7957]: https://gitlab.freedesktop.org/drm/intel/issues/7957
[i915#7975]: https://gitlab.freedesktop.org/drm/intel/issues/7975
[i915#7997]: https://gitlab.freedesktop.org/drm/intel/issues/7997
[i915#8077]: https://gitlab.freedesktop.org/drm/intel/issues/8077
[i915#8152]: https://gitlab.freedesktop.org/drm/intel/issues/8152
[i915#8154]: https://gitlab.freedesktop.org/drm/intel/issues/8154
[i915#8155]: https://gitlab.freedesktop.org/drm/intel/issues/8155
[i915#8228]: https://gitlab.freedesktop.org/drm/intel/issues/8228
Build changes
-------------
* Linux: CI_DRM_12799 -> Patchwork_114510v1
CI-20190529: 20190529
CI_DRM_12799: 5f6631c00a7f226c990aecc643bc9fa70da1599a @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_7178: ffe3f6670b91ab975f90799ab3fd0941b6eae019 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_114510v1: 5f6631c00a7f226c990aecc643bc9fa70da1599a @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_114510v1/index.html
[-- Attachment #2: Type: text/html, Size: 41961 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
2023-03-01 21:35 ` [Intel-gfx] " Sripada, Radhakrishna
@ 2023-03-04 3:24 ` Andi Shyti
-1 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-04 3:24 UTC (permalink / raw)
To: Sripada, Radhakrishna
Cc: Tvrtko Ursulin, Andi Shyti, intel-gfx, dri-devel, Andi Shyti,
Wajdeczko, Michal, Patelczyk, Maciej
On Wed, Mar 01, 2023 at 09:35:33PM +0000, Sripada, Radhakrishna wrote:
> I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles.
> Shouldn't we be using gt instead of tile in our usage?
>
> With s/tile/gt/g,
> Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Just one question... you reviewed twice Patch number 1. Did you
mean to review patch 1 and patch 2?
Thanks,
Andi
>
> > -----Original Message-----
> > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> > Shyti
> > Sent: Wednesday, March 1, 2023 3:03 AM
> > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> > <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> > Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> > <Michal.Wajdeczko@intel.com>
> > Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
> >
> > To support multi-GT configurations, we need to generate
> > independent debug files for each GT.
> >
> > To achieve this create a separate directory for each GT under the
> > debugfs directory. For instance, in a system with two tiles, the
> > debugfs structure would look like this:
> >
> > /sys/kernel/debug/dri
> > └── 0
> > ├── gt0
> > │ ├── drpc
> > │ ├── engines
> > │ ├── forcewake
> > │ ├── frequency
> > │ └── rps_boost
> > └── gt1
> > : ├── drpc
> > : ├── engines
> > : ├── forcewake
> > ├── frequency
> > └── rps_boost
> >
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> > 4 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> > struct dentry *root)
> > void intel_gt_debugfs_register(struct intel_gt *gt)
> > {
> > struct dentry *root;
> > + char gtname[4];
> >
> > if (!gt->i915->drm.primary->debugfs_root)
> > return;
> >
> > - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> > + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> > + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> > >debugfs_root);
> > if (IS_ERR(root))
> > return;
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > index bb4dfe707a7d0..e46aac1a41e6d 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > @@ -42,6 +42,8 @@ struct intel_guc {
> > /** @capture: the error-state-capture module's data and objects */
> > struct intel_guc_state_capture *capture;
> >
> > + struct dentry *dbgfs_node;
> > +
> > /** @sched_engine: Global engine used to submit requests to GuC */
> > struct i915_sched_engine *sched_engine;
> > /**
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > index 195db8c9d4200..55bc8b55fbc05 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> > *log)
> > */
> > n_subbufs = 8;
> >
> > + if (!guc->dbgfs_node)
> > + return -ENOENT;
> > +
> > guc_log_relay_chan = relay_open("guc_log",
> > - i915->drm.primary->debugfs_root,
> > + guc->dbgfs_node,
> > subbuf_size, n_subbufs,
> > &relay_callbacks, i915);
> > if (!guc_log_relay_chan) {
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > index 284d6fbc2d08c..2f93cc4e408a8 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> > dentry *gt_root)
> > if (IS_ERR(root))
> > return;
> >
> > + uc->guc.dbgfs_node = root;
> > +
> > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
> >
> > intel_guc_debugfs_register(&uc->guc, root);
> > --
> > 2.39.1
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
@ 2023-03-04 3:24 ` Andi Shyti
0 siblings, 0 replies; 21+ messages in thread
From: Andi Shyti @ 2023-03-04 3:24 UTC (permalink / raw)
To: Sripada, Radhakrishna; +Cc: intel-gfx, dri-devel, Patelczyk, Maciej
On Wed, Mar 01, 2023 at 09:35:33PM +0000, Sripada, Radhakrishna wrote:
> I am not sure if Tiles is appropriate usage here. Since MTL does not have the concept of tiles.
> Shouldn't we be using gt instead of tile in our usage?
>
> With s/tile/gt/g,
> Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
Just one question... you reviewed twice Patch number 1. Did you
mean to review patch 1 and patch 2?
Thanks,
Andi
>
> > -----Original Message-----
> > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of Andi
> > Shyti
> > Sent: Wednesday, March 1, 2023 3:03 AM
> > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> > <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> > Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> > <Michal.Wajdeczko@intel.com>
> > Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
> >
> > To support multi-GT configurations, we need to generate
> > independent debug files for each GT.
> >
> > To achieve this create a separate directory for each GT under the
> > debugfs directory. For instance, in a system with two tiles, the
> > debugfs structure would look like this:
> >
> > /sys/kernel/debug/dri
> > └── 0
> > ├── gt0
> > │ ├── drpc
> > │ ├── engines
> > │ ├── forcewake
> > │ ├── frequency
> > │ └── rps_boost
> > └── gt1
> > : ├── drpc
> > : ├── engines
> > : ├── forcewake
> > ├── frequency
> > └── rps_boost
> >
> > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > ---
> > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> > 4 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> > struct dentry *root)
> > void intel_gt_debugfs_register(struct intel_gt *gt)
> > {
> > struct dentry *root;
> > + char gtname[4];
> >
> > if (!gt->i915->drm.primary->debugfs_root)
> > return;
> >
> > - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> > + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> > + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> > >debugfs_root);
> > if (IS_ERR(root))
> > return;
> >
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > index bb4dfe707a7d0..e46aac1a41e6d 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > @@ -42,6 +42,8 @@ struct intel_guc {
> > /** @capture: the error-state-capture module's data and objects */
> > struct intel_guc_state_capture *capture;
> >
> > + struct dentry *dbgfs_node;
> > +
> > /** @sched_engine: Global engine used to submit requests to GuC */
> > struct i915_sched_engine *sched_engine;
> > /**
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > index 195db8c9d4200..55bc8b55fbc05 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> > *log)
> > */
> > n_subbufs = 8;
> >
> > + if (!guc->dbgfs_node)
> > + return -ENOENT;
> > +
> > guc_log_relay_chan = relay_open("guc_log",
> > - i915->drm.primary->debugfs_root,
> > + guc->dbgfs_node,
> > subbuf_size, n_subbufs,
> > &relay_callbacks, i915);
> > if (!guc_log_relay_chan) {
> > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > index 284d6fbc2d08c..2f93cc4e408a8 100644
> > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc, struct
> > dentry *gt_root)
> > if (IS_ERR(root))
> > return;
> >
> > + uc->guc.dbgfs_node = root;
> > +
> > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
> >
> > intel_guc_debugfs_register(&uc->guc, root);
> > --
> > 2.39.1
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* RE: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
2023-03-04 3:24 ` [Intel-gfx] " Andi Shyti
@ 2023-03-06 15:10 ` Sripada, Radhakrishna
-1 siblings, 0 replies; 21+ messages in thread
From: Sripada, Radhakrishna @ 2023-03-06 15:10 UTC (permalink / raw)
To: Andi Shyti
Cc: Tvrtko Ursulin, Patelczyk, Maciej, intel-gfx, dri-devel,
Andi Shyti, Wajdeczko, Michal
> -----Original Message-----
> From: Andi Shyti <andi.shyti@linux.intel.com>
> Sent: Friday, March 3, 2023 7:24 PM
> To: Sripada, Radhakrishna <radhakrishna.sripada@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>; intel-gfx@lists.freedesktop.org; dri-
> devel@lists.freedesktop.org; Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>;
> Andi Shyti <andi@etezian.org>; Patelczyk, Maciej
> <maciej.patelczyk@intel.com>; Wajdeczko, Michal
> <Michal.Wajdeczko@intel.com>
> Subject: Re: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
>
> On Wed, Mar 01, 2023 at 09:35:33PM +0000, Sripada, Radhakrishna wrote:
> > I am not sure if Tiles is appropriate usage here. Since MTL does not have the
> concept of tiles.
> > Shouldn't we be using gt instead of tile in our usage?
> >
> > With s/tile/gt/g,
> > Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>
> Just one question... you reviewed twice Patch number 1. Did you
> mean to review patch 1 and patch 2?
This was for Patch1 itself. I did not include s/tile/gt/g during the first time I gave r-b
hence added that with new r-b.
-RK
>
> Thanks,
> Andi
>
> >
> > > -----Original Message-----
> > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
> Andi
> > > Shyti
> > > Sent: Wednesday, March 1, 2023 3:03 AM
> > > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> > > <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> > > Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> > > <Michal.Wajdeczko@intel.com>
> > > Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
> > >
> > > To support multi-GT configurations, we need to generate
> > > independent debug files for each GT.
> > >
> > > To achieve this create a separate directory for each GT under the
> > > debugfs directory. For instance, in a system with two tiles, the
> > > debugfs structure would look like this:
> > >
> > > /sys/kernel/debug/dri
> > > └── 0
> > > ├── gt0
> > > │ ├── drpc
> > > │ ├── engines
> > > │ ├── forcewake
> > > │ ├── frequency
> > > │ └── rps_boost
> > > └── gt1
> > > : ├── drpc
> > > : ├── engines
> > > : ├── forcewake
> > > ├── frequency
> > > └── rps_boost
> > >
> > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> > > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> > > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> > > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> > > 4 files changed, 11 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> > > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> > > struct dentry *root)
> > > void intel_gt_debugfs_register(struct intel_gt *gt)
> > > {
> > > struct dentry *root;
> > > + char gtname[4];
> > >
> > > if (!gt->i915->drm.primary->debugfs_root)
> > > return;
> > >
> > > - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> > > + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> > > + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> > > >debugfs_root);
> > > if (IS_ERR(root))
> > > return;
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > index bb4dfe707a7d0..e46aac1a41e6d 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > @@ -42,6 +42,8 @@ struct intel_guc {
> > > /** @capture: the error-state-capture module's data and objects */
> > > struct intel_guc_state_capture *capture;
> > >
> > > + struct dentry *dbgfs_node;
> > > +
> > > /** @sched_engine: Global engine used to submit requests to GuC */
> > > struct i915_sched_engine *sched_engine;
> > > /**
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > index 195db8c9d4200..55bc8b55fbc05 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> > > *log)
> > > */
> > > n_subbufs = 8;
> > >
> > > + if (!guc->dbgfs_node)
> > > + return -ENOENT;
> > > +
> > > guc_log_relay_chan = relay_open("guc_log",
> > > - i915->drm.primary->debugfs_root,
> > > + guc->dbgfs_node,
> > > subbuf_size, n_subbufs,
> > > &relay_callbacks, i915);
> > > if (!guc_log_relay_chan) {
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > index 284d6fbc2d08c..2f93cc4e408a8 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc,
> struct
> > > dentry *gt_root)
> > > if (IS_ERR(root))
> > > return;
> > >
> > > + uc->guc.dbgfs_node = root;
> > > +
> > > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
> > >
> > > intel_guc_debugfs_register(&uc->guc, root);
> > > --
> > > 2.39.1
> >
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
@ 2023-03-06 15:10 ` Sripada, Radhakrishna
0 siblings, 0 replies; 21+ messages in thread
From: Sripada, Radhakrishna @ 2023-03-06 15:10 UTC (permalink / raw)
To: Andi Shyti; +Cc: Patelczyk, Maciej, intel-gfx, dri-devel
> -----Original Message-----
> From: Andi Shyti <andi.shyti@linux.intel.com>
> Sent: Friday, March 3, 2023 7:24 PM
> To: Sripada, Radhakrishna <radhakrishna.sripada@intel.com>
> Cc: Andi Shyti <andi.shyti@linux.intel.com>; intel-gfx@lists.freedesktop.org; dri-
> devel@lists.freedesktop.org; Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>;
> Andi Shyti <andi@etezian.org>; Patelczyk, Maciej
> <maciej.patelczyk@intel.com>; Wajdeczko, Michal
> <Michal.Wajdeczko@intel.com>
> Subject: Re: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
>
> On Wed, Mar 01, 2023 at 09:35:33PM +0000, Sripada, Radhakrishna wrote:
> > I am not sure if Tiles is appropriate usage here. Since MTL does not have the
> concept of tiles.
> > Shouldn't we be using gt instead of tile in our usage?
> >
> > With s/tile/gt/g,
> > Reviewed-by: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>
> Just one question... you reviewed twice Patch number 1. Did you
> mean to review patch 1 and patch 2?
This was for Patch1 itself. I did not include s/tile/gt/g during the first time I gave r-b
hence added that with new r-b.
-RK
>
> Thanks,
> Andi
>
> >
> > > -----Original Message-----
> > > From: dri-devel <dri-devel-bounces@lists.freedesktop.org> On Behalf Of
> Andi
> > > Shyti
> > > Sent: Wednesday, March 1, 2023 3:03 AM
> > > To: intel-gfx@lists.freedesktop.org; dri-devel@lists.freedesktop.org
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>; Andi Shyti
> > > <andi@etezian.org>; Patelczyk, Maciej <maciej.patelczyk@intel.com>; Andi
> > > Shyti <andi.shyti@linux.intel.com>; Wajdeczko, Michal
> > > <Michal.Wajdeczko@intel.com>
> > > Subject: [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files
> > >
> > > To support multi-GT configurations, we need to generate
> > > independent debug files for each GT.
> > >
> > > To achieve this create a separate directory for each GT under the
> > > debugfs directory. For instance, in a system with two tiles, the
> > > debugfs structure would look like this:
> > >
> > > /sys/kernel/debug/dri
> > > └── 0
> > > ├── gt0
> > > │ ├── drpc
> > > │ ├── engines
> > > │ ├── forcewake
> > > │ ├── frequency
> > > │ └── rps_boost
> > > └── gt1
> > > : ├── drpc
> > > : ├── engines
> > > : ├── forcewake
> > > ├── frequency
> > > └── rps_boost
> > >
> > > Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> > > Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/gt/intel_gt_debugfs.c | 4 +++-
> > > drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 ++
> > > drivers/gpu/drm/i915/gt/uc/intel_guc_log.c | 5 ++++-
> > > drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c | 2 ++
> > > 4 files changed, 11 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > index 5fc2df01aa0df..4dc23b8d3aa2d 100644
> > > --- a/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/gt/intel_gt_debugfs.c
> > > @@ -83,11 +83,13 @@ static void gt_debugfs_register(struct intel_gt *gt,
> > > struct dentry *root)
> > > void intel_gt_debugfs_register(struct intel_gt *gt)
> > > {
> > > struct dentry *root;
> > > + char gtname[4];
> > >
> > > if (!gt->i915->drm.primary->debugfs_root)
> > > return;
> > >
> > > - root = debugfs_create_dir("gt", gt->i915->drm.primary->debugfs_root);
> > > + snprintf(gtname, sizeof(gtname), "gt%u", gt->info.id);
> > > + root = debugfs_create_dir(gtname, gt->i915->drm.primary-
> > > >debugfs_root);
> > > if (IS_ERR(root))
> > > return;
> > >
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > index bb4dfe707a7d0..e46aac1a41e6d 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc.h
> > > @@ -42,6 +42,8 @@ struct intel_guc {
> > > /** @capture: the error-state-capture module's data and objects */
> > > struct intel_guc_state_capture *capture;
> > >
> > > + struct dentry *dbgfs_node;
> > > +
> > > /** @sched_engine: Global engine used to submit requests to GuC */
> > > struct i915_sched_engine *sched_engine;
> > > /**
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > index 195db8c9d4200..55bc8b55fbc05 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_log.c
> > > @@ -542,8 +542,11 @@ static int guc_log_relay_create(struct intel_guc_log
> > > *log)
> > > */
> > > n_subbufs = 8;
> > >
> > > + if (!guc->dbgfs_node)
> > > + return -ENOENT;
> > > +
> > > guc_log_relay_chan = relay_open("guc_log",
> > > - i915->drm.primary->debugfs_root,
> > > + guc->dbgfs_node,
> > > subbuf_size, n_subbufs,
> > > &relay_callbacks, i915);
> > > if (!guc_log_relay_chan) {
> > > diff --git a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > index 284d6fbc2d08c..2f93cc4e408a8 100644
> > > --- a/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > +++ b/drivers/gpu/drm/i915/gt/uc/intel_uc_debugfs.c
> > > @@ -54,6 +54,8 @@ void intel_uc_debugfs_register(struct intel_uc *uc,
> struct
> > > dentry *gt_root)
> > > if (IS_ERR(root))
> > > return;
> > >
> > > + uc->guc.dbgfs_node = root;
> > > +
> > > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc);
> > >
> > > intel_guc_debugfs_register(&uc->guc, root);
> > > --
> > > 2.39.1
> >
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH v2 2/2] drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
@ 2023-03-17 11:26 ` Das, Nirmoy
-1 siblings, 0 replies; 21+ messages in thread
From: Das, Nirmoy @ 2023-03-17 11:26 UTC (permalink / raw)
To: Andi Shyti, intel-gfx, dri-devel; +Cc: Maciej Patelczyk
On 3/1/2023 12:02 PM, Andi Shyti wrote:
> The commit 82a149a62b6b5 ('drm/i915/gt: move remaining debugfs
> interfaces into gt') moved gt-related debugfs files in the gtX/
> directories to operate on individual gt's.
>
> However, the original files were only functioning on the root
> tile (tile 0) and have been left in the same location to maintain
> compatibility with userspace users.
>
> Add multiplexing functionality to the higher directories' files.
> This enables the operations to be performed on all the tiles with
> a single write. In the case of reads, the files provide an or'ed
> value across all the tiles.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 38 ++++++++++++++++++++++++++---
> 1 file changed, 34 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 45773ce1deac2..90663f251fd10 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -575,14 +575,36 @@ static int i915_wa_registers(struct seq_file *m, void *unused)
> static int i915_wedged_get(void *data, u64 *val)
> {
> struct drm_i915_private *i915 = data;
> + struct intel_gt *gt;
> + unsigned int i;
>
> - return intel_gt_debugfs_reset_show(to_gt(i915), val);
> + *val = 0;
> +
> + for_each_gt(gt, i915, i) {
> + int ret;
> + u64 v;
> +
> + ret = intel_gt_debugfs_reset_show(gt, &v);
> + if (ret)
> + return ret;
> +
> + /* at least one tile should be wedged */
> + *val |= !!v;
> + if (*val)
> + break;
> + }
> +
> + return 0;
> }
>
> static int i915_wedged_set(void *data, u64 val)
> {
> struct drm_i915_private *i915 = data;
> - intel_gt_debugfs_reset_store(to_gt(i915), val);
> + struct intel_gt *gt;
> + unsigned int i;
> +
> + for_each_gt(gt, i915, i)
> + intel_gt_debugfs_reset_store(gt, val);
>
> return 0;
> }
> @@ -733,7 +755,11 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
> static int i915_forcewake_open(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
> - intel_gt_pm_debugfs_forcewake_user_open(to_gt(i915));
> + struct intel_gt *gt;
> + unsigned int i;
> +
> + for_each_gt(gt, i915, i)
> + intel_gt_pm_debugfs_forcewake_user_open(gt);
>
> return 0;
> }
> @@ -741,7 +767,11 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
> static int i915_forcewake_release(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
> - intel_gt_pm_debugfs_forcewake_user_release(to_gt(i915));
> + struct intel_gt *gt;
> + unsigned int i;
> +
> + for_each_gt(gt, i915, i)
> + intel_gt_pm_debugfs_forcewake_user_release(gt);
>
> return 0;
> }
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/debugfs: Enable upper layer interfaces to act on all gt's
@ 2023-03-17 11:26 ` Das, Nirmoy
0 siblings, 0 replies; 21+ messages in thread
From: Das, Nirmoy @ 2023-03-17 11:26 UTC (permalink / raw)
To: Andi Shyti, intel-gfx, dri-devel; +Cc: Maciej Patelczyk
On 3/1/2023 12:02 PM, Andi Shyti wrote:
> The commit 82a149a62b6b5 ('drm/i915/gt: move remaining debugfs
> interfaces into gt') moved gt-related debugfs files in the gtX/
> directories to operate on individual gt's.
>
> However, the original files were only functioning on the root
> tile (tile 0) and have been left in the same location to maintain
> compatibility with userspace users.
>
> Add multiplexing functionality to the higher directories' files.
> This enables the operations to be performed on all the tiles with
> a single write. In the case of reads, the files provide an or'ed
> value across all the tiles.
>
> Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
> Cc: Maciej Patelczyk <maciej.patelczyk@intel.com>
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 38 ++++++++++++++++++++++++++---
> 1 file changed, 34 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 45773ce1deac2..90663f251fd10 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -575,14 +575,36 @@ static int i915_wa_registers(struct seq_file *m, void *unused)
> static int i915_wedged_get(void *data, u64 *val)
> {
> struct drm_i915_private *i915 = data;
> + struct intel_gt *gt;
> + unsigned int i;
>
> - return intel_gt_debugfs_reset_show(to_gt(i915), val);
> + *val = 0;
> +
> + for_each_gt(gt, i915, i) {
> + int ret;
> + u64 v;
> +
> + ret = intel_gt_debugfs_reset_show(gt, &v);
> + if (ret)
> + return ret;
> +
> + /* at least one tile should be wedged */
> + *val |= !!v;
> + if (*val)
> + break;
> + }
> +
> + return 0;
> }
>
> static int i915_wedged_set(void *data, u64 val)
> {
> struct drm_i915_private *i915 = data;
> - intel_gt_debugfs_reset_store(to_gt(i915), val);
> + struct intel_gt *gt;
> + unsigned int i;
> +
> + for_each_gt(gt, i915, i)
> + intel_gt_debugfs_reset_store(gt, val);
>
> return 0;
> }
> @@ -733,7 +755,11 @@ static int i915_sseu_status(struct seq_file *m, void *unused)
> static int i915_forcewake_open(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
> - intel_gt_pm_debugfs_forcewake_user_open(to_gt(i915));
> + struct intel_gt *gt;
> + unsigned int i;
> +
> + for_each_gt(gt, i915, i)
> + intel_gt_pm_debugfs_forcewake_user_open(gt);
>
> return 0;
> }
> @@ -741,7 +767,11 @@ static int i915_forcewake_open(struct inode *inode, struct file *file)
> static int i915_forcewake_release(struct inode *inode, struct file *file)
> {
> struct drm_i915_private *i915 = inode->i_private;
> - intel_gt_pm_debugfs_forcewake_user_release(to_gt(i915));
> + struct intel_gt *gt;
> + unsigned int i;
> +
> + for_each_gt(gt, i915, i)
> + intel_gt_pm_debugfs_forcewake_user_release(gt);
>
> return 0;
> }
^ permalink raw reply [flat|nested] 21+ messages in thread
end of thread, other threads:[~2023-03-17 11:26 UTC | newest]
Thread overview: 21+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-01 11:02 [PATCH v2 0/2] Some debugfs refactoring and improvements Andi Shyti
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
2023-03-01 11:02 ` [PATCH v2 1/2] drm/i915/gt: Create per-tile debugfs files Andi Shyti
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
2023-03-01 21:32 ` Sripada, Radhakrishna
2023-03-01 21:32 ` [Intel-gfx] " Sripada, Radhakrishna
2023-03-01 21:35 ` Sripada, Radhakrishna
2023-03-01 21:35 ` [Intel-gfx] " Sripada, Radhakrishna
2023-03-01 22:04 ` Andi Shyti
2023-03-01 22:04 ` [Intel-gfx] " Andi Shyti
2023-03-04 3:24 ` Andi Shyti
2023-03-04 3:24 ` [Intel-gfx] " Andi Shyti
2023-03-06 15:10 ` Sripada, Radhakrishna
2023-03-06 15:10 ` [Intel-gfx] " Sripada, Radhakrishna
2023-03-01 11:02 ` [PATCH v2 2/2] drm/i915/debugfs: Enable upper layer interfaces to act on all gt's Andi Shyti
2023-03-01 11:02 ` [Intel-gfx] " Andi Shyti
2023-03-17 11:26 ` Das, Nirmoy
2023-03-17 11:26 ` [Intel-gfx] " Das, Nirmoy
2023-03-01 18:57 ` [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Some debugfs refactoring and improvements Patchwork
2023-03-01 19:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2023-03-03 15:01 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.