[LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)

[LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)

[Petr Vorel]

-i0 is helpful to test if setup and cleanup are working.
We suggest that in maintainer-patch-review-checklist.txt.

Fixes: 4c0465f217 ("lib: Replace atoi/atof with SAFE_STRTOL/SAFE_STRTOF")

Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
 lib/tst_test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/tst_test.c b/lib/tst_test.c
index 23d21c8255..04d6b13bfc 100644
--- a/lib/tst_test.c
+++ b/lib/tst_test.c
@@ -678,7 +678,7 @@ static void parse_opts(int argc, char *argv[])
 			print_test_tags();
 			exit(0);
 		case 'i':
-			iterations = SAFE_STRTOL(optarg, 1, INT_MAX);
+			iterations = SAFE_STRTOL(optarg, 0, INT_MAX);
 		break;
 		case 'I':
 			if (tst_test->max_runtime > 0)
-- 
2.39.1


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)

[Avinesh Kumar]

Hi,

Reviewed-by: Avinesh Kumar <akumar@suse.de>

On Monday, February 6, 2023 11:40:01 AM IST Petr Vorel wrote:
> -i0 is helpful to test if setup and cleanup are working.
> We suggest that in maintainer-patch-review-checklist.txt.
> 
> Fixes: 4c0465f217 ("lib: Replace atoi/atof with SAFE_STRTOL/SAFE_STRTOF")
> 
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
>  lib/tst_test.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/tst_test.c b/lib/tst_test.c
> index 23d21c8255..04d6b13bfc 100644
> --- a/lib/tst_test.c
> +++ b/lib/tst_test.c
> @@ -678,7 +678,7 @@ static void parse_opts(int argc, char *argv[])
>  			print_test_tags();
>  			exit(0);
>  		case 'i':
> -			iterations = SAFE_STRTOL(optarg, 1, INT_MAX);
> +			iterations = SAFE_STRTOL(optarg, 0, INT_MAX);
>  		break;
>  		case 'I':
>  			if (tst_test->max_runtime > 0)
> 

Regards,
Avinesh



-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)

[Jan Stancek]

On Mon, Feb 6, 2023 at 7:10 AM Petr Vorel <pvorel@suse.cz> wrote:
>
> -i0 is helpful to test if setup and cleanup are working.
> We suggest that in maintainer-patch-review-checklist.txt.

Until now, I never thought of trying -i0 :-)

Acked-by: Jan Stancek <jstancek@redhat.com>


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

Re: [LTP] [PATCH 1/1] lib: Allow zero iterations (-i0)

[Petr Vorel]

Hi all,

thanks a lot, merged!

> On Mon, Feb 6, 2023 at 7:10 AM Petr Vorel <pvorel@suse.cz> wrote:

> > -i0 is helpful to test if setup and cleanup are working.
> > We suggest that in maintainer-patch-review-checklist.txt.

> Until now, I never thought of trying -i0 :-)

Credit goes to Martin Doucha, who let me know some time ago.

Kind regards,
Petr

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp