[PATCH] test: bootdev: Do not require USB to compile test

[PATCH] test: bootdev: Do not require USB to compile test

[Linus Walleij]

This test will block compilation of the entire test suite
on platforms without USB support. Make the extern
"usb_started" conditional on USB host or gadget and
define a dummy flag if neither is enabled.

Cc: Simon Glass <sjg@chromium.org>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 test/boot/bootdev.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/test/boot/bootdev.c b/test/boot/bootdev.c
index 1c2a79fb1084..fa466b708184 100644
--- a/test/boot/bootdev.c
+++ b/test/boot/bootdev.c
@@ -18,7 +18,11 @@
 #include "bootstd_common.h"
 
 /* Allow reseting the USB-started flag */
+#if defined(CONFIG_USB_HOST) || defined(CONFIG_USB_GADGET)
 extern char usb_started;
+#else
+char usb_started;
+#endif
 
 /* Check 'bootdev list' command */
 static int bootdev_test_cmd_list(struct unit_test_state *uts)
-- 
2.39.0

Re: [PATCH] test: bootdev: Do not require USB to compile test

[Simon Glass]

On Mon, 23 Jan 2023 at 15:07, Linus Walleij <linus.walleij@linaro.org> wrote:
>
> This test will block compilation of the entire test suite
> on platforms without USB support. Make the extern
> "usb_started" conditional on USB host or gadget and
> define a dummy flag if neither is enabled.
>
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> ---
>  test/boot/bootdev.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Simon Glass <sjg@chromium.org>

Re: [PATCH] test: bootdev: Do not require USB to compile test

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 478 bytes --]

On Mon, Jan 23, 2023 at 11:07:21PM +0100, Linus Walleij wrote:

> This test will block compilation of the entire test suite
> on platforms without USB support. Make the extern
> "usb_started" conditional on USB host or gadget and
> define a dummy flag if neither is enabled.
> 
> Cc: Simon Glass <sjg@chromium.org>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> Reviewed-by: Simon Glass <sjg@chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]