From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Tyler Hicks <code@tyhicks.com>,
ecryptfs@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko@kernel.org>,
keyrings@vger.kernel.org
Subject: Re: [PATCH 0/17] crypto: api - Change completion callback argument to void star
Date: Wed, 8 Feb 2023 12:02:13 +0800 [thread overview]
Message-ID: <Y+MexdOj12Y5Ikj1@gondor.apana.org.au> (raw)
In-Reply-To: <20230207105146.267fc5e8@kernel.org>
On Tue, Feb 07, 2023 at 10:51:46AM -0800, Jakub Kicinski wrote:
.
> Any aes-gcm or chacha-poly implementations which would do that come
> to mind? I'm asking 'cause we probably want to do stable if we know
> of a combination which would be broken, or the chances of one existing
> are high.
Good point. I had a quick look at tls_sw.c and it *appears* to be
safe with the default software code. As tls_sw only uses the generic
AEAD algorithms (rather than the IPsec-specific variants which aren't
safe), the software-only paths *should* be OK.
However, drivers that support these algorithms may require fallbacks
for esoteric reasons. For example, drivers/crypto/amcc appears to
require a fallback for certain input parameters which may or may not
be possible with TLS.
To be on the safe side I would do a backport once this has been
in mainline for a little bit.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: David Howells <dhowells@redhat.com>,
dm-devel@redhat.com, keyrings@vger.kernel.org,
Alasdair Kergon <agk@redhat.com>,
Steffen Klassert <steffen.klassert@secunet.com>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Tyler Hicks <code@tyhicks.com>, Paolo Abeni <pabeni@redhat.com>,
Johan Hedberg <johan.hedberg@gmail.com>,
Marcel Holtmann <marcel@holtmann.org>,
ecryptfs@vger.kernel.org, Mike Snitzer <snitzer@kernel.org>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
netdev@vger.kernel.org, Eric Dumazet <edumazet@google.com>,
Jon Maloy <jmaloy@redhat.com>,
linux-bluetooth@vger.kernel.org,
Jarkko Sakkinen <jarkko@kernel.org>,
Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Ying Xue <ying.xue@windriver.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [dm-devel] [PATCH 0/17] crypto: api - Change completion callback argument to void star
Date: Wed, 8 Feb 2023 12:02:13 +0800 [thread overview]
Message-ID: <Y+MexdOj12Y5Ikj1@gondor.apana.org.au> (raw)
In-Reply-To: <20230207105146.267fc5e8@kernel.org>
On Tue, Feb 07, 2023 at 10:51:46AM -0800, Jakub Kicinski wrote:
.
> Any aes-gcm or chacha-poly implementations which would do that come
> to mind? I'm asking 'cause we probably want to do stable if we know
> of a combination which would be broken, or the chances of one existing
> are high.
Good point. I had a quick look at tls_sw.c and it *appears* to be
safe with the default software code. As tls_sw only uses the generic
AEAD algorithms (rather than the IPsec-specific variants which aren't
safe), the software-only paths *should* be OK.
However, drivers that support these algorithms may require fallbacks
for esoteric reasons. For example, drivers/crypto/amcc appears to
require a fallback for certain input parameters which may or may not
be possible with TLS.
To be on the safe side I would do a backport once this has been
in mainline for a little bit.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
dm-devel mailing list
dm-devel@redhat.com
https://listman.redhat.com/mailman/listinfo/dm-devel
WARNING: multiple messages have this Message-ID (diff)
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Linux Crypto Mailing List <linux-crypto@vger.kernel.org>,
Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@kernel.org>,
dm-devel@redhat.com, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, Tyler Hicks <code@tyhicks.com>,
ecryptfs@vger.kernel.org, Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
linux-bluetooth@vger.kernel.org,
Steffen Klassert <steffen.klassert@secunet.com>,
Jon Maloy <jmaloy@redhat.com>, Ying Xue <ying.xue@windriver.com>,
Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
David Howells <dhowells@redhat.com>,
Jarkko Sakkinen <jarkko@kerne>
Subject: Re: [PATCH 0/17] crypto: api - Change completion callback argument to void star
Date: Wed, 8 Feb 2023 12:02:13 +0800 [thread overview]
Message-ID: <Y+MexdOj12Y5Ikj1@gondor.apana.org.au> (raw)
In-Reply-To: <20230207105146.267fc5e8@kernel.org>
On Tue, Feb 07, 2023 at 10:51:46AM -0800, Jakub Kicinski wrote:
.
> Any aes-gcm or chacha-poly implementations which would do that come
> to mind? I'm asking 'cause we probably want to do stable if we know
> of a combination which would be broken, or the chances of one existing
> are high.
Good point. I had a quick look at tls_sw.c and it *appears* to be
safe with the default software code. As tls_sw only uses the generic
AEAD algorithms (rather than the IPsec-specific variants which aren't
safe), the software-only paths *should* be OK.
However, drivers that support these algorithms may require fallbacks
for esoteric reasons. For example, drivers/crypto/amcc appears to
require a fallback for certain input parameters which may or may not
be possible with TLS.
To be on the safe side I would do a backport once this has been
in mainline for a little bit.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2023-02-08 4:02 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-06 10:21 [dm-devel] [PATCH 0/17] crypto: api - Change completion callback argument to void star Herbert Xu
2023-02-06 10:21 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 1/17] dm: Add scaffolding to change completion function signature Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 12:23 ` crypto: api - Change completion callback argument to void star bluez.test.bot
2023-02-06 17:29 ` [PATCH 1/17] dm: Add scaffolding to change completion function signature Mike Snitzer
2023-02-06 17:29 ` Mike Snitzer
2023-02-06 17:29 ` [dm-devel] " Mike Snitzer
2023-02-06 10:22 ` [dm-devel] [PATCH 2/17] net: macsec: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-10 0:43 ` Jarkko Sakkinen
2023-02-10 0:43 ` Jarkko Sakkinen
2023-02-10 0:43 ` [dm-devel] " Jarkko Sakkinen
2023-02-06 10:22 ` [dm-devel] [PATCH 3/17] fs: ecryptfs: Use crypto_wait_req Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-10 0:42 ` Jarkko Sakkinen
2023-02-10 0:42 ` Jarkko Sakkinen
2023-02-10 0:42 ` [dm-devel] " Jarkko Sakkinen
2023-02-06 10:22 ` [dm-devel] [PATCH 4/17] Bluetooth: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 5/17] net: ipv4: Add scaffolding to change completion function signature Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 6/17] net: ipv6: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 7/17] tipc: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 8/17] tls: Only use data field in crypto completion function Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-07 7:15 ` Jakub Kicinski
2023-02-07 7:15 ` Jakub Kicinski
2023-02-07 7:15 ` [dm-devel] " Jakub Kicinski
2023-02-07 8:18 ` [PATCH] tls: Pass rec instead of aead_req into tls_encrypt_done Herbert Xu
2023-02-07 8:18 ` Herbert Xu
2023-02-07 8:18 ` [dm-devel] " Herbert Xu
2023-02-07 8:41 ` bluez.test.bot
2023-02-07 18:50 ` [PATCH] " Jakub Kicinski
2023-02-07 18:50 ` Jakub Kicinski
2023-02-07 18:50 ` [dm-devel] " Jakub Kicinski
2023-02-06 10:22 ` [dm-devel] [PATCH 9/17] KEYS: DH: Use crypto_wait_req Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 10/17] crypto: api - Use data directly in completion function Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-08 5:58 ` [v2 PATCH " Herbert Xu
2023-02-08 5:58 ` Herbert Xu
2023-02-08 5:58 ` [dm-devel] " Herbert Xu
2023-02-08 6:17 ` [v2,10/17] " bluez.test.bot
2023-02-06 10:22 ` [dm-devel] [PATCH 11/17] dm: Remove completion function scaffolding Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 17:29 ` Mike Snitzer
2023-02-06 17:29 ` Mike Snitzer
2023-02-06 17:29 ` [dm-devel] " Mike Snitzer
2023-02-06 10:22 ` [dm-devel] [PATCH 12/17] net: macsec: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 13/17] net: ipv4: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 14/17] net: ipv6: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 15/17] tipc: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 16/17] tls: " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-06 10:22 ` [dm-devel] [PATCH 17/17] crypto: api - " Herbert Xu
2023-02-06 10:22 ` Herbert Xu
2023-02-10 0:56 ` Jarkko Sakkinen
2023-02-10 0:56 ` Jarkko Sakkinen
2023-02-10 0:56 ` [dm-devel] " Jarkko Sakkinen
2023-02-07 7:10 ` [PATCH 0/17] crypto: api - Change completion callback argument to void star Jakub Kicinski
2023-02-07 7:10 ` Jakub Kicinski
2023-02-07 7:10 ` [dm-devel] " Jakub Kicinski
2023-02-07 7:16 ` Jakub Kicinski
2023-02-07 7:16 ` Jakub Kicinski
2023-02-07 7:16 ` [dm-devel] " Jakub Kicinski
2023-02-07 8:03 ` Herbert Xu
2023-02-07 8:03 ` Herbert Xu
2023-02-07 8:03 ` [dm-devel] " Herbert Xu
2023-02-07 18:51 ` Jakub Kicinski
2023-02-07 18:51 ` Jakub Kicinski
2023-02-07 18:51 ` [dm-devel] " Jakub Kicinski
2023-02-08 4:02 ` Herbert Xu [this message]
2023-02-08 4:02 ` Herbert Xu
2023-02-08 4:02 ` [dm-devel] " Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y+MexdOj12Y5Ikj1@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=agk@redhat.com \
--cc=borisp@nvidia.com \
--cc=code@tyhicks.com \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dm-devel@redhat.com \
--cc=ecryptfs@vger.kernel.org \
--cc=edumazet@google.com \
--cc=jarkko@kernel.org \
--cc=jmaloy@redhat.com \
--cc=johan.hedberg@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=keyrings@vger.kernel.org \
--cc=kuba@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-crypto@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=snitzer@kernel.org \
--cc=steffen.klassert@secunet.com \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.