* [PATCH v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader
@ 2023-02-08 16:50 Mark Pearson
2023-02-08 17:01 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Mark Pearson @ 2023-02-08 16:50 UTC (permalink / raw)
To: mpearson-lenovo; +Cc: linux-usb, Miroslav Zatko, Dennis Wassenberg, stable
The Alcor Link AK9563 smartcard reader used on some Lenovo platforms
doesn't work. If LPM is enabled the reader will provide an invalid
usb config descriptor. Added quirk to disable LPM.
Verified fix on Lenovo P16 G1 and T14 G3
Tested-by: Miroslav Zatko <mzatko@mirexoft.com>
Tested-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
Cc: stable@vger.kernel.org
Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
---
Changes in v2: Put entry in correct position in quirks list.
drivers/usb/core/quirks.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c
index 079e183cf3bf..9b1c56646ac5 100644
--- a/drivers/usb/core/quirks.c
+++ b/drivers/usb/core/quirks.c
@@ -535,6 +535,9 @@ static const struct usb_device_id usb_quirk_list[] = {
/* INTEL VALUE SSD */
{ USB_DEVICE(0x8086, 0xf1a5), .driver_info = USB_QUIRK_RESET_RESUME },
+ /* Alcor Link AK9563 SC Reader used in 2022 Lenovo ThinkPads */
+ { USB_DEVICE(0x2ce3, 0x9563), .driver_info = USB_QUIRK_NO_LPM },
+
{ } /* terminating entry must be last */
};
--
2.39.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader
2023-02-08 16:50 [PATCH v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader Mark Pearson
@ 2023-02-08 17:01 ` Greg KH
2023-02-08 18:09 ` Mark Pearson
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2023-02-08 17:01 UTC (permalink / raw)
To: Mark Pearson; +Cc: linux-usb, Miroslav Zatko, Dennis Wassenberg, stable
On Wed, Feb 08, 2023 at 11:50:18AM -0500, Mark Pearson wrote:
> The Alcor Link AK9563 smartcard reader used on some Lenovo platforms
> doesn't work. If LPM is enabled the reader will provide an invalid
> usb config descriptor. Added quirk to disable LPM.
>
> Verified fix on Lenovo P16 G1 and T14 G3
>
> Tested-by: Miroslav Zatko <mzatko@mirexoft.com>
> Tested-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> Cc: stable@vger.kernel.org
>
Blank line still not needed :(
> Signed-off-by: Dennis Wassenberg <dennis.wassenberg@secunet.com>
> Signed-off-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> ---
> Changes in v2: Put entry in correct position in quirks list.
Still in the incorrect place :(
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader
2023-02-08 17:01 ` Greg KH
@ 2023-02-08 18:09 ` Mark Pearson
0 siblings, 0 replies; 3+ messages in thread
From: Mark Pearson @ 2023-02-08 18:09 UTC (permalink / raw)
To: Greg KH; +Cc: linux-usb, Miroslav Zaťko, Dennis Wassenberg, stable
> > Changes in v2: Put entry in correct position in quirks list.
>
> Still in the incorrect place :(
>
I'm an idiot - I sent the wrong file. Really sorry. Gah.
Third time lucky coming up..
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-08 18:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 16:50 [PATCH v2] usb: core: add quirk for Alcor Link AK9563 smartcard reader Mark Pearson
2023-02-08 17:01 ` Greg KH
2023-02-08 18:09 ` Mark Pearson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.