* [PATCH] xfs_io: fix bmap command not detecting realtime files with xattrs
@ 2023-02-09 2:38 ` Darrick J. Wong
2023-02-14 8:17 ` Christoph Hellwig
2023-02-22 8:28 ` Carlos Maiolino
0 siblings, 2 replies; 3+ messages in thread
From: Darrick J. Wong @ 2023-02-09 2:38 UTC (permalink / raw)
To: Carlos Maiolino; +Cc: xfs
From: Darrick J. Wong <djwong@kernel.org>
Fix the bmap command so that it will detect a realtime file if any of
the other file flags (e.g. xattrs) are set. Observed via xfs/556.
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
io/bmap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/io/bmap.c b/io/bmap.c
index a78e0c65440..11bbc0629cf 100644
--- a/io/bmap.c
+++ b/io/bmap.c
@@ -118,7 +118,7 @@ bmap_f(
return 0;
}
- if (fsx.fsx_xflags == FS_XFLAG_REALTIME) {
+ if (fsx.fsx_xflags & FS_XFLAG_REALTIME) {
/*
* ag info not applicable to rt, continue
* without ag output.
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_io: fix bmap command not detecting realtime files with xattrs
2023-02-09 2:38 ` [PATCH] xfs_io: fix bmap command not detecting realtime files with xattrs Darrick J. Wong
@ 2023-02-14 8:17 ` Christoph Hellwig
2023-02-22 8:28 ` Carlos Maiolino
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2023-02-14 8:17 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: Carlos Maiolino, xfs
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfs_io: fix bmap command not detecting realtime files with xattrs
2023-02-09 2:38 ` [PATCH] xfs_io: fix bmap command not detecting realtime files with xattrs Darrick J. Wong
2023-02-14 8:17 ` Christoph Hellwig
@ 2023-02-22 8:28 ` Carlos Maiolino
1 sibling, 0 replies; 3+ messages in thread
From: Carlos Maiolino @ 2023-02-22 8:28 UTC (permalink / raw)
To: Darrick J. Wong; +Cc: xfs
On Wed, Feb 08, 2023 at 06:38:48PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Fix the bmap command so that it will detect a realtime file if any of
> the other file flags (e.g. xattrs) are set. Observed via xfs/556.
>
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Looks good to me.
Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
> ---
> io/bmap.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/io/bmap.c b/io/bmap.c
> index a78e0c65440..11bbc0629cf 100644
> --- a/io/bmap.c
> +++ b/io/bmap.c
> @@ -118,7 +118,7 @@ bmap_f(
> return 0;
> }
>
> - if (fsx.fsx_xflags == FS_XFLAG_REALTIME) {
> + if (fsx.fsx_xflags & FS_XFLAG_REALTIME) {
> /*
> * ag info not applicable to rt, continue
> * without ag output.
--
Carlos Maiolino
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-02-22 8:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <yL-h_t2gPiyfv73J3Z4afr1fJFRLUKiKhKGx_rzDVHutzfEKbidpVNAfQcHs8nXQu7co8H6Fiv35lVnuxAKhwA==@protonmail.internalid>
2023-02-09 2:38 ` [PATCH] xfs_io: fix bmap command not detecting realtime files with xattrs Darrick J. Wong
2023-02-14 8:17 ` Christoph Hellwig
2023-02-22 8:28 ` Carlos Maiolino
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.