* [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0
@ 2023-02-08 12:27 Bhupesh Sharma
2023-02-09 4:22 ` Bjorn Andersson
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Bhupesh Sharma @ 2023-02-08 12:27 UTC (permalink / raw)
To: linux-arm-msm
Cc: agross, andersson, konrad.dybcio, linux-kernel, bhupesh.linux,
bhupesh.sharma, robh+dt, devicetree
qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart.
Add the debug uart node in sm6115 dtsi file.
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Rob Herring <robh+dt@kernel.org>
Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
---
Changes since v1:
- v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20221128171215.1768745-1-bhupesh.sharma@linaro.org/
- Addressed Konrad's review comments on v1.
- Rebased againt latest linux-next/master which now has the 'qupv3_id_0' node
already in the dtsi file, so just add the debug uart node in v2.
arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
index 50cb8a82ecd5..3eccfb8c16ce 100644
--- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
@@ -963,6 +963,15 @@ spi4: spi@4a90000 {
status = "disabled";
};
+ uart4: serial@4a90000 {
+ compatible = "qcom,geni-debug-uart";
+ reg = <0x04a90000 0x4000>;
+ clock-names = "se";
+ clocks = <&gcc GCC_QUPV3_WRAP0_S4_CLK>;
+ interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
+ status = "disabled";
+ };
+
i2c5: i2c@4a94000 {
compatible = "qcom,geni-i2c";
reg = <0x04a94000 0x4000>;
@@ -992,7 +1001,6 @@ spi5: spi@4a94000 {
dma-names = "tx", "rx";
#address-cells = <1>;
#size-cells = <0>;
- status = "disabled";
};
};
--
2.38.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0
2023-02-08 12:27 [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0 Bhupesh Sharma
@ 2023-02-09 4:22 ` Bjorn Andersson
2023-02-09 15:11 ` Krzysztof Kozlowski
2023-02-09 16:21 ` Matthias Kaehlcke
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2023-02-09 4:22 UTC (permalink / raw)
To: Bhupesh Sharma, linux-arm-msm
Cc: konrad.dybcio, agross, devicetree, robh+dt, linux-kernel, bhupesh.linux
On Wed, 8 Feb 2023 17:57:18 +0530, Bhupesh Sharma wrote:
> qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart.
> Add the debug uart node in sm6115 dtsi file.
>
>
Applied, thanks!
[1/1] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0
commit: 25aab0b852d63784586ed99148d9af37a820a0c8
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0
2023-02-08 12:27 [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0 Bhupesh Sharma
2023-02-09 4:22 ` Bjorn Andersson
@ 2023-02-09 15:11 ` Krzysztof Kozlowski
2023-02-09 16:00 ` Krzysztof Kozlowski
2023-02-09 16:21 ` Matthias Kaehlcke
2 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 15:11 UTC (permalink / raw)
To: Bhupesh Sharma, linux-arm-msm
Cc: agross, andersson, konrad.dybcio, linux-kernel, bhupesh.linux,
robh+dt, devicetree
On 08/02/2023 13:27, Bhupesh Sharma wrote:
> qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart.
> Add the debug uart node in sm6115 dtsi file.
>
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> Changes since v1:
> - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20221128171215.1768745-1-bhupesh.sharma@linaro.org/
> - Addressed Konrad's review comments on v1.
> - Rebased againt latest linux-next/master which now has the 'qupv3_id_0' node
> already in the dtsi file, so just add the debug uart node in v2.
>
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 50cb8a82ecd5..3eccfb8c16ce 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -963,6 +963,15 @@ spi4: spi@4a90000 {
> status = "disabled";
> };
>
> + uart4: serial@4a90000 {
> + compatible = "qcom,geni-debug-uart";
> + reg = <0x04a90000 0x4000>;
> + clock-names = "se";
> + clocks = <&gcc GCC_QUPV3_WRAP0_S4_CLK>;
> + interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
> i2c5: i2c@4a94000 {
> compatible = "qcom,geni-i2c";
> reg = <0x04a94000 0x4000>;
> @@ -992,7 +1001,6 @@ spi5: spi@4a94000 {
> dma-names = "tx", "rx";
> #address-cells = <1>;
> #size-cells = <0>;
> - status = "disabled";
Why do you enable SPI? The commit msg is not explaining it.
Best regards
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0
2023-02-09 15:11 ` Krzysztof Kozlowski
@ 2023-02-09 16:00 ` Krzysztof Kozlowski
0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2023-02-09 16:00 UTC (permalink / raw)
To: Bhupesh Sharma, linux-arm-msm
Cc: agross, andersson, konrad.dybcio, linux-kernel, bhupesh.linux,
robh+dt, devicetree
On 09/02/2023 16:11, Krzysztof Kozlowski wrote:
> On 08/02/2023 13:27, Bhupesh Sharma wrote:
>> qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart.
>> Add the debug uart node in sm6115 dtsi file.
>>
>> Cc: Bjorn Andersson <andersson@kernel.org>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
>> ---
>> Changes since v1:
>> - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20221128171215.1768745-1-bhupesh.sharma@linaro.org/
>> - Addressed Konrad's review comments on v1.
>> - Rebased againt latest linux-next/master which now has the 'qupv3_id_0' node
>> already in the dtsi file, so just add the debug uart node in v2.
>>
>> arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 +++++++++-
>> 1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> index 50cb8a82ecd5..3eccfb8c16ce 100644
>> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
>> @@ -963,6 +963,15 @@ spi4: spi@4a90000 {
>> status = "disabled";
>> };
>>
>> + uart4: serial@4a90000 {
>> + compatible = "qcom,geni-debug-uart";
>> + reg = <0x04a90000 0x4000>;
>> + clock-names = "se";
>> + clocks = <&gcc GCC_QUPV3_WRAP0_S4_CLK>;
>> + interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
>> + status = "disabled";
>> + };
>> +
>> i2c5: i2c@4a94000 {
>> compatible = "qcom,geni-i2c";
>> reg = <0x04a94000 0x4000>;
>> @@ -992,7 +1001,6 @@ spi5: spi@4a94000 {
>> dma-names = "tx", "rx";
>> #address-cells = <1>;
>> #size-cells = <0>;
>> - status = "disabled";
>
> Why do you enable SPI? The commit msg is not explaining it.
Sent fixup:
https://lore.kernel.org/linux-arm-msm/20230209155831.100066-1-krzysztof.kozlowski@linaro.org/T/#u
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0
2023-02-08 12:27 [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0 Bhupesh Sharma
2023-02-09 4:22 ` Bjorn Andersson
2023-02-09 15:11 ` Krzysztof Kozlowski
@ 2023-02-09 16:21 ` Matthias Kaehlcke
2 siblings, 0 replies; 5+ messages in thread
From: Matthias Kaehlcke @ 2023-02-09 16:21 UTC (permalink / raw)
To: Bhupesh Sharma
Cc: linux-arm-msm, agross, andersson, konrad.dybcio, linux-kernel,
bhupesh.linux, robh+dt, devicetree
On Wed, Feb 08, 2023 at 05:57:18PM +0530, Bhupesh Sharma wrote:
> qup0 on sm6115 / sm4250 has 6 SEs, with SE4 as debug uart.
> Add the debug uart node in sm6115 dtsi file.
Is there anything special about SE4 that makes it *the* debug
UART or does it just happen to be the UART that is used by the
reference board? I suspect the latter, in which case the
"qcom,geni-debug-uart" string should be set/overwritten in the
board file as in sc7280-qcard.dtsi or sc8280xp-crd.dts.
> Cc: Bjorn Andersson <andersson@kernel.org>
> Cc: Rob Herring <robh+dt@kernel.org>
> Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> ---
> Changes since v1:
> - v1 can be viewed here: https://lore.kernel.org/linux-arm-msm/20221128171215.1768745-1-bhupesh.sharma@linaro.org/
> - Addressed Konrad's review comments on v1.
> - Rebased againt latest linux-next/master which now has the 'qupv3_id_0' node
> already in the dtsi file, so just add the debug uart node in v2.
>
> arch/arm64/boot/dts/qcom/sm6115.dtsi | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm6115.dtsi b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> index 50cb8a82ecd5..3eccfb8c16ce 100644
> --- a/arch/arm64/boot/dts/qcom/sm6115.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm6115.dtsi
> @@ -963,6 +963,15 @@ spi4: spi@4a90000 {
> status = "disabled";
> };
>
> + uart4: serial@4a90000 {
> + compatible = "qcom,geni-debug-uart";
> + reg = <0x04a90000 0x4000>;
> + clock-names = "se";
> + clocks = <&gcc GCC_QUPV3_WRAP0_S4_CLK>;
> + interrupts = <GIC_SPI 331 IRQ_TYPE_LEVEL_HIGH>;
> + status = "disabled";
> + };
> +
> i2c5: i2c@4a94000 {
> compatible = "qcom,geni-i2c";
> reg = <0x04a94000 0x4000>;
> @@ -992,7 +1001,6 @@ spi5: spi@4a94000 {
> dma-names = "tx", "rx";
> #address-cells = <1>;
> #size-cells = <0>;
> - status = "disabled";
> };
> };
>
> --
> 2.38.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-09 16:21 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-02-08 12:27 [PATCH v2] arm64: dts: qcom: sm6115: Add geni debug uart node for qup0 Bhupesh Sharma
2023-02-09 4:22 ` Bjorn Andersson
2023-02-09 15:11 ` Krzysztof Kozlowski
2023-02-09 16:00 ` Krzysztof Kozlowski
2023-02-09 16:21 ` Matthias Kaehlcke
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.