* [PATCH] kvm: vmx: keep constant definition format consistent
@ 2022-09-20 4:52 flyingpeng(彭浩)
2022-10-07 17:54 ` Sean Christopherson
0 siblings, 1 reply; 4+ messages in thread
From: flyingpeng(彭浩) @ 2022-09-20 4:52 UTC (permalink / raw)
To: pbonzini; +Cc: kvm
Keep all constants using lowercase "x".
Signed-off-by: Peng Hao <flyingpeng@tencent.com>
---
arch/x86/include/asm/vmx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 0ffaa3156a4e..d1791b612170 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -296,7 +296,7 @@ enum vmcs_field {
GUEST_LDTR_AR_BYTES = 0x00004820,
GUEST_TR_AR_BYTES = 0x00004822,
GUEST_INTERRUPTIBILITY_INFO = 0x00004824,
- GUEST_ACTIVITY_STATE = 0X00004826,
+ GUEST_ACTIVITY_STATE = 0x00004826,
GUEST_SYSENTER_CS = 0x0000482A,
VMX_PREEMPTION_TIMER_VALUE = 0x0000482E,
HOST_IA32_SYSENTER_CS = 0x00004c00,
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kvm: vmx: keep constant definition format consistent
2022-09-20 4:52 [PATCH] kvm: vmx: keep constant definition format consistent flyingpeng(彭浩)
@ 2022-10-07 17:54 ` Sean Christopherson
0 siblings, 0 replies; 4+ messages in thread
From: Sean Christopherson @ 2022-10-07 17:54 UTC (permalink / raw)
To: flyingpeng(彭浩); +Cc: pbonzini, kvm
On Tue, Sep 20, 2022, flyingpeng(彭浩) wrote:
> Keep all constants using lowercase "x".
>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
> arch/x86/include/asm/vmx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 0ffaa3156a4e..d1791b612170 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -296,7 +296,7 @@ enum vmcs_field {
> GUEST_LDTR_AR_BYTES = 0x00004820,
> GUEST_TR_AR_BYTES = 0x00004822,
> GUEST_INTERRUPTIBILITY_INFO = 0x00004824,
> - GUEST_ACTIVITY_STATE = 0X00004826,
> + GUEST_ACTIVITY_STATE = 0x00004826,
Heh, I'm somewhat surprised clang didn't throw an error on this.
Reviewed-by: Sean Christopherson <seanjc@google.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] kvm: vmx: keep constant definition format consistent
@ 2022-09-23 15:03 Hao Peng
2022-09-27 12:15 ` Paolo Bonzini
0 siblings, 1 reply; 4+ messages in thread
From: Hao Peng @ 2022-09-23 15:03 UTC (permalink / raw)
To: pbonzini; +Cc: kvm
From: Peng Hao <flyingpeng@tencent.com>
Keep all constants using lowercase "x".
Signed-off-by: Peng Hao <flyingpeng@tencent.com>
---
arch/x86/include/asm/vmx.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
index 0ffaa3156a4e..d1791b612170 100644
--- a/arch/x86/include/asm/vmx.h
+++ b/arch/x86/include/asm/vmx.h
@@ -296,7 +296,7 @@ enum vmcs_field {
GUEST_LDTR_AR_BYTES = 0x00004820,
GUEST_TR_AR_BYTES = 0x00004822,
GUEST_INTERRUPTIBILITY_INFO = 0x00004824,
- GUEST_ACTIVITY_STATE = 0X00004826,
+ GUEST_ACTIVITY_STATE = 0x00004826,
GUEST_SYSENTER_CS = 0x0000482A,
VMX_PREEMPTION_TIMER_VALUE = 0x0000482E,
HOST_IA32_SYSENTER_CS = 0x00004c00,
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] kvm: vmx: keep constant definition format consistent
2022-09-23 15:03 Hao Peng
@ 2022-09-27 12:15 ` Paolo Bonzini
0 siblings, 0 replies; 4+ messages in thread
From: Paolo Bonzini @ 2022-09-27 12:15 UTC (permalink / raw)
To: Hao Peng; +Cc: kvm
On 9/23/22 17:03, Hao Peng wrote:
> From: Peng Hao <flyingpeng@tencent.com>
> Keep all constants using lowercase "x".
>
> Signed-off-by: Peng Hao <flyingpeng@tencent.com>
> ---
> arch/x86/include/asm/vmx.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/vmx.h b/arch/x86/include/asm/vmx.h
> index 0ffaa3156a4e..d1791b612170 100644
> --- a/arch/x86/include/asm/vmx.h
> +++ b/arch/x86/include/asm/vmx.h
> @@ -296,7 +296,7 @@ enum vmcs_field {
> GUEST_LDTR_AR_BYTES = 0x00004820,
> GUEST_TR_AR_BYTES = 0x00004822,
> GUEST_INTERRUPTIBILITY_INFO = 0x00004824,
> - GUEST_ACTIVITY_STATE = 0X00004826,
> + GUEST_ACTIVITY_STATE = 0x00004826,
> GUEST_SYSENTER_CS = 0x0000482A,
> VMX_PREEMPTION_TIMER_VALUE = 0x0000482E,
> HOST_IA32_SYSENTER_CS = 0x00004c00,
> --
> 2.27.0
Queued, thanks.
Paolo
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-07 17:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 4:52 [PATCH] kvm: vmx: keep constant definition format consistent flyingpeng(彭浩)
2022-10-07 17:54 ` Sean Christopherson
2022-09-23 15:03 Hao Peng
2022-09-27 12:15 ` Paolo Bonzini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.