[PATCH -mm] -funsigned-char, namei: delete cast in lookup_one_common()

From: Alexey Dobriyan <adobriyan@gmail.com>
To: akpm@linux-foundation.org
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH -mm] -funsigned-char, namei: delete cast in lookup_one_common()
Date: Thu, 20 Oct 2022 12:56:20 +0300	[thread overview]
Message-ID: <Y1EbRNxRnZ/42G9x@localhost.localdomain> (raw)
In-Reply-To: <Y1EZuQcO8UoN91cX@localhost.localdomain>

Cast to unsigned int doesn't do anything because two comparisons are
a) for equality, and
b) both '/' and '\0' have non-negative values.

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
---

 fs/namei.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/fs/namei.c
+++ b/fs/namei.c
@@ -2657,7 +2657,7 @@ static int lookup_one_common(struct user_namespace *mnt_userns,
 	}
 
 	while (len--) {
-		unsigned int c = *(const unsigned char *)name++;
+		char c = *name++;
 		if (c == '/' || c == '\0')
 			return -EACCES;
 	}
