* cleaning commented code
@ 2022-10-20 22:59 Deepak R Varma
2022-10-21 5:03 ` Julia Lawall
0 siblings, 1 reply; 3+ messages in thread
From: Deepak R Varma @ 2022-10-20 22:59 UTC (permalink / raw)
To: outreachy
Hello,
Is there any guideline on cleaning commented code, specifically printk debug
messages that appears to be added for basis program flow tracing. If yes, will
this be treated as a clean up contribution?
e.g.
./wlan-ng/p80211netdev.c:884: /* printk("assocreq"); */
./wlan-ng/p80211netdev.c:888: /* printk("assocresp"); */
./wlan-ng/p80211netdev.c:892: /* printk("reassocreq"); */
./wlan-ng/p80211netdev.c:896: /* printk("reassocresp"); */
./wlan-ng/p80211netdev.c:900: /* printk("probereq"); */
./wlan-ng/p80211netdev.c:904: /* printk("proberesp"); */
Thank you,
./drv
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cleaning commented code
2022-10-21 5:03 ` Julia Lawall
@ 2022-10-20 23:36 ` Deepak R Varma
0 siblings, 0 replies; 3+ messages in thread
From: Deepak R Varma @ 2022-10-20 23:36 UTC (permalink / raw)
To: Julia Lawall; +Cc: outreachy
On Fri, Oct 21, 2022 at 07:03:00AM +0200, Julia Lawall wrote:
>
>
> On Fri, 21 Oct 2022, Deepak R Varma wrote:
>
> > Hello,
> > Is there any guideline on cleaning commented code, specifically printk debug
> > messages that appears to be added for basis program flow tracing. If yes, will
> > this be treated as a clean up contribution?
>
> You can remove commented code.
Thank you. Exploring making a patch for this clean up.
>
> Every change counts.
>
> julia
>
> >
> > e.g.
> >
> > ./wlan-ng/p80211netdev.c:884: /* printk("assocreq"); */
> > ./wlan-ng/p80211netdev.c:888: /* printk("assocresp"); */
> > ./wlan-ng/p80211netdev.c:892: /* printk("reassocreq"); */
> > ./wlan-ng/p80211netdev.c:896: /* printk("reassocresp"); */
> > ./wlan-ng/p80211netdev.c:900: /* printk("probereq"); */
> > ./wlan-ng/p80211netdev.c:904: /* printk("proberesp"); */
> >
> > Thank you,
> > ./drv
> >
> >
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: cleaning commented code
2022-10-20 22:59 cleaning commented code Deepak R Varma
@ 2022-10-21 5:03 ` Julia Lawall
2022-10-20 23:36 ` Deepak R Varma
0 siblings, 1 reply; 3+ messages in thread
From: Julia Lawall @ 2022-10-21 5:03 UTC (permalink / raw)
To: Deepak R Varma; +Cc: outreachy
On Fri, 21 Oct 2022, Deepak R Varma wrote:
> Hello,
> Is there any guideline on cleaning commented code, specifically printk debug
> messages that appears to be added for basis program flow tracing. If yes, will
> this be treated as a clean up contribution?
You can remove commented code.
Every change counts.
julia
>
> e.g.
>
> ./wlan-ng/p80211netdev.c:884: /* printk("assocreq"); */
> ./wlan-ng/p80211netdev.c:888: /* printk("assocresp"); */
> ./wlan-ng/p80211netdev.c:892: /* printk("reassocreq"); */
> ./wlan-ng/p80211netdev.c:896: /* printk("reassocresp"); */
> ./wlan-ng/p80211netdev.c:900: /* printk("probereq"); */
> ./wlan-ng/p80211netdev.c:904: /* printk("proberesp"); */
>
> Thank you,
> ./drv
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-10-21 8:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-20 22:59 cleaning commented code Deepak R Varma
2022-10-21 5:03 ` Julia Lawall
2022-10-20 23:36 ` Deepak R Varma
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.