All of lore.kernel.org
 help / color / mirror / Atom feed
* [net-next] phy: convert to boolean for the mac_managed_pm flag
@ 2022-10-27 15:05 Denis Kirjanov
  2022-10-27 17:36 ` Andrew Lunn
  2022-10-27 21:09 ` Heiner Kallweit
  0 siblings, 2 replies; 4+ messages in thread
From: Denis Kirjanov @ 2022-10-27 15:05 UTC (permalink / raw)
  To: netdev; +Cc: Jakub Kicinski, Joakim Zhang, Heiner Kallweit

Signed-off-by: Dennis Kirjanov <dkirjanov@suse.de>
---
 drivers/net/ethernet/freescale/fec_main.c | 2 +-
 drivers/net/ethernet/realtek/r8169_main.c | 2 +-
 drivers/net/usb/asix_devices.c            | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 98d5cd313fdd..4d38a297ec00 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -2226,7 +2226,7 @@ static int fec_enet_mii_probe(struct net_device *ndev)
 	fep->link = 0;
 	fep->full_duplex = 0;
 
-	phy_dev->mac_managed_pm = 1;
+	phy_dev->mac_managed_pm = true;
 
 	phy_attached_info(phy_dev);
 
diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
index a73d061d9fcb..5bc1181f829b 100644
--- a/drivers/net/ethernet/realtek/r8169_main.c
+++ b/drivers/net/ethernet/realtek/r8169_main.c
@@ -5018,7 +5018,7 @@ static int r8169_mdio_register(struct rtl8169_private *tp)
 		return -EUNATCH;
 	}
 
-	tp->phydev->mac_managed_pm = 1;
+	tp->phydev->mac_managed_pm = true;
 
 	phy_support_asym_pause(tp->phydev);
 
diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
index 11f60d32be82..02941d97d034 100644
--- a/drivers/net/usb/asix_devices.c
+++ b/drivers/net/usb/asix_devices.c
@@ -700,7 +700,7 @@ static int ax88772_init_phy(struct usbnet *dev)
 	}
 
 	phy_suspend(priv->phydev);
-	priv->phydev->mac_managed_pm = 1;
+	priv->phydev->mac_managed_pm = true;
 
 	phy_attached_info(priv->phydev);
 
@@ -720,7 +720,7 @@ static int ax88772_init_phy(struct usbnet *dev)
 		return -ENODEV;
 	}
 
-	priv->phydev_int->mac_managed_pm = 1;
+	priv->phydev_int->mac_managed_pm = true;
 	phy_suspend(priv->phydev_int);
 
 	return 0;
-- 
2.16.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [net-next] phy: convert to boolean for the mac_managed_pm flag
  2022-10-27 15:05 [net-next] phy: convert to boolean for the mac_managed_pm flag Denis Kirjanov
@ 2022-10-27 17:36 ` Andrew Lunn
  2022-10-27 21:09 ` Heiner Kallweit
  1 sibling, 0 replies; 4+ messages in thread
From: Andrew Lunn @ 2022-10-27 17:36 UTC (permalink / raw)
  To: Denis Kirjanov; +Cc: netdev, Jakub Kicinski, Joakim Zhang, Heiner Kallweit

On Thu, Oct 27, 2022 at 06:05:27PM +0300, Denis Kirjanov wrote:

The subject "[net-next] phy:" is not very helpful. You don't change
any generic PHYs, not network PHYs. "drivers: net " would be a better
prefix, it at least makes it clear it is touching multiple network
drivers.

The change itself is O.K.

    Andrew

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [net-next] phy: convert to boolean for the mac_managed_pm flag
  2022-10-27 15:05 [net-next] phy: convert to boolean for the mac_managed_pm flag Denis Kirjanov
  2022-10-27 17:36 ` Andrew Lunn
@ 2022-10-27 21:09 ` Heiner Kallweit
  2022-10-28 10:25   ` Denis Kirjanov
  1 sibling, 1 reply; 4+ messages in thread
From: Heiner Kallweit @ 2022-10-27 21:09 UTC (permalink / raw)
  To: Denis Kirjanov, netdev; +Cc: Jakub Kicinski, Joakim Zhang

On 27.10.2022 17:05, Denis Kirjanov wrote:
> Signed-off-by: Dennis Kirjanov <dkirjanov@suse.de>

Commit message is missing.
It should be "net: phy:" instead of "phy:".
You state that you convert the flag to boolean but you convert only the users.

> ---
>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>  drivers/net/ethernet/realtek/r8169_main.c | 2 +-
>  drivers/net/usb/asix_devices.c            | 4 ++--

This should be separate patches.

>  3 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 98d5cd313fdd..4d38a297ec00 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -2226,7 +2226,7 @@ static int fec_enet_mii_probe(struct net_device *ndev)
>  	fep->link = 0;
>  	fep->full_duplex = 0;
>  
> -	phy_dev->mac_managed_pm = 1;
> +	phy_dev->mac_managed_pm = true;
>  
Definition is: unsigned mac_managed_pm:1;
Therefore 1 is the correct value, why assigning a bool to a bitfield member?

>  	phy_attached_info(phy_dev);
>  
> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index a73d061d9fcb..5bc1181f829b 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c
> @@ -5018,7 +5018,7 @@ static int r8169_mdio_register(struct rtl8169_private *tp)
>  		return -EUNATCH;
>  	}
>  
> -	tp->phydev->mac_managed_pm = 1;
> +	tp->phydev->mac_managed_pm = true;
>  
>  	phy_support_asym_pause(tp->phydev);
>  
> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
> index 11f60d32be82..02941d97d034 100644
> --- a/drivers/net/usb/asix_devices.c
> +++ b/drivers/net/usb/asix_devices.c
> @@ -700,7 +700,7 @@ static int ax88772_init_phy(struct usbnet *dev)
>  	}
>  
>  	phy_suspend(priv->phydev);
> -	priv->phydev->mac_managed_pm = 1;
> +	priv->phydev->mac_managed_pm = true;
>  
>  	phy_attached_info(priv->phydev);
>  
> @@ -720,7 +720,7 @@ static int ax88772_init_phy(struct usbnet *dev)
>  		return -ENODEV;
>  	}
>  
> -	priv->phydev_int->mac_managed_pm = 1;
> +	priv->phydev_int->mac_managed_pm = true;
>  	phy_suspend(priv->phydev_int);
>  
>  	return 0;


^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [net-next] phy: convert to boolean for the mac_managed_pm flag
  2022-10-27 21:09 ` Heiner Kallweit
@ 2022-10-28 10:25   ` Denis Kirjanov
  0 siblings, 0 replies; 4+ messages in thread
From: Denis Kirjanov @ 2022-10-28 10:25 UTC (permalink / raw)
  To: Heiner Kallweit, netdev; +Cc: Jakub Kicinski, Joakim Zhang



On 10/28/22 00:09, Heiner Kallweit wrote:
> On 27.10.2022 17:05, Denis Kirjanov wrote:
>> Signed-off-by: Dennis Kirjanov <dkirjanov@suse.de>
> 
> Commit message is missing.
> It should be "net: phy:" instead of "phy:".
> You state that you convert the flag to boolean but you convert only the users.

Yes, I've sent a v2. I've converted the flag to make it consistent across the users 

> 
>> ---
>>  drivers/net/ethernet/freescale/fec_main.c | 2 +-
>>  drivers/net/ethernet/realtek/r8169_main.c | 2 +-
>>  drivers/net/usb/asix_devices.c            | 4 ++--
> 
> This should be separate patches.
> 
>>  3 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
>> index 98d5cd313fdd..4d38a297ec00 100644
>> --- a/drivers/net/ethernet/freescale/fec_main.c
>> +++ b/drivers/net/ethernet/freescale/fec_main.c
>> @@ -2226,7 +2226,7 @@ static int fec_enet_mii_probe(struct net_device *ndev)
>>  	fep->link = 0;
>>  	fep->full_duplex = 0;
>>  
>> -	phy_dev->mac_managed_pm = 1;
>> +	phy_dev->mac_managed_pm = true;
>>  
> Definition is: unsigned mac_managed_pm:1;
> Therefore 1 is the correct value, why assigning a bool to a bitfield member?
> 
>>  	phy_attached_info(phy_dev);
>>  
>> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
>> index a73d061d9fcb..5bc1181f829b 100644
>> --- a/drivers/net/ethernet/realtek/r8169_main.c
>> +++ b/drivers/net/ethernet/realtek/r8169_main.c
>> @@ -5018,7 +5018,7 @@ static int r8169_mdio_register(struct rtl8169_private *tp)
>>  		return -EUNATCH;
>>  	}
>>  
>> -	tp->phydev->mac_managed_pm = 1;
>> +	tp->phydev->mac_managed_pm = true;
>>  
>>  	phy_support_asym_pause(tp->phydev);
>>  
>> diff --git a/drivers/net/usb/asix_devices.c b/drivers/net/usb/asix_devices.c
>> index 11f60d32be82..02941d97d034 100644
>> --- a/drivers/net/usb/asix_devices.c
>> +++ b/drivers/net/usb/asix_devices.c
>> @@ -700,7 +700,7 @@ static int ax88772_init_phy(struct usbnet *dev)
>>  	}
>>  
>>  	phy_suspend(priv->phydev);
>> -	priv->phydev->mac_managed_pm = 1;
>> +	priv->phydev->mac_managed_pm = true;
>>  
>>  	phy_attached_info(priv->phydev);
>>  
>> @@ -720,7 +720,7 @@ static int ax88772_init_phy(struct usbnet *dev)
>>  		return -ENODEV;
>>  	}
>>  
>> -	priv->phydev_int->mac_managed_pm = 1;
>> +	priv->phydev_int->mac_managed_pm = true;
>>  	phy_suspend(priv->phydev_int);
>>  
>>  	return 0;
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-10-28 10:25 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-27 15:05 [net-next] phy: convert to boolean for the mac_managed_pm flag Denis Kirjanov
2022-10-27 17:36 ` Andrew Lunn
2022-10-27 21:09 ` Heiner Kallweit
2022-10-28 10:25   ` Denis Kirjanov

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.