From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Kees Cook <keescook@chromium.org>,
Alex Deucher <alexander.deucher@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Hans de Goede <hdegoede@redhat.com>,
Grigory Vasilyev <h0tc0d3@gmail.com>,
Claudio Suarez <cssk@net-c.es>, Slark Xiao <slark_xiao@163.com>,
Rongguang Wei <weirongguang@kylinos.cn>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: Re: [PATCH] [next] drm/amdgpu: Replace one-element array with flexible-array member
Date: Sat, 29 Oct 2022 13:43:30 +1300 [thread overview]
Message-ID: <Y1x3MtRJ8ckXxlJn@mail.google.com> (raw)
In-Reply-To: <1052fba8-11ac-cec8-92e7-b994266c6970@amd.com>
On Fri, Oct 28, 2022 at 07:33:17PM +0200, Christian König wrote:
> Am 28.10.22 um 18:36 schrieb Kees Cook:
>
> > All that said, converting away from them can be tricky, and I think such
> > conversions need to explicitly show how they were checked for binary
> > differences[2].
>
> Oh, that's a great idea! Yes, if this can be guaranteed then the change is
> obviously perfectly ok.
>
> >
> > Paulo, can you please check for deltas and report your findings in the
> > commit log? Note that add struct_size() use in the same patch may result
> > in binary differences, so for more complex cases, you may want to split
> > the 1-element conversion from the struct_size() conversions.
> >
> > -Kees
Noted. I will reporting my findings on commit logs from now onwards.
Given that I split the if-ternary to avoid checking "fake_edid_record->ucFakeEDIDLength"
twice then (for the current patch), yes, there will be changes to *.o|ko files.
Knowing that Christian would feel more confident with no binary changes
at this point, I will send a different patch aiming solely on the
replacement of 1-elem array without incurring binary changes.
--
Paulo A.
WARNING: multiple messages have this Message-ID (diff)
From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Kees Cook <keescook@chromium.org>,
Grigory Vasilyev <h0tc0d3@gmail.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Slark Xiao <slark_xiao@163.com>,
Hans de Goede <hdegoede@redhat.com>,
Claudio Suarez <cssk@net-c.es>,
dri-devel@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Rongguang Wei <weirongguang@kylinos.cn>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] [next] drm/amdgpu: Replace one-element array with flexible-array member
Date: Sat, 29 Oct 2022 13:43:30 +1300 [thread overview]
Message-ID: <Y1x3MtRJ8ckXxlJn@mail.google.com> (raw)
In-Reply-To: <1052fba8-11ac-cec8-92e7-b994266c6970@amd.com>
On Fri, Oct 28, 2022 at 07:33:17PM +0200, Christian König wrote:
> Am 28.10.22 um 18:36 schrieb Kees Cook:
>
> > All that said, converting away from them can be tricky, and I think such
> > conversions need to explicitly show how they were checked for binary
> > differences[2].
>
> Oh, that's a great idea! Yes, if this can be guaranteed then the change is
> obviously perfectly ok.
>
> >
> > Paulo, can you please check for deltas and report your findings in the
> > commit log? Note that add struct_size() use in the same patch may result
> > in binary differences, so for more complex cases, you may want to split
> > the 1-element conversion from the struct_size() conversions.
> >
> > -Kees
Noted. I will reporting my findings on commit logs from now onwards.
Given that I split the if-ternary to avoid checking "fake_edid_record->ucFakeEDIDLength"
twice then (for the current patch), yes, there will be changes to *.o|ko files.
Knowing that Christian would feel more confident with no binary changes
at this point, I will send a different patch aiming solely on the
replacement of 1-elem array without incurring binary changes.
--
Paulo A.
WARNING: multiple messages have this Message-ID (diff)
From: Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@gmail.com>
To: "Christian König" <christian.koenig@amd.com>
Cc: Kees Cook <keescook@chromium.org>,
Grigory Vasilyev <h0tc0d3@gmail.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Slark Xiao <slark_xiao@163.com>,
Hans de Goede <hdegoede@redhat.com>,
Claudio Suarez <cssk@net-c.es>,
dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@gmail.com>,
Rongguang Wei <weirongguang@kylinos.cn>,
linux-hardening@vger.kernel.org
Subject: Re: [PATCH] [next] drm/amdgpu: Replace one-element array with flexible-array member
Date: Sat, 29 Oct 2022 13:43:30 +1300 [thread overview]
Message-ID: <Y1x3MtRJ8ckXxlJn@mail.google.com> (raw)
In-Reply-To: <1052fba8-11ac-cec8-92e7-b994266c6970@amd.com>
On Fri, Oct 28, 2022 at 07:33:17PM +0200, Christian König wrote:
> Am 28.10.22 um 18:36 schrieb Kees Cook:
>
> > All that said, converting away from them can be tricky, and I think such
> > conversions need to explicitly show how they were checked for binary
> > differences[2].
>
> Oh, that's a great idea! Yes, if this can be guaranteed then the change is
> obviously perfectly ok.
>
> >
> > Paulo, can you please check for deltas and report your findings in the
> > commit log? Note that add struct_size() use in the same patch may result
> > in binary differences, so for more complex cases, you may want to split
> > the 1-element conversion from the struct_size() conversions.
> >
> > -Kees
Noted. I will reporting my findings on commit logs from now onwards.
Given that I split the if-ternary to avoid checking "fake_edid_record->ucFakeEDIDLength"
twice then (for the current patch), yes, there will be changes to *.o|ko files.
Knowing that Christian would feel more confident with no binary changes
at this point, I will send a different patch aiming solely on the
replacement of 1-elem array without incurring binary changes.
--
Paulo A.
next prev parent reply other threads:[~2022-10-29 0:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 5:10 [PATCH] [next] drm/amdgpu: Replace one-element array with flexible-array member Paulo Miguel Almeida
2022-10-28 7:18 ` Christian König
2022-10-28 16:36 ` Kees Cook
2022-10-28 16:36 ` Kees Cook
2022-10-28 16:36 ` Kees Cook
2022-10-28 17:33 ` Christian König
2022-10-28 17:33 ` Christian König
2022-10-28 17:33 ` Christian König
2022-10-29 0:43 ` Paulo Miguel Almeida [this message]
2022-10-29 0:43 ` Paulo Miguel Almeida
2022-10-29 0:43 ` Paulo Miguel Almeida
2022-10-29 1:30 ` [PATCH v2] " Paulo Miguel Almeida
2022-10-29 1:30 ` Paulo Miguel Almeida
2022-11-02 16:12 ` Alex Deucher
2022-11-02 16:12 ` Alex Deucher
2022-11-02 16:12 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y1x3MtRJ8ckXxlJn@mail.google.com \
--to=paulo.miguel.almeida.rodenas@gmail.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=cssk@net-c.es \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=h0tc0d3@gmail.com \
--cc=hdegoede@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=slark_xiao@163.com \
--cc=weirongguang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.