* [PATCH] staging: rtl8192e: Remove line breaks to match coding style
@ 2022-11-01 1:15 Gabhyun Kim
2022-11-01 4:53 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Gabhyun Kim @ 2022-11-01 1:15 UTC (permalink / raw)
To: gregkh; +Cc: linux-staging, linux-kernel
Remove redundant line breaks between function definitions to correct the coding style
Signed-off-by: Gabhyun Kim <kimgaby415@gmail.com>
---
drivers/staging/rtl8192e/rtllib_softmac.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
index 1a3ca3e57623..78828ecac28a 100644
--- a/drivers/staging/rtl8192e/rtllib_softmac.c
+++ b/drivers/staging/rtl8192e/rtllib_softmac.c
@@ -22,7 +22,6 @@
static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl);
-
static short rtllib_is_54g(struct rtllib_network *net)
{
return (net->rates_ex_len > 0) || (net->rates_len > 4);
@@ -147,9 +146,7 @@ static void init_mgmt_queue(struct rtllib_device *ieee)
ieee->mgmt_queue_tail = ieee->mgmt_queue_head = 0;
}
-
-u8
-MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
+u8 MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
{
u16 i;
u8 QueryRate = 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: rtl8192e: Remove line breaks to match coding style
2022-11-01 1:15 [PATCH] staging: rtl8192e: Remove line breaks to match coding style Gabhyun Kim
@ 2022-11-01 4:53 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2022-11-01 4:53 UTC (permalink / raw)
To: Gabhyun Kim; +Cc: linux-staging, linux-kernel
On Tue, Nov 01, 2022 at 10:15:07AM +0900, Gabhyun Kim wrote:
> Remove redundant line breaks between function definitions to correct the coding style
Nit, your changelog text is too wide, please properly wrap your lines at
72 columns.
>
> Signed-off-by: Gabhyun Kim <kimgaby415@gmail.com>
> ---
> drivers/staging/rtl8192e/rtllib_softmac.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rtl8192e/rtllib_softmac.c b/drivers/staging/rtl8192e/rtllib_softmac.c
> index 1a3ca3e57623..78828ecac28a 100644
> --- a/drivers/staging/rtl8192e/rtllib_softmac.c
> +++ b/drivers/staging/rtl8192e/rtllib_softmac.c
> @@ -22,7 +22,6 @@
>
> static void rtllib_sta_wakeup(struct rtllib_device *ieee, short nl);
>
> -
> static short rtllib_is_54g(struct rtllib_network *net)
> {
> return (net->rates_ex_len > 0) || (net->rates_len > 4);
> @@ -147,9 +146,7 @@ static void init_mgmt_queue(struct rtllib_device *ieee)
> ieee->mgmt_queue_tail = ieee->mgmt_queue_head = 0;
> }
>
> -
> -u8
> -MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
> +u8 MgntQuery_TxRateExcludeCCKRates(struct rtllib_device *ieee)
> {
You are doing two different types of things here, please only do one
"logical" type of thing at a time in a patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-01 4:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-01 1:15 [PATCH] staging: rtl8192e: Remove line breaks to match coding style Gabhyun Kim
2022-11-01 4:53 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.