* [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit
@ 2022-11-07 9:55 Heinrich Schuchardt
2022-11-07 12:04 ` Padmarao.Begari
2022-11-08 14:16 ` Conor Dooley
0 siblings, 2 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2022-11-07 9:55 UTC (permalink / raw)
To: Padmarao Begari, Cyril Jean; +Cc: Conor Dooley, u-boot, Heinrich Schuchardt
HSS 2022.10 provides support for resetting the board.
Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
---
configs/microchip_mpfs_icicle_defconfig | 2 ++
1 file changed, 2 insertions(+)
diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig
index c295b9bad3..65bd50db80 100644
--- a/configs/microchip_mpfs_icicle_defconfig
+++ b/configs/microchip_mpfs_icicle_defconfig
@@ -21,3 +21,5 @@ CONFIG_SYS_MEM_TOP_HIDE=0x400000
CONFIG_SYS_RELOC_GD_ENV_ADDR=y
CONFIG_BOOTP_SEND_HOSTNAME=y
CONFIG_DM_MTD=y
+CONFIG_SYSRESET=y
+CONFIG_SYSRESET_SBI=y
--
2.37.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit
2022-11-07 9:55 [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit Heinrich Schuchardt
@ 2022-11-07 12:04 ` Padmarao.Begari
2022-11-08 14:16 ` Conor Dooley
1 sibling, 0 replies; 6+ messages in thread
From: Padmarao.Begari @ 2022-11-07 12:04 UTC (permalink / raw)
To: heinrich.schuchardt, Cyril.Jean; +Cc: u-boot, Conor.Dooley
> On Mon, 2022-11-07 at 10:55 +0100, Heinrich Schuchardt wrote:
>
> HSS 2022.10 provides support for resetting the board.
>
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com
> >
> ---
> configs/microchip_mpfs_icicle_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/microchip_mpfs_icicle_defconfig
> b/configs/microchip_mpfs_icicle_defconfig
> index c295b9bad3..65bd50db80 100644
> --- a/configs/microchip_mpfs_icicle_defconfig
> +++ b/configs/microchip_mpfs_icicle_defconfig
> @@ -21,3 +21,5 @@ CONFIG_SYS_MEM_TOP_HIDE=0x400000
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_BOOTP_SEND_HOSTNAME=y
> CONFIG_DM_MTD=y
> +CONFIG_SYSRESET=y
> +CONFIG_SYSRESET_SBI=y
Reviewed-by: Padmarao Begari <padmarao.begari@microchip.com>
Tested-by: Padmarao Begari <padmarao.begari@microchip.com>
> --
> 2.37.2
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit
2022-11-07 9:55 [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit Heinrich Schuchardt
2022-11-07 12:04 ` Padmarao.Begari
@ 2022-11-08 14:16 ` Conor Dooley
2022-11-08 14:23 ` Sean Anderson
2022-11-08 14:39 ` Heinrich Schuchardt
1 sibling, 2 replies; 6+ messages in thread
From: Conor Dooley @ 2022-11-08 14:16 UTC (permalink / raw)
To: Heinrich Schuchardt; +Cc: Padmarao Begari, Cyril Jean, u-boot
On Mon, Nov 07, 2022 at 10:55:46AM +0100, Heinrich Schuchardt wrote:
> HSS 2022.10 provides support for resetting the board.
It's actually v2022.09 that added support for reset. I don't think that
that is important to correct though, since v2022.10 is the version we
are updating the dt in U-Boot to match.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
One minor & mostly unrelated question below.
> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> ---
> configs/microchip_mpfs_icicle_defconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig
> index c295b9bad3..65bd50db80 100644
> --- a/configs/microchip_mpfs_icicle_defconfig
> +++ b/configs/microchip_mpfs_icicle_defconfig
> @@ -21,3 +21,5 @@ CONFIG_SYS_MEM_TOP_HIDE=0x400000
> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
> CONFIG_BOOTP_SEND_HOSTNAME=y
> CONFIG_DM_MTD=y
> +CONFIG_SYSRESET=y
> +CONFIG_SYSRESET_SBI=y
I took a look at the config option, but something seemed odd to me. It
says "depends on SBI_V02" but the help text says "version 0.3". I see
there's no define for SBI_V03 so I assume that's why there's a mismatch.
I didn't see a comment about it in the commit hence asking. AFAIR, v0.3
is the correct version.
> config SYSRESET_SBI
> bool "Enable support for SBI System Reset"
> depends on RISCV_SMODE && SBI_V02
> default y
> select SYSRESET_CMD_POWEROFF if CMD_POWEROFF
> help
> Enable system reset and poweroff via the SBI system reset extension.
> The extension was introduced in version 0.3 of the SBI specification.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit
2022-11-08 14:16 ` Conor Dooley
@ 2022-11-08 14:23 ` Sean Anderson
2022-11-08 14:43 ` Conor Dooley
2022-11-08 14:39 ` Heinrich Schuchardt
1 sibling, 1 reply; 6+ messages in thread
From: Sean Anderson @ 2022-11-08 14:23 UTC (permalink / raw)
To: Conor Dooley, Heinrich Schuchardt; +Cc: Padmarao Begari, Cyril Jean, u-boot
On 11/8/22 09:16, Conor Dooley wrote:
> On Mon, Nov 07, 2022 at 10:55:46AM +0100, Heinrich Schuchardt wrote:
>> HSS 2022.10 provides support for resetting the board.
>
> It's actually v2022.09 that added support for reset. I don't think that
> that is important to correct though, since v2022.10 is the version we
> are updating the dt in U-Boot to match.
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> One minor & mostly unrelated question below.
>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> ---
>> configs/microchip_mpfs_icicle_defconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig
>> index c295b9bad3..65bd50db80 100644
>> --- a/configs/microchip_mpfs_icicle_defconfig
>> +++ b/configs/microchip_mpfs_icicle_defconfig
>> @@ -21,3 +21,5 @@ CONFIG_SYS_MEM_TOP_HIDE=0x400000
>> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>> CONFIG_BOOTP_SEND_HOSTNAME=y
>> CONFIG_DM_MTD=y
>> +CONFIG_SYSRESET=y
>> +CONFIG_SYSRESET_SBI=y
>
> I took a look at the config option, but something seemed odd to me. It
> says "depends on SBI_V02" but the help text says "version 0.3". I see
> there's no define for SBI_V03 so I assume that's why there's a mismatch.
>
> I didn't see a comment about it in the commit hence asking. AFAIR, v0.3
> is the correct version.
IIRC 0.3 is the same as 0.2 except it was ratified.
>> config SYSRESET_SBI
>> bool "Enable support for SBI System Reset"
>> depends on RISCV_SMODE && SBI_V02
>> default y
>> select SYSRESET_CMD_POWEROFF if CMD_POWEROFF
>> help
>> Enable system reset and poweroff via the SBI system reset extension.
>> The extension was introduced in version 0.3 of the SBI specification.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit
2022-11-08 14:16 ` Conor Dooley
2022-11-08 14:23 ` Sean Anderson
@ 2022-11-08 14:39 ` Heinrich Schuchardt
1 sibling, 0 replies; 6+ messages in thread
From: Heinrich Schuchardt @ 2022-11-08 14:39 UTC (permalink / raw)
To: Conor Dooley; +Cc: Padmarao Begari, Cyril Jean, u-boot
On 11/8/22 15:16, Conor Dooley wrote:
> On Mon, Nov 07, 2022 at 10:55:46AM +0100, Heinrich Schuchardt wrote:
>> HSS 2022.10 provides support for resetting the board.
>
> It's actually v2022.09 that added support for reset. I don't think that
> that is important to correct though, since v2022.10 is the version we
> are updating the dt in U-Boot to match.
> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
>
> One minor & mostly unrelated question below.
>
>> Signed-off-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
>> ---
>> configs/microchip_mpfs_icicle_defconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/configs/microchip_mpfs_icicle_defconfig b/configs/microchip_mpfs_icicle_defconfig
>> index c295b9bad3..65bd50db80 100644
>> --- a/configs/microchip_mpfs_icicle_defconfig
>> +++ b/configs/microchip_mpfs_icicle_defconfig
>> @@ -21,3 +21,5 @@ CONFIG_SYS_MEM_TOP_HIDE=0x400000
>> CONFIG_SYS_RELOC_GD_ENV_ADDR=y
>> CONFIG_BOOTP_SEND_HOSTNAME=y
>> CONFIG_DM_MTD=y
>> +CONFIG_SYSRESET=y
>> +CONFIG_SYSRESET_SBI=y
>
> I took a look at the config option, but something seemed odd to me. It
> says "depends on SBI_V02" but the help text says "version 0.3". I see
> there's no define for SBI_V03 so I assume that's why there's a mismatch.
>
> I didn't see a comment about it in the commit hence asking. AFAIR, v0.3
> is the correct version.
The only ratified version of the SBI specification is 1.0.
v0.2 introduced the concept of extensions.
v0.3 introduced the SRST extension.
CONFIG_SBI_V02=y means SBI specification v0.2 or later. We should update
the description of CONFIG_SBI_V02 accordingly.
HSS 2022.10 provides an OpenSBI 1.0 which is good enough.
If you use a 0.1 or 0.2 SBI, the worst thing that can happen is that
sbi_probe_extension(SBI_EXT_SRST) will return an error and the reset
driver is not loaded.
Best regards
Heinrich
>
>> config SYSRESET_SBI
>> bool "Enable support for SBI System Reset"
>> depends on RISCV_SMODE && SBI_V02
>> default y
>> select SYSRESET_CMD_POWEROFF if CMD_POWEROFF
>> help
>> Enable system reset and poweroff via the SBI system reset extension.
>> The extension was introduced in version 0.3 of the SBI specification.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit
2022-11-08 14:23 ` Sean Anderson
@ 2022-11-08 14:43 ` Conor Dooley
0 siblings, 0 replies; 6+ messages in thread
From: Conor Dooley @ 2022-11-08 14:43 UTC (permalink / raw)
To: Sean Anderson; +Cc: Heinrich Schuchardt, Padmarao Begari, Cyril Jean, u-boot
On Tue, Nov 08, 2022 at 09:23:19AM -0500, Sean Anderson wrote:
> On 11/8/22 09:16, Conor Dooley wrote:
> > > +CONFIG_SYSRESET_SBI=y
> >
> > I took a look at the config option, but something seemed odd to me. It
> > says "depends on SBI_V02" but the help text says "version 0.3". I see
> > there's no define for SBI_V03 so I assume that's why there's a mismatch.
> >
> > I didn't see a comment about it in the commit hence asking. AFAIR, v0.3
> > is the correct version.
>
> IIRC 0.3 is the same as 0.2 except it was ratified.
Ah I see. Apologies for the noise on that one so, had a quick look on
the riscv-non-isa github but obviously not enough!
Thanks Sean.
> > > config SYSRESET_SBI
> > > bool "Enable support for SBI System Reset"
> > > depends on RISCV_SMODE && SBI_V02
> > > default y
> > > select SYSRESET_CMD_POWEROFF if CMD_POWEROFF
> > > help
> > > Enable system reset and poweroff via the SBI system reset extension.
> > > The extension was introduced in version 0.3 of the SBI specification.
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-11-08 14:43 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-07 9:55 [PATCH 1/1] riscv: enable reset via SBI on PolarFire Icicle Kit Heinrich Schuchardt
2022-11-07 12:04 ` Padmarao.Begari
2022-11-08 14:16 ` Conor Dooley
2022-11-08 14:23 ` Sean Anderson
2022-11-08 14:43 ` Conor Dooley
2022-11-08 14:39 ` Heinrich Schuchardt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.