* [PATCH v2] perf tools: exclude the include/perf/ directory
@ 2022-11-03 9:27 Donglin Peng
2022-11-08 21:15 ` Arnaldo Carvalho de Melo
0 siblings, 1 reply; 2+ messages in thread
From: Donglin Peng @ 2022-11-03 9:27 UTC (permalink / raw)
To: peterz, acme, adrian.hunter; +Cc: linux-kernel, linux-perf-users, Donglin Peng
Commit 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the
source tree") moved perf_dlfilters.h to the include/perf/ directory
while include/perf is ignored because it has 'perf' in the name.
Newly created files in the include/perf/ directory will be ignored.
Can check:
Before:
$ touch tools/perf/include/perf/junk
$ git status | grep junk
$ git check-ignore -v tools/perf/include/perf/junk
tools/perf/.gitignore:6:perf tools/perf/include/perf/junk
After:
$ git status | grep junk
tools/perf/include/perf/junk
$ git check-ignore -v tools/perf/include/perf/junk
Add !include/perf/ to perf's .gitignore file.
Fixes: 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the source tree")
Signed-off-by: Donglin Peng <dolinux.peng@gmail.com>
Acked-by: Adrian Hunter <adrian.hunter@intel.com>
---
Changes in v2:
- add 'Fixes:' tag in commit message
- make commit message more clearer
---
tools/perf/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
index a653311d9693..fd7a6ff9e7aa 100644
--- a/tools/perf/.gitignore
+++ b/tools/perf/.gitignore
@@ -4,6 +4,7 @@ PERF-GUI-VARS
PERF-VERSION-FILE
FEATURE-DUMP
perf
+!include/perf/
perf-read-vdso32
perf-read-vdsox32
perf-help
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] perf tools: exclude the include/perf/ directory
2022-11-03 9:27 [PATCH v2] perf tools: exclude the include/perf/ directory Donglin Peng
@ 2022-11-08 21:15 ` Arnaldo Carvalho de Melo
0 siblings, 0 replies; 2+ messages in thread
From: Arnaldo Carvalho de Melo @ 2022-11-08 21:15 UTC (permalink / raw)
To: Donglin Peng; +Cc: peterz, adrian.hunter, linux-kernel, linux-perf-users
Em Thu, Nov 03, 2022 at 02:27:04AM -0700, Donglin Peng escreveu:
> Commit 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the
> source tree") moved perf_dlfilters.h to the include/perf/ directory
> while include/perf is ignored because it has 'perf' in the name.
> Newly created files in the include/perf/ directory will be ignored.
Thanks, applied.
- Arnaldo
> Can check:
>
> Before:
> $ touch tools/perf/include/perf/junk
> $ git status | grep junk
> $ git check-ignore -v tools/perf/include/perf/junk
> tools/perf/.gitignore:6:perf tools/perf/include/perf/junk
>
> After:
> $ git status | grep junk
> tools/perf/include/perf/junk
> $ git check-ignore -v tools/perf/include/perf/junk
>
> Add !include/perf/ to perf's .gitignore file.
>
> Fixes: 3af1dfdd51e0 ("perf build: Move perf_dlfilters.h in the source tree")
> Signed-off-by: Donglin Peng <dolinux.peng@gmail.com>
> Acked-by: Adrian Hunter <adrian.hunter@intel.com>
> ---
> Changes in v2:
> - add 'Fixes:' tag in commit message
> - make commit message more clearer
> ---
> tools/perf/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/perf/.gitignore b/tools/perf/.gitignore
> index a653311d9693..fd7a6ff9e7aa 100644
> --- a/tools/perf/.gitignore
> +++ b/tools/perf/.gitignore
> @@ -4,6 +4,7 @@ PERF-GUI-VARS
> PERF-VERSION-FILE
> FEATURE-DUMP
> perf
> +!include/perf/
> perf-read-vdso32
> perf-read-vdsox32
> perf-help
> --
> 2.25.1
--
- Arnaldo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-08 21:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 9:27 [PATCH v2] perf tools: exclude the include/perf/ directory Donglin Peng
2022-11-08 21:15 ` Arnaldo Carvalho de Melo
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.