* [PATCH 0/2] slimbus: fixes for 6.1
@ 2022-11-18 6:52 Srinivas Kandagatla
2022-11-18 6:52 ` [PATCH 1/2] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m Srinivas Kandagatla
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2022-11-18 6:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Srinivas Kandagatla
Hi Greg,
Here are two important fixes in slimbus one is to fix the presence rate table as per
the MiPi spec and other is fix a build error.
If its not too late, can you take them for 6.1.
Many thanks,
Srini
Krzysztof Kozlowski (1):
slimbus: stream: correct presence rate frequencies
Zheng Bin (1):
slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y &&
CONFIG_QCOM_RPROC_COMMON=m
drivers/slimbus/Kconfig | 2 +-
drivers/slimbus/stream.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/2] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m
2022-11-18 6:52 [PATCH 0/2] slimbus: fixes for 6.1 Srinivas Kandagatla
@ 2022-11-18 6:52 ` Srinivas Kandagatla
2022-11-18 6:52 ` [PATCH 2/2] slimbus: stream: correct presence rate frequencies Srinivas Kandagatla
2022-11-22 17:23 ` [PATCH 0/2] slimbus: fixes for 6.1 Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2022-11-18 6:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Zheng Bin, Krzysztof Kozlowski, Srinivas Kandagatla
From: Zheng Bin <zhengbin13@huawei.com>
If CONFIG_SLIM_QCOM_NGD_CTRL=y, CONFIG_QCOM_RPROC_COMMON=m, COMPILE_TEST=y,
bulding fails:
drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_ctrl_probe':
qcom-ngd-ctrl.c:(.text+0x330): undefined reference to `qcom_register_ssr_notifier'
qcom-ngd-ctrl.c:(.text+0x5fc): undefined reference to `qcom_unregister_ssr_notifier'
drivers/slimbus/qcom-ngd-ctrl.o: In function `qcom_slim_ngd_remove':
qcom-ngd-ctrl.c:(.text+0x90c): undefined reference to `qcom_unregister_ssr_notifier'
Make SLIM_QCOM_NGD_CTRL depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON) to fix this.
Fixes: e291691c6977 ("slimbus: qcom-ngd-ctrl: allow compile testing without QCOM_RPROC_COMMON")
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/slimbus/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/slimbus/Kconfig b/drivers/slimbus/Kconfig
index 2ed821f75816..a0fdf9d792cb 100644
--- a/drivers/slimbus/Kconfig
+++ b/drivers/slimbus/Kconfig
@@ -23,7 +23,7 @@ config SLIM_QCOM_CTRL
config SLIM_QCOM_NGD_CTRL
tristate "Qualcomm SLIMbus Satellite Non-Generic Device Component"
depends on HAS_IOMEM && DMA_ENGINE && NET
- depends on QCOM_RPROC_COMMON || COMPILE_TEST
+ depends on QCOM_RPROC_COMMON || (COMPILE_TEST && !QCOM_RPROC_COMMON)
depends on ARCH_QCOM || COMPILE_TEST
select QCOM_QMI_HELPERS
select QCOM_PDR_HELPERS
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2/2] slimbus: stream: correct presence rate frequencies
2022-11-18 6:52 [PATCH 0/2] slimbus: fixes for 6.1 Srinivas Kandagatla
2022-11-18 6:52 ` [PATCH 1/2] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m Srinivas Kandagatla
@ 2022-11-18 6:52 ` Srinivas Kandagatla
2022-11-22 17:23 ` [PATCH 0/2] slimbus: fixes for 6.1 Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Srinivas Kandagatla @ 2022-11-18 6:52 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, Krzysztof Kozlowski, stable, Srinivas Kandagatla
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Correct few frequencies in presence rate table - multiplied by 10
(110250 instead of 11025 Hz).
Fixes: abb9c9b8b51b ("slimbus: stream: add stream support")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
drivers/slimbus/stream.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/slimbus/stream.c b/drivers/slimbus/stream.c
index 75f87b3d8b95..73a2aa362957 100644
--- a/drivers/slimbus/stream.c
+++ b/drivers/slimbus/stream.c
@@ -67,10 +67,10 @@ static const int slim_presence_rate_table[] = {
384000,
768000,
0, /* Reserved */
- 110250,
- 220500,
- 441000,
- 882000,
+ 11025,
+ 22050,
+ 44100,
+ 88200,
176400,
352800,
705600,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 0/2] slimbus: fixes for 6.1
2022-11-18 6:52 [PATCH 0/2] slimbus: fixes for 6.1 Srinivas Kandagatla
2022-11-18 6:52 ` [PATCH 1/2] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m Srinivas Kandagatla
2022-11-18 6:52 ` [PATCH 2/2] slimbus: stream: correct presence rate frequencies Srinivas Kandagatla
@ 2022-11-22 17:23 ` Greg KH
2 siblings, 0 replies; 4+ messages in thread
From: Greg KH @ 2022-11-22 17:23 UTC (permalink / raw)
To: Srinivas Kandagatla; +Cc: linux-kernel
On Fri, Nov 18, 2022 at 06:52:26AM +0000, Srinivas Kandagatla wrote:
> Hi Greg,
>
> Here are two important fixes in slimbus one is to fix the presence rate table as per
> the MiPi spec and other is fix a build error.
>
> If its not too late, can you take them for 6.1.
Already in 6.1-rc6, right?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-22 17:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-18 6:52 [PATCH 0/2] slimbus: fixes for 6.1 Srinivas Kandagatla
2022-11-18 6:52 ` [PATCH 1/2] slimbus: qcom-ngd: Fix build error when CONFIG_SLIM_QCOM_NGD_CTRL=y && CONFIG_QCOM_RPROC_COMMON=m Srinivas Kandagatla
2022-11-18 6:52 ` [PATCH 2/2] slimbus: stream: correct presence rate frequencies Srinivas Kandagatla
2022-11-22 17:23 ` [PATCH 0/2] slimbus: fixes for 6.1 Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.