All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
	andrew@aj.id.au, lee@kernel.org, thierry.reding@gmail.com,
	u.kleine-koenig@pengutronix.de, corbet@lwn.net,
	p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [v4 5/5] hwmon: Add Aspeed ast2600 TACH support
Date: Wed, 23 Nov 2022 15:45:46 +0700	[thread overview]
Message-ID: <Y33duvUVQ0AJsgAv@debian.me> (raw)
In-Reply-To: <20221123061635.32025-6-billy_tsai@aspeedtech.com>

[-- Attachment #1: Type: text/plain, Size: 2888 bytes --]

On Wed, Nov 23, 2022 at 02:16:35PM +0800, Billy Tsai wrote:
> diff --git a/Documentation/hwmon/tach-aspeed-ast2600.rst b/Documentation/hwmon/tach-aspeed-ast2600.rst
> new file mode 100644
> index 000000000000..4f9501b783a1
> --- /dev/null
> +++ b/Documentation/hwmon/tach-aspeed-ast2600.rst
> @@ -0,0 +1,24 @@
> +Kernel driver tach-aspeed-ast2600
> +==============================
> +
> +Supported chips:
> +	ASPEED AST2600
> +
> +Authors:
> +	<billy_tsai@aspeedtech.com>
> +
> +Description:
> +------------
> +This driver implements support for ASPEED AST2600 Fan Tacho controller.
> +The controller supports up to 16 tachometer inputs.
> +
> +The driver provides the following sensor accesses in sysfs:
> +=============== ======= =====================================================
> +fanX_input	ro	provide current fan rotation value in RPM as reported
> +			by the fan to the device.
> +fanX_div	rw	Fan divisor: Supported value are power of 4 (1, 4, 16
> +                        64, ... 4194304)
> +                        The larger divisor, the less rpm accuracy and the less
> +                        affected by fan signal glitch.
> +fanX_pulses	rw      Fan pulses per resolution.
> +=============== ======= ======================================================

I found htmldocs warnings:

Documentation/hwmon/tach-aspeed-ast2600.rst:2: WARNING: Title underline too short.

Kernel driver tach-aspeed-ast2600
==============================
Documentation/hwmon/tach-aspeed-ast2600.rst:18: WARNING: Unexpected indentation.
Documentation/hwmon/tach-aspeed-ast2600.rst:19: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/hwmon/tach-aspeed-ast2600.rst:23: WARNING: Definition list ends without a blank line; unexpected unindent.

I have applied the fixup:

---- >8 ----

diff --git a/Documentation/hwmon/tach-aspeed-ast2600.rst b/Documentation/hwmon/tach-aspeed-ast2600.rst
index 4f9501b783a11b..8faa00f6ad47c2 100644
--- a/Documentation/hwmon/tach-aspeed-ast2600.rst
+++ b/Documentation/hwmon/tach-aspeed-ast2600.rst
@@ -1,5 +1,5 @@
 Kernel driver tach-aspeed-ast2600
-==============================
+=================================
 
 Supported chips:
 	ASPEED AST2600
@@ -13,7 +13,8 @@ This driver implements support for ASPEED AST2600 Fan Tacho controller.
 The controller supports up to 16 tachometer inputs.
 
 The driver provides the following sensor accesses in sysfs:
-=============== ======= =====================================================
+
+=============== ======= ======================================================
 fanX_input	ro	provide current fan rotation value in RPM as reported
 			by the fan to the device.
 fanX_div	rw	Fan divisor: Supported value are power of 4 (1, 4, 16

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Bagas Sanjaya <bagasdotme@gmail.com>
To: Billy Tsai <billy_tsai@aspeedtech.com>
Cc: jdelvare@suse.com, linux@roeck-us.net, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, joel@jms.id.au,
	andrew@aj.id.au, lee@kernel.org, thierry.reding@gmail.com,
	u.kleine-koenig@pengutronix.de, corbet@lwn.net,
	p.zabel@pengutronix.de, linux-hwmon@vger.kernel.org,
	devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
	linux-pwm@vger.kernel.org, linux-doc@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [v4 5/5] hwmon: Add Aspeed ast2600 TACH support
Date: Wed, 23 Nov 2022 15:45:46 +0700	[thread overview]
Message-ID: <Y33duvUVQ0AJsgAv@debian.me> (raw)
In-Reply-To: <20221123061635.32025-6-billy_tsai@aspeedtech.com>


[-- Attachment #1.1: Type: text/plain, Size: 2888 bytes --]

On Wed, Nov 23, 2022 at 02:16:35PM +0800, Billy Tsai wrote:
> diff --git a/Documentation/hwmon/tach-aspeed-ast2600.rst b/Documentation/hwmon/tach-aspeed-ast2600.rst
> new file mode 100644
> index 000000000000..4f9501b783a1
> --- /dev/null
> +++ b/Documentation/hwmon/tach-aspeed-ast2600.rst
> @@ -0,0 +1,24 @@
> +Kernel driver tach-aspeed-ast2600
> +==============================
> +
> +Supported chips:
> +	ASPEED AST2600
> +
> +Authors:
> +	<billy_tsai@aspeedtech.com>
> +
> +Description:
> +------------
> +This driver implements support for ASPEED AST2600 Fan Tacho controller.
> +The controller supports up to 16 tachometer inputs.
> +
> +The driver provides the following sensor accesses in sysfs:
> +=============== ======= =====================================================
> +fanX_input	ro	provide current fan rotation value in RPM as reported
> +			by the fan to the device.
> +fanX_div	rw	Fan divisor: Supported value are power of 4 (1, 4, 16
> +                        64, ... 4194304)
> +                        The larger divisor, the less rpm accuracy and the less
> +                        affected by fan signal glitch.
> +fanX_pulses	rw      Fan pulses per resolution.
> +=============== ======= ======================================================

I found htmldocs warnings:

Documentation/hwmon/tach-aspeed-ast2600.rst:2: WARNING: Title underline too short.

Kernel driver tach-aspeed-ast2600
==============================
Documentation/hwmon/tach-aspeed-ast2600.rst:18: WARNING: Unexpected indentation.
Documentation/hwmon/tach-aspeed-ast2600.rst:19: WARNING: Block quote ends without a blank line; unexpected unindent.
Documentation/hwmon/tach-aspeed-ast2600.rst:23: WARNING: Definition list ends without a blank line; unexpected unindent.

I have applied the fixup:

---- >8 ----

diff --git a/Documentation/hwmon/tach-aspeed-ast2600.rst b/Documentation/hwmon/tach-aspeed-ast2600.rst
index 4f9501b783a11b..8faa00f6ad47c2 100644
--- a/Documentation/hwmon/tach-aspeed-ast2600.rst
+++ b/Documentation/hwmon/tach-aspeed-ast2600.rst
@@ -1,5 +1,5 @@
 Kernel driver tach-aspeed-ast2600
-==============================
+=================================
 
 Supported chips:
 	ASPEED AST2600
@@ -13,7 +13,8 @@ This driver implements support for ASPEED AST2600 Fan Tacho controller.
 The controller supports up to 16 tachometer inputs.
 
 The driver provides the following sensor accesses in sysfs:
-=============== ======= =====================================================
+
+=============== ======= ======================================================
 fanX_input	ro	provide current fan rotation value in RPM as reported
 			by the fan to the device.
 fanX_div	rw	Fan divisor: Supported value are power of 4 (1, 4, 16

Thanks.

-- 
An old man doll... just what I always wanted! - Clara

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-11-23  8:45 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  6:16 [v4 0/5] Support pwm/tach driver for aspeed ast26xx Billy Tsai
2022-11-23  6:16 ` Billy Tsai
2022-11-23  6:16 ` [v4 1/5] dt-bindings: mfd: Add aspeed pwm-tach binding Billy Tsai
2022-11-23  6:16   ` Billy Tsai
2022-11-23  8:24   ` Krzysztof Kozlowski
2022-11-23  8:24     ` Krzysztof Kozlowski
2022-11-23  8:27     ` Krzysztof Kozlowski
2022-11-23  8:27       ` Krzysztof Kozlowski
2022-12-09  0:54       ` Billy Tsai
2022-12-09  0:54         ` Billy Tsai
2022-12-09  7:48         ` Krzysztof Kozlowski
2022-12-09  7:48           ` Krzysztof Kozlowski
2023-01-06  3:31           ` Billy Tsai
2023-01-06  3:31             ` Billy Tsai
2023-06-08  6:43     ` Krzysztof Kozlowski
2023-06-08  6:43       ` Krzysztof Kozlowski
     [not found]       ` <SG2PR06MB3365AE9D075601CB62C6E7F78B50A@SG2PR06MB3365.apcprd06.prod.outlook.com>
2023-06-08  7:20         ` Krzysztof Kozlowski
2023-06-08  7:20           ` Krzysztof Kozlowski
2022-11-23 15:07   ` Rob Herring
2022-11-23 15:07     ` Rob Herring
2022-11-23  6:16 ` [v4 2/5] dt-bindings: pwm: Add bindings for aspeed pwm controller Billy Tsai
2022-11-23  6:16   ` Billy Tsai
2022-11-23  8:30   ` Krzysztof Kozlowski
2022-11-23  8:30     ` Krzysztof Kozlowski
2022-11-23 15:07   ` Rob Herring
2022-11-23 15:07     ` Rob Herring
2022-11-23  6:16 ` [v4 3/5] dt-bindings: hwmon: Add bindings for aspeed tach controller Billy Tsai
2022-11-23  6:16   ` Billy Tsai
2022-11-23  8:33   ` Krzysztof Kozlowski
2022-11-23  8:33     ` Krzysztof Kozlowski
2022-11-23 15:21   ` Guenter Roeck
2022-11-23 15:21     ` Guenter Roeck
2022-11-23  6:16 ` [v4 4/5] pwm: Add Aspeed ast2600 PWM support Billy Tsai
2022-11-23  6:16   ` Billy Tsai
2022-11-23  8:43   ` Bagas Sanjaya
2022-11-23  8:43     ` Bagas Sanjaya
2023-04-24 10:12   ` Delphine_CC_Chiu/WYHQ/Wiwynn
2023-04-24 10:12     ` Delphine_CC_Chiu/WYHQ/Wiwynn
2022-11-23  6:16 ` [v4 5/5] hwmon: Add Aspeed ast2600 TACH support Billy Tsai
2022-11-23  6:16   ` Billy Tsai
2022-11-23  8:45   ` Bagas Sanjaya [this message]
2022-11-23  8:45     ` Bagas Sanjaya
2022-11-23 15:44   ` Guenter Roeck
2022-11-23 15:44     ` Guenter Roeck
2022-11-29  7:08     ` Billy Tsai
2022-11-29  7:08       ` Billy Tsai
2022-11-29 15:06       ` Guenter Roeck
2022-11-29 15:06         ` Guenter Roeck
2023-01-17 21:48 ` [v4 0/5] Support pwm/tach driver for aspeed ast26xx Uwe Kleine-König
2023-01-17 21:48   ` Uwe Kleine-König
2023-01-18  1:48   ` Billy Tsai
2023-01-18  1:48     ` Billy Tsai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y33duvUVQ0AJsgAv@debian.me \
    --to=bagasdotme@gmail.com \
    --cc=andrew@aj.id.au \
    --cc=billy_tsai@aspeedtech.com \
    --cc=corbet@lwn.net \
    --cc=devicetree@vger.kernel.org \
    --cc=jdelvare@suse.com \
    --cc=joel@jms.id.au \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lkp@intel.com \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.