Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff

From: Bobby Eshleman <bobbyeshleman@gmail.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	Bobby Eshleman <bobby.eshleman@bytedance.com>,
	Cong Wang <cong.wang@bytedance.com>,
	Krasnov Arseniy <oxffffaa@gmail.com>,
	Jiang Wang <jiang.wang@bytedance.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Eric Dumazet <edumazet@google.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	kvm@vger.kernel.org, Jakub Kicinski <kuba@kernel.org>,
	Paolo Abeni <pabeni@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH net-next v6] virtio/vsock: replace virtio_vsock_pkt with sk_buff
Date: Wed, 23 Nov 2022 12:31:28 +0000	[thread overview]
Message-ID: <Y34SoH1nFTXXLWbK@bullseye> (raw)
In-Reply-To: <20221213154304.rjrwzbv6jywkrpxq@sgarzare-redhat>

On Tue, Dec 13, 2022 at 04:43:04PM +0100, Stefano Garzarella wrote:
> On Tue, Dec 13, 2022 at 10:06:23AM -0500, Michael S. Tsirkin wrote:
> > On Tue, Dec 13, 2022 at 11:22:32AM +0100, Stefano Garzarella wrote:
> > > > +	if (len <= GOOD_COPY_LEN && !skb_queue_empty_lockless(&vvs->rx_queue)) {
> > > 
> > > Same here.
> > > 
> > > If there are no major changes to be made, I think the next version is the
> > > final ones, though we are now in the merge window, so net-next is closed
> > > [1], only RFCs can be sent [2].
> > > 
> > > I suggest you wait until the merge window is over (two weeks usually) to
> > > send the next version.
> > 
> > Nah, you never know, could be more comments. And depending on the timing
> > I might be able to merge it.
> 
> Right, in the end these changes are only to virtio-vsock transport, so they
> can go smoothly even with your tree.
> 
> @Bobby, so if you can fix the remaining small things, we can try to merge it
> :-)
> 
> Thanks,
> Stefano

Sure thing. I'll change / send now.

Best,
Bobby