From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-fscrypt@vger.kernel.org,
Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH v3] fsverity: stop using PG_error to track error status
Date: Wed, 23 Nov 2022 22:19:29 +0000 [thread overview]
Message-ID: <Y36ccbZq9gsnbmWw@gmail.com> (raw)
In-Reply-To: <Y2y0cspSZG5dt6c+@sol.localdomain>
On Thu, Nov 10, 2022 at 12:21:06AM -0800, Eric Biggers wrote:
> On Fri, Oct 28, 2022 at 10:58:07AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > As a step towards freeing the PG_error flag for other uses, change ext4
> > and f2fs to stop using PG_error to track verity errors. Instead, if a
> > verity error occurs, just mark the whole bio as failed. The coarser
> > granularity isn't really a problem since it isn't any worse than what
> > the block layer provides, and errors from a multi-page readahead aren't
> > reported to applications unless a single-page read fails too.
> >
> > f2fs supports compression, which makes the f2fs changes a bit more
> > complicated than desired, but the basic premise still works.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > In v3, I made a small simplification to the f2fs changes. I'm also only
> > sending the fsverity patch now, since the fscrypt one is now upstream.
> >
> > fs/ext4/readpage.c | 8 ++----
> > fs/f2fs/compress.c | 64 ++++++++++++++++++++++------------------------
> > fs/f2fs/data.c | 48 +++++++++++++++++++---------------
> > fs/verity/verify.c | 12 ++++-----
> > 4 files changed, 67 insertions(+), 65 deletions(-)
>
> I've applied this to the fsverity tree for 6.2.
>
> Reviews would be greatly appreciated, of course.
>
Jaegeuk and Chao, can I get a review or ack from one of you?
- Eric
WARNING: multiple messages have this Message-ID (diff)
From: Eric Biggers <ebiggers@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>, Chao Yu <chao@kernel.org>
Cc: linux-fsdevel@vger.kernel.org, linux-fscrypt@vger.kernel.org,
linux-ext4@vger.kernel.org, Matthew Wilcox <willy@infradead.org>,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH v3] fsverity: stop using PG_error to track error status
Date: Wed, 23 Nov 2022 22:19:29 +0000 [thread overview]
Message-ID: <Y36ccbZq9gsnbmWw@gmail.com> (raw)
In-Reply-To: <Y2y0cspSZG5dt6c+@sol.localdomain>
On Thu, Nov 10, 2022 at 12:21:06AM -0800, Eric Biggers wrote:
> On Fri, Oct 28, 2022 at 10:58:07AM -0700, Eric Biggers wrote:
> > From: Eric Biggers <ebiggers@google.com>
> >
> > As a step towards freeing the PG_error flag for other uses, change ext4
> > and f2fs to stop using PG_error to track verity errors. Instead, if a
> > verity error occurs, just mark the whole bio as failed. The coarser
> > granularity isn't really a problem since it isn't any worse than what
> > the block layer provides, and errors from a multi-page readahead aren't
> > reported to applications unless a single-page read fails too.
> >
> > f2fs supports compression, which makes the f2fs changes a bit more
> > complicated than desired, but the basic premise still works.
> >
> > Signed-off-by: Eric Biggers <ebiggers@google.com>
> > ---
> >
> > In v3, I made a small simplification to the f2fs changes. I'm also only
> > sending the fsverity patch now, since the fscrypt one is now upstream.
> >
> > fs/ext4/readpage.c | 8 ++----
> > fs/f2fs/compress.c | 64 ++++++++++++++++++++++------------------------
> > fs/f2fs/data.c | 48 +++++++++++++++++++---------------
> > fs/verity/verify.c | 12 ++++-----
> > 4 files changed, 67 insertions(+), 65 deletions(-)
>
> I've applied this to the fsverity tree for 6.2.
>
> Reviews would be greatly appreciated, of course.
>
Jaegeuk and Chao, can I get a review or ack from one of you?
- Eric
_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2022-11-23 22:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 17:58 [PATCH v3] fsverity: stop using PG_error to track error status Eric Biggers
2022-10-28 17:58 ` [f2fs-dev] " Eric Biggers
2022-11-10 8:21 ` Eric Biggers
2022-11-10 8:21 ` Eric Biggers
2022-11-23 22:19 ` Eric Biggers [this message]
2022-11-23 22:19 ` [f2fs-dev] " Eric Biggers
2022-11-25 3:06 ` Chao Yu
2022-11-25 3:06 ` [f2fs-dev] " Chao Yu
2022-11-25 3:09 ` Eric Biggers
2022-11-25 3:09 ` [f2fs-dev] " Eric Biggers
2022-11-25 3:36 ` Chao Yu
2022-11-25 3:36 ` Chao Yu
2022-11-25 19:22 ` Eric Biggers
2022-11-25 19:22 ` [f2fs-dev] " Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y36ccbZq9gsnbmWw@gmail.com \
--to=ebiggers@kernel.org \
--cc=chao@kernel.org \
--cc=jaegeuk@kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.