* [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
@ 2022-11-13 19:10 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2022-11-13 19:10 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel, linux-arm-kernel
Cc: Lee Jones, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Rafael J. Wysocki, Greg Kroah-Hartman, kernel test robot
Since DEFINE_RES_*() macros were converted to provide a compound literal
the user doesn't need to repeat it. Moreover, it may not be compiled.
Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Should go via Greg's tree where ioport.h has been changed.
drivers/mfd/vexpress-sysreg.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
index aaf24af287dd..eab82619ec31 100644
--- a/drivers/mfd/vexpress-sysreg.c
+++ b/drivers/mfd/vexpress-sysreg.c
@@ -61,35 +61,27 @@ static struct mfd_cell vexpress_sysreg_cells[] = {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_led",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_LED, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_LED, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_led_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_led_pdata),
}, {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_mci",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_MCI, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_MCI, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_mci_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_mci_pdata),
}, {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_flash",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_FLASH, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_FLASH, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_flash_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_flash_pdata),
}, {
.name = "vexpress-syscfg",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM(SYS_MISC, 0x4c),
- },
+ .resources = &DEFINE_RES_MEM(SYS_MISC, 0x4c),
}
};
--
2.35.1
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
@ 2022-11-13 19:10 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2022-11-13 19:10 UTC (permalink / raw)
To: Andy Shevchenko, linux-kernel, linux-arm-kernel
Cc: Lee Jones, Liviu Dudau, Sudeep Holla, Lorenzo Pieralisi,
Rafael J. Wysocki, Greg Kroah-Hartman, kernel test robot
Since DEFINE_RES_*() macros were converted to provide a compound literal
the user doesn't need to repeat it. Moreover, it may not be compiled.
Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
Should go via Greg's tree where ioport.h has been changed.
drivers/mfd/vexpress-sysreg.c | 16 ++++------------
1 file changed, 4 insertions(+), 12 deletions(-)
diff --git a/drivers/mfd/vexpress-sysreg.c b/drivers/mfd/vexpress-sysreg.c
index aaf24af287dd..eab82619ec31 100644
--- a/drivers/mfd/vexpress-sysreg.c
+++ b/drivers/mfd/vexpress-sysreg.c
@@ -61,35 +61,27 @@ static struct mfd_cell vexpress_sysreg_cells[] = {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_led",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_LED, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_LED, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_led_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_led_pdata),
}, {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_mci",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_MCI, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_MCI, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_mci_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_mci_pdata),
}, {
.name = "basic-mmio-gpio",
.of_compatible = "arm,vexpress-sysreg,sys_flash",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM_NAMED(SYS_FLASH, 0x4, "dat"),
- },
+ .resources = &DEFINE_RES_MEM_NAMED(SYS_FLASH, 0x4, "dat"),
.platform_data = &vexpress_sysreg_sys_flash_pdata,
.pdata_size = sizeof(vexpress_sysreg_sys_flash_pdata),
}, {
.name = "vexpress-syscfg",
.num_resources = 1,
- .resources = (struct resource []) {
- DEFINE_RES_MEM(SYS_MISC, 0x4c),
- },
+ .resources = &DEFINE_RES_MEM(SYS_MISC, 0x4c),
}
};
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
2022-11-13 19:10 ` Andy Shevchenko
@ 2022-11-14 9:02 ` Greg Kroah-Hartman
-1 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-11-14 9:02 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, linux-arm-kernel, Lee Jones, Liviu Dudau,
Sudeep Holla, Lorenzo Pieralisi, Rafael J. Wysocki,
kernel test robot
On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Wrong git id, I have no idea where that came from :(
I'll go fix this up...
greg k-h
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
@ 2022-11-14 9:02 ` Greg Kroah-Hartman
0 siblings, 0 replies; 10+ messages in thread
From: Greg Kroah-Hartman @ 2022-11-14 9:02 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, linux-arm-kernel, Lee Jones, Liviu Dudau,
Sudeep Holla, Lorenzo Pieralisi, Rafael J. Wysocki,
kernel test robot
On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Wrong git id, I have no idea where that came from :(
I'll go fix this up...
greg k-h
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
2022-11-14 9:02 ` Greg Kroah-Hartman
@ 2022-11-14 9:37 ` Andy Shevchenko
-1 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2022-11-14 9:37 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, linux-arm-kernel, Lee Jones, Liviu Dudau,
Sudeep Holla, Lorenzo Pieralisi, Rafael J. Wysocki,
kernel test robot
On Mon, Nov 14, 2022 at 10:02:02AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> > Since DEFINE_RES_*() macros were converted to provide a compound literal
> > the user doesn't need to repeat it. Moreover, it may not be compiled.
> >
> > Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
>
> Wrong git id, I have no idea where that came from :(
Pfhh... I think it's my local one since it was never in Linux Next and
I forgot to specify your branch explicitly.
> I'll go fix this up...
Thank you!
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
@ 2022-11-14 9:37 ` Andy Shevchenko
0 siblings, 0 replies; 10+ messages in thread
From: Andy Shevchenko @ 2022-11-14 9:37 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: linux-kernel, linux-arm-kernel, Lee Jones, Liviu Dudau,
Sudeep Holla, Lorenzo Pieralisi, Rafael J. Wysocki,
kernel test robot
On Mon, Nov 14, 2022 at 10:02:02AM +0100, Greg Kroah-Hartman wrote:
> On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> > Since DEFINE_RES_*() macros were converted to provide a compound literal
> > the user doesn't need to repeat it. Moreover, it may not be compiled.
> >
> > Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
>
> Wrong git id, I have no idea where that came from :(
Pfhh... I think it's my local one since it was never in Linux Next and
I forgot to specify your branch explicitly.
> I'll go fix this up...
Thank you!
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
2022-11-13 19:10 ` Andy Shevchenko
@ 2022-11-14 10:07 ` Sudeep Holla
-1 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2022-11-14 10:07 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, linux-arm-kernel, Lee Jones, Liviu Dudau,
Lorenzo Pieralisi, Rafael J. Wysocki, Greg Kroah-Hartman,
kernel test robot
On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Reported-by: kernel test robot <lkp@intel.com>
If not too late,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
@ 2022-11-14 10:07 ` Sudeep Holla
0 siblings, 0 replies; 10+ messages in thread
From: Sudeep Holla @ 2022-11-14 10:07 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, linux-arm-kernel, Lee Jones, Liviu Dudau,
Lorenzo Pieralisi, Rafael J. Wysocki, Greg Kroah-Hartman,
kernel test robot
On Sun, Nov 13, 2022 at 09:10:27PM +0200, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Reported-by: kernel test robot <lkp@intel.com>
If not too late,
Acked-by: Sudeep Holla <sudeep.holla@arm.com>
--
Regards,
Sudeep
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
2022-11-13 19:10 ` Andy Shevchenko
@ 2022-11-14 11:06 ` Lee Jones
-1 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2022-11-14 11:06 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, linux-arm-kernel, Liviu Dudau, Sudeep Holla,
Lorenzo Pieralisi, Rafael J. Wysocki, Greg Kroah-Hartman,
kernel test robot
On Sun, 13 Nov 2022, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> Should go via Greg's tree where ioport.h has been changed.
I'm fine with it if Greg is:
Acked-by: Lee Jones <lee@kernel.org>
> drivers/mfd/vexpress-sysreg.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
--
Lee Jones [李琼斯]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments
@ 2022-11-14 11:06 ` Lee Jones
0 siblings, 0 replies; 10+ messages in thread
From: Lee Jones @ 2022-11-14 11:06 UTC (permalink / raw)
To: Andy Shevchenko
Cc: linux-kernel, linux-arm-kernel, Liviu Dudau, Sudeep Holla,
Lorenzo Pieralisi, Rafael J. Wysocki, Greg Kroah-Hartman,
kernel test robot
On Sun, 13 Nov 2022, Andy Shevchenko wrote:
> Since DEFINE_RES_*() macros were converted to provide a compound literal
> the user doesn't need to repeat it. Moreover, it may not be compiled.
>
> Fixes: 9c973ce7f9cf ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>
> Should go via Greg's tree where ioport.h has been changed.
I'm fine with it if Greg is:
Acked-by: Lee Jones <lee@kernel.org>
> drivers/mfd/vexpress-sysreg.c | 16 ++++------------
> 1 file changed, 4 insertions(+), 12 deletions(-)
--
Lee Jones [李琼斯]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-11-14 11:07 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-13 19:10 [PATCH v1 1/1] mfd: vexpress-sysreg: Fix resource compound literal assignments Andy Shevchenko
2022-11-13 19:10 ` Andy Shevchenko
2022-11-14 9:02 ` Greg Kroah-Hartman
2022-11-14 9:02 ` Greg Kroah-Hartman
2022-11-14 9:37 ` Andy Shevchenko
2022-11-14 9:37 ` Andy Shevchenko
2022-11-14 10:07 ` Sudeep Holla
2022-11-14 10:07 ` Sudeep Holla
2022-11-14 11:06 ` Lee Jones
2022-11-14 11:06 ` Lee Jones
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.