From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
x86@kernel.org, "Paul E. McKenney" <paulmck@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Nicholas Piggin <npiggin@gmail.com>, Guo Ren <guoren@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 10:08:15 +0100 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
x86@kernel.org, "Paul E. McKenney" <paulmck@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Nicholas Piggin <npiggin@gmail.com>, Guo Ren <guoren@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 10:08:15 +0100 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
x86@kernel.org, "Paul E. McKenney" <paulmck@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Nicholas Piggin <npiggin@gmail.com>, Guo Ren <guoren@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 10:08:15 +0100 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
_______________________________________________
linux-snps-arc mailing list
linux-snps-arc@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-snps-arc
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
x86@kernel.org, "Paul E. McKenney" <paulmck@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Nicholas Piggin <npiggin@gmail.com>, Guo Ren <guoren@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 10:08:15 +0100 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mips@vger.kernel.org, Guo Ren <guoren@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
linux-hexagon@vger.kernel.org, x86@kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-csky@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
openrisc@lists.librecores.org, Borislav Petkov <bp@alien8.de>,
Nicholas Piggin <npiggin@gmail.com>,
loongarch@lists.linux.dev, Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel.org,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 10:08:15 +0100 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-mips@vger.kernel.org, Guo Ren <guoren@kernel.org>,
"H. Peter Anvin" <hpa@zytor.com>,
sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, Marc Zyngier <maz@kernel.org>,
linux-hexagon@vger.kernel.org, x86@kernel.org,
Russell King <linux@armlinux.org.uk>,
linux-csky@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
linux-snps-arc@lists.infradead.org,
linux-xtensa@linux-xtensa.org,
"Paul E. McKenney" <paulmck@kernel.org>,
Frederic Weisbecker <frederic@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
openrisc@lists.librecores.org, Borislav Petkov <bp@alien8.de>,
Nicholas Piggin <npiggin@gmail.com>,
loongarch@lists.linux.dev, Thomas Gleixner <tglx@linutronix.de>,
linux-arm-kernel@lists.infradead.org,
linux-parisc@vger.kernel. org,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 10:08:15 +0100 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
x86@kernel.org, "Paul E. McKenney" <paulmck@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
"H. Peter Anvin" <hpa@zytor.com>, Marc Zyngier <maz@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Russell King <linux@armlinux.org.uk>,
Nicholas Piggin <npiggin@gmail.com>, Guo Ren <guoren@kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 09:08:15 +0000 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Valentin Schneider <vschneid@redhat.com>
Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-snps-arc@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org,
linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org,
loongarch@lists.linux.dev, linux-mips@vger.kernel.org,
openrisc@lists.librecores.org, linux-parisc@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
linux-s390@vger.kernel.org, linux-sh@vger.kernel.org,
sparclinux@vger.kernel.org, linux-xtensa@linux-xtensa.org,
x86@kernel.org, "Paul E. McKenney" <paulmck@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Juri Lelli <juri.lelli@redhat.com>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
Frederic Weisbecker <frederic@kernel.org>, Ingo Molnar <mi>
Subject: Re: [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask()
Date: Thu, 17 Nov 2022 10:08:15 +0100 [thread overview]
Message-ID: <Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20221102183336.3120536-3-vschneid@redhat.com>
On Wed, Nov 02, 2022 at 06:33:32PM +0000, Valentin Schneider wrote:
> This simply wraps around the arch function and prepends it with a
> tracepoint, similar to send_call_function_single_ipi().
>
> Signed-off-by: Valentin Schneider <vschneid@redhat.com>
> ---
> kernel/smp.c | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
> diff --git a/kernel/smp.c b/kernel/smp.c
> index e2ca1e2f31274..c4d561cf50d45 100644
> --- a/kernel/smp.c
> +++ b/kernel/smp.c
> @@ -160,6 +160,13 @@ void __init call_function_init(void)
> smpcfd_prepare_cpu(smp_processor_id());
> }
>
> +static inline void
Given the use of _RET_IP_, I would strongly recommend you use
__always_inline.
> +send_call_function_ipi_mask(const struct cpumask *mask)
> +{
> + trace_ipi_send_cpumask(mask, _RET_IP_, func);
What's func?
> + arch_send_call_function_ipi_mask(mask);
> +}
next prev parent reply other threads:[~2022-11-17 9:08 UTC|newest]
Thread overview: 131+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-02 18:29 [RFC PATCH v2 0/8] Generic IPI sending tracepoint Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:29 ` [RFC PATCH v2 1/8] DO-NOT-MERGE: tracing: Add __cpumask to denote a trace event field that is a cpumask_t Valentin Schneider
2022-11-02 18:29 ` [RFC PATCH v2 1/8] DO-NOT-MERGE: tracing: Add __cpumask to denote a trace event field that is a cpum Valentin Schneider
2022-11-02 18:29 ` [RFC PATCH v2 1/8] DO-NOT-MERGE: tracing: Add __cpumask to denote a trace event field that is a cpumask_t Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:29 ` Valentin Schneider
2022-11-02 18:33 ` [RFC PATCH v2 2/8] trace: Add trace_ipi_send_cpumask() Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` [RFC PATCH v2 3/8] sched, smp: Trace IPIs sent via send_call_function_single_ipi() Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` [RFC PATCH v2 4/8] smp: Trace IPIs sent via arch_send_call_function_ipi_mask() Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-17 9:08 ` Peter Zijlstra [this message]
2022-11-17 9:08 ` Peter Zijlstra
2022-11-17 9:08 ` Peter Zijlstra
2022-11-17 9:08 ` Peter Zijlstra
2022-11-17 9:08 ` Peter Zijlstra
2022-11-17 9:08 ` Peter Zijlstra
2022-11-17 9:08 ` Peter Zijlstra
2022-11-17 9:08 ` Peter Zijlstra
2022-11-17 14:23 ` Valentin Schneider
2022-11-17 14:23 ` Valentin Schneider
2022-11-17 14:23 ` Valentin Schneider
2022-11-17 14:23 ` Valentin Schneider
2022-11-17 14:23 ` Valentin Schneider
2022-11-17 14:23 ` Valentin Schneider
2022-11-17 14:23 ` Valentin Schneider
2022-11-02 18:33 ` [RFC PATCH v2 5/8] irq_work: Trace self-IPIs sent via arch_irq_work_raise() Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-17 9:10 ` Peter Zijlstra
2022-11-17 9:10 ` Peter Zijlstra
2022-11-17 9:10 ` Peter Zijlstra
2022-11-17 9:10 ` Peter Zijlstra
2022-11-17 9:10 ` Peter Zijlstra
2022-11-17 9:10 ` Peter Zijlstra
2022-11-17 9:10 ` Peter Zijlstra
2022-11-17 9:10 ` Peter Zijlstra
2022-11-02 18:33 ` [RFC PATCH v2 6/8] treewide: Trace IPIs sent via smp_send_reschedule() Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 9:12 ` Peter Zijlstra
2022-11-17 14:24 ` Valentin Schneider
2022-11-17 14:24 ` Valentin Schneider
2022-11-17 14:24 ` Valentin Schneider
2022-11-17 14:24 ` Valentin Schneider
2022-11-17 14:24 ` Valentin Schneider
2022-11-17 14:24 ` Valentin Schneider
2022-11-02 18:33 ` [RFC PATCH v2 7/8] smp: reword smp call IPI comment Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` [RFC PATCH v2 8/8] sched, smp: Trace smp callback causing an IPI Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-02 18:33 ` Valentin Schneider
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:12 ` Peter Zijlstra
2022-11-17 14:45 ` Valentin Schneider
2022-11-17 14:45 ` Valentin Schneider
2022-11-17 14:45 ` Valentin Schneider
2022-11-17 14:45 ` Valentin Schneider
2022-11-17 14:45 ` Valentin Schneider
2022-11-17 14:45 ` Valentin Schneider
2022-11-17 14:45 ` Valentin Schneider
2022-11-17 14:45 ` Valentin Schneider
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 9:12 ` Peter Zijlstra
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-18 16:42 ` Daniel Bristot de Oliveira
2022-11-14 17:27 ` [RFC PATCH v2 0/8] Generic IPI sending tracepoint Steven Rostedt
2022-11-14 17:27 ` Steven Rostedt
2022-11-14 17:27 ` Steven Rostedt
2022-11-14 17:27 ` Steven Rostedt
2022-11-14 17:27 ` Steven Rostedt
2022-11-14 17:27 ` Steven Rostedt
2022-11-14 17:27 ` Steven Rostedt
2022-11-14 17:27 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y3X5/65o8127DgZl@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=bigeasy@linutronix.de \
--cc=bp@alien8.de \
--cc=bristot@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=davem@davemloft.net \
--cc=frederic@kernel.org \
--cc=guoren@kernel.org \
--cc=hpa@zytor.com \
--cc=juri.lelli@redhat.com \
--cc=linux-alpha@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-csky@vger.kernel.org \
--cc=linux-hexagon@vger.kernel.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=linux-xtensa@linux-xtensa.org \
--cc=linux@armlinux.org.uk \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mark.rutland@arm.com \
--cc=maz@kernel.org \
--cc=mingo@redhat.com \
--cc=mtosatti@redhat.com \
--cc=npiggin@gmail.com \
--cc=openrisc@lists.librecores.org \
--cc=paulmck@kernel.org \
--cc=rostedt@goodmis.org \
--cc=sparclinux@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=vschneid@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.