* [PATCH] proc/meminfo: fix spacing in SecPageTables
@ 2022-11-17 4:32 Yosry Ahmed
2022-11-17 13:27 ` Johannes Weiner
2022-11-18 16:30 ` Shakeel Butt
0 siblings, 2 replies; 3+ messages in thread
From: Yosry Ahmed @ 2022-11-17 4:32 UTC (permalink / raw)
To: David Hildenbrand, Andrew Morton, Johannes Weiner,
Sean Christopherson, Shakeel Butt, Marc Zyngier
Cc: linux-kernel, linux-fsdevel, linux-mm, Yosry Ahmed
SecPageTables has a tab after it instead of a space, this can break
fragile parsers that depend on spaces after the stat names.
Fixes: ebc97a ("mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses.")
Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
---
The commit this fixes is in 6.1, so I hope this can also land in 6.1.
---
fs/proc/meminfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/meminfo.c b/fs/proc/meminfo.c
index 5101131e6047..440960110a42 100644
--- a/fs/proc/meminfo.c
+++ b/fs/proc/meminfo.c
@@ -115,7 +115,7 @@ static int meminfo_proc_show(struct seq_file *m, void *v)
#endif
show_val_kb(m, "PageTables: ",
global_node_page_state(NR_PAGETABLE));
- show_val_kb(m, "SecPageTables: ",
+ show_val_kb(m, "SecPageTables: ",
global_node_page_state(NR_SECONDARY_PAGETABLE));
show_val_kb(m, "NFS_Unstable: ", 0);
--
2.38.1.431.g37b22c650d-goog
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] proc/meminfo: fix spacing in SecPageTables
2022-11-17 4:32 [PATCH] proc/meminfo: fix spacing in SecPageTables Yosry Ahmed
@ 2022-11-17 13:27 ` Johannes Weiner
2022-11-18 16:30 ` Shakeel Butt
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Weiner @ 2022-11-17 13:27 UTC (permalink / raw)
To: Yosry Ahmed
Cc: David Hildenbrand, Andrew Morton, Sean Christopherson,
Shakeel Butt, Marc Zyngier, linux-kernel, linux-fsdevel,
linux-mm
On Thu, Nov 17, 2022 at 04:32:47AM +0000, Yosry Ahmed wrote:
> SecPageTables has a tab after it instead of a space, this can break
> fragile parsers that depend on spaces after the stat names.
>
> Fixes: ebc97a ("mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses.")
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] proc/meminfo: fix spacing in SecPageTables
2022-11-17 4:32 [PATCH] proc/meminfo: fix spacing in SecPageTables Yosry Ahmed
2022-11-17 13:27 ` Johannes Weiner
@ 2022-11-18 16:30 ` Shakeel Butt
1 sibling, 0 replies; 3+ messages in thread
From: Shakeel Butt @ 2022-11-18 16:30 UTC (permalink / raw)
To: Yosry Ahmed
Cc: David Hildenbrand, Andrew Morton, Johannes Weiner,
Sean Christopherson, Marc Zyngier, linux-kernel, linux-fsdevel,
linux-mm
On Wed, Nov 16, 2022 at 8:32 PM Yosry Ahmed <yosryahmed@google.com> wrote:
>
> SecPageTables has a tab after it instead of a space, this can break
> fragile parsers that depend on spaces after the stat names.
>
> Fixes: ebc97a ("mm: add NR_SECONDARY_PAGETABLE to count secondary page table uses.")
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
Acked-by: Shakeel Butt <shakeelb@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-18 16:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-17 4:32 [PATCH] proc/meminfo: fix spacing in SecPageTables Yosry Ahmed
2022-11-17 13:27 ` Johannes Weiner
2022-11-18 16:30 ` Shakeel Butt
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.