* [PATCH] crypto: virtio - Use helper to set reqsize
@ 2022-11-22 9:42 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2022-11-22 9:42 UTC (permalink / raw)
To: Gonglei, virtualization, Linux Crypto Mailing List
The value of reqsize must only be changed through the helper.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
index 168195672e2e..b2979be613b8 100644
--- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
+++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
@@ -479,6 +479,9 @@ static int virtio_crypto_rsa_init_tfm(struct crypto_akcipher *tfm)
ctx->enginectx.op.prepare_request = NULL;
ctx->enginectx.op.unprepare_request = NULL;
+ akcipher_set_reqsize(tfm,
+ sizeof(struct virtio_crypto_akcipher_request));
+
return 0;
}
@@ -505,7 +508,6 @@ static struct virtio_crypto_akcipher_algo virtio_crypto_akcipher_algs[] = {
.max_size = virtio_crypto_rsa_max_size,
.init = virtio_crypto_rsa_init_tfm,
.exit = virtio_crypto_rsa_exit_tfm,
- .reqsize = sizeof(struct virtio_crypto_akcipher_request),
.base = {
.cra_name = "rsa",
.cra_driver_name = "virtio-crypto-rsa",
@@ -528,7 +530,6 @@ static struct virtio_crypto_akcipher_algo virtio_crypto_akcipher_algs[] = {
.max_size = virtio_crypto_rsa_max_size,
.init = virtio_crypto_rsa_init_tfm,
.exit = virtio_crypto_rsa_exit_tfm,
- .reqsize = sizeof(struct virtio_crypto_akcipher_request),
.base = {
.cra_name = "pkcs1pad(rsa,sha1)",
.cra_driver_name = "virtio-pkcs1-rsa-with-sha1",
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] crypto: virtio - Use helper to set reqsize
@ 2022-11-22 9:42 ` Herbert Xu
0 siblings, 0 replies; 4+ messages in thread
From: Herbert Xu @ 2022-11-22 9:42 UTC (permalink / raw)
To: Gonglei, virtualization, Linux Crypto Mailing List
The value of reqsize must only be changed through the helper.
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
index 168195672e2e..b2979be613b8 100644
--- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
+++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
@@ -479,6 +479,9 @@ static int virtio_crypto_rsa_init_tfm(struct crypto_akcipher *tfm)
ctx->enginectx.op.prepare_request = NULL;
ctx->enginectx.op.unprepare_request = NULL;
+ akcipher_set_reqsize(tfm,
+ sizeof(struct virtio_crypto_akcipher_request));
+
return 0;
}
@@ -505,7 +508,6 @@ static struct virtio_crypto_akcipher_algo virtio_crypto_akcipher_algs[] = {
.max_size = virtio_crypto_rsa_max_size,
.init = virtio_crypto_rsa_init_tfm,
.exit = virtio_crypto_rsa_exit_tfm,
- .reqsize = sizeof(struct virtio_crypto_akcipher_request),
.base = {
.cra_name = "rsa",
.cra_driver_name = "virtio-crypto-rsa",
@@ -528,7 +530,6 @@ static struct virtio_crypto_akcipher_algo virtio_crypto_akcipher_algs[] = {
.max_size = virtio_crypto_rsa_max_size,
.init = virtio_crypto_rsa_init_tfm,
.exit = virtio_crypto_rsa_exit_tfm,
- .reqsize = sizeof(struct virtio_crypto_akcipher_request),
.base = {
.cra_name = "pkcs1pad(rsa,sha1)",
.cra_driver_name = "virtio-pkcs1-rsa-with-sha1",
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply related [flat|nested] 4+ messages in thread* RE: [PATCH] crypto: virtio - Use helper to set reqsize
2022-11-22 9:42 ` Herbert Xu
@ 2022-11-23 1:11 ` Gonglei (Arei)
-1 siblings, 0 replies; 4+ messages in thread
From: Gonglei (Arei) via Virtualization @ 2022-11-23 1:11 UTC (permalink / raw)
To: Herbert Xu, virtualization, Linux Crypto Mailing List
> -----Original Message-----
> From: Herbert Xu [mailto:herbert@gondor.apana.org.au]
> Sent: Tuesday, November 22, 2022 5:42 PM
> To: Gonglei (Arei) <arei.gonglei@huawei.com>;
> virtualization@lists.linux-foundation.org; Linux Crypto Mailing List
> <linux-crypto@vger.kernel.org>
> Subject: [PATCH] crypto: virtio - Use helper to set reqsize
>
> The value of reqsize must only be changed through the helper.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> index 168195672e2e..b2979be613b8 100644
> --- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> +++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> @@ -479,6 +479,9 @@ static int virtio_crypto_rsa_init_tfm(struct
> crypto_akcipher *tfm)
> ctx->enginectx.op.prepare_request = NULL;
> ctx->enginectx.op.unprepare_request = NULL;
>
> + akcipher_set_reqsize(tfm,
> + sizeof(struct virtio_crypto_akcipher_request));
> +
> return 0;
> }
>
> @@ -505,7 +508,6 @@ static struct virtio_crypto_akcipher_algo
> virtio_crypto_akcipher_algs[] = {
> .max_size = virtio_crypto_rsa_max_size,
> .init = virtio_crypto_rsa_init_tfm,
> .exit = virtio_crypto_rsa_exit_tfm,
> - .reqsize = sizeof(struct virtio_crypto_akcipher_request),
> .base = {
> .cra_name = "rsa",
> .cra_driver_name = "virtio-crypto-rsa", @@ -528,7
> +530,6 @@ static struct virtio_crypto_akcipher_algo
> virtio_crypto_akcipher_algs[] = {
> .max_size = virtio_crypto_rsa_max_size,
> .init = virtio_crypto_rsa_init_tfm,
> .exit = virtio_crypto_rsa_exit_tfm,
> - .reqsize = sizeof(struct virtio_crypto_akcipher_request),
> .base = {
> .cra_name = "pkcs1pad(rsa,sha1)",
> .cra_driver_name = "virtio-pkcs1-rsa-with-sha1",
> --
Acked-by: Gonglei <arei.gonglei@huawei.com>
Regards,
-Gonglei
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH] crypto: virtio - Use helper to set reqsize
@ 2022-11-23 1:11 ` Gonglei (Arei)
0 siblings, 0 replies; 4+ messages in thread
From: Gonglei (Arei) @ 2022-11-23 1:11 UTC (permalink / raw)
To: Herbert Xu, virtualization, Linux Crypto Mailing List
> -----Original Message-----
> From: Herbert Xu [mailto:herbert@gondor.apana.org.au]
> Sent: Tuesday, November 22, 2022 5:42 PM
> To: Gonglei (Arei) <arei.gonglei@huawei.com>;
> virtualization@lists.linux-foundation.org; Linux Crypto Mailing List
> <linux-crypto@vger.kernel.org>
> Subject: [PATCH] crypto: virtio - Use helper to set reqsize
>
> The value of reqsize must only be changed through the helper.
>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>
> diff --git a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> index 168195672e2e..b2979be613b8 100644
> --- a/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> +++ b/drivers/crypto/virtio/virtio_crypto_akcipher_algs.c
> @@ -479,6 +479,9 @@ static int virtio_crypto_rsa_init_tfm(struct
> crypto_akcipher *tfm)
> ctx->enginectx.op.prepare_request = NULL;
> ctx->enginectx.op.unprepare_request = NULL;
>
> + akcipher_set_reqsize(tfm,
> + sizeof(struct virtio_crypto_akcipher_request));
> +
> return 0;
> }
>
> @@ -505,7 +508,6 @@ static struct virtio_crypto_akcipher_algo
> virtio_crypto_akcipher_algs[] = {
> .max_size = virtio_crypto_rsa_max_size,
> .init = virtio_crypto_rsa_init_tfm,
> .exit = virtio_crypto_rsa_exit_tfm,
> - .reqsize = sizeof(struct virtio_crypto_akcipher_request),
> .base = {
> .cra_name = "rsa",
> .cra_driver_name = "virtio-crypto-rsa", @@ -528,7
> +530,6 @@ static struct virtio_crypto_akcipher_algo
> virtio_crypto_akcipher_algs[] = {
> .max_size = virtio_crypto_rsa_max_size,
> .init = virtio_crypto_rsa_init_tfm,
> .exit = virtio_crypto_rsa_exit_tfm,
> - .reqsize = sizeof(struct virtio_crypto_akcipher_request),
> .base = {
> .cra_name = "pkcs1pad(rsa,sha1)",
> .cra_driver_name = "virtio-pkcs1-rsa-with-sha1",
> --
Acked-by: Gonglei <arei.gonglei@huawei.com>
Regards,
-Gonglei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-23 1:13 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-22 9:42 [PATCH] crypto: virtio - Use helper to set reqsize Herbert Xu
2022-11-22 9:42 ` Herbert Xu
2022-11-23 1:11 ` Gonglei (Arei) via Virtualization
2022-11-23 1:11 ` Gonglei (Arei)
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.