* [PATCH] crypto: ccree - Make cc_debugfs_global_fini() available for module init function
@ 2022-11-21 17:22 Uwe Kleine-König
2022-11-22 10:14 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Uwe Kleine-König @ 2022-11-21 17:22 UTC (permalink / raw)
To: Gilad Ben-Yossef, Herbert Xu, David S. Miller
Cc: Gaosheng Cui, linux-crypto, kernel
ccree_init() calls cc_debugfs_global_fini(), the former is an init
function and the latter an exit function though.
A modular build emits:
WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in reference: init_module (section: .init.text) -> cc_debugfs_global_fini (section: .exit.text)
(with CONFIG_DEBUG_SECTION_MISMATCH=y).
Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
drivers/crypto/ccree/cc_debugfs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/ccree/cc_debugfs.c b/drivers/crypto/ccree/cc_debugfs.c
index 7083767602fc..8f008f024f8f 100644
--- a/drivers/crypto/ccree/cc_debugfs.c
+++ b/drivers/crypto/ccree/cc_debugfs.c
@@ -55,7 +55,7 @@ void __init cc_debugfs_global_init(void)
cc_debugfs_dir = debugfs_create_dir("ccree", NULL);
}
-void __exit cc_debugfs_global_fini(void)
+void cc_debugfs_global_fini(void)
{
debugfs_remove(cc_debugfs_dir);
}
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] crypto: ccree - Make cc_debugfs_global_fini() available for module init function
2022-11-21 17:22 [PATCH] crypto: ccree - Make cc_debugfs_global_fini() available for module init function Uwe Kleine-König
@ 2022-11-22 10:14 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2022-11-22 10:14 UTC (permalink / raw)
To: Uwe Kleine-König
Cc: Gilad Ben-Yossef, David S. Miller, Gaosheng Cui, linux-crypto, kernel
On Mon, Nov 21, 2022 at 06:22:36PM +0100, Uwe Kleine-König wrote:
> ccree_init() calls cc_debugfs_global_fini(), the former is an init
> function and the latter an exit function though.
>
> A modular build emits:
>
> WARNING: modpost: drivers/crypto/ccree/ccree.o: section mismatch in reference: init_module (section: .init.text) -> cc_debugfs_global_fini (section: .exit.text)
>
> (with CONFIG_DEBUG_SECTION_MISMATCH=y).
>
> Fixes: 4f1c596df706 ("crypto: ccree - Remove debugfs when platform_driver_register failed")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> drivers/crypto/ccree/cc_debugfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-22 10:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-21 17:22 [PATCH] crypto: ccree - Make cc_debugfs_global_fini() available for module init function Uwe Kleine-König
2022-11-22 10:14 ` Herbert Xu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.