* [PATCH] cxl/regs: Fix sparse warning
@ 2022-12-03 17:14 Dan Williams
2022-12-03 19:59 ` Alison Schofield
2022-12-05 12:02 ` Robert Richter
0 siblings, 2 replies; 3+ messages in thread
From: Dan Williams @ 2022-12-03 17:14 UTC (permalink / raw)
To: linux-cxl; +Cc: kernel test robot, rrichter, terry.bowman
The 0day robot belatedly points out that @addr is not properly tagged as
an iomap pointer:
"drivers/cxl/core/regs.c:332:14: sparse: sparse: incorrect type in
assignment (different address spaces) @@ expected void *addr @@
got void [noderef] __iomem * @@"
Fixes: 1168271ca054 ("cxl/acpi: Extract component registers of restricted hosts from RCRB")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
---
drivers/cxl/core/regs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c
index 1173912b9cf7..5a812583aee1 100644
--- a/drivers/cxl/core/regs.c
+++ b/drivers/cxl/core/regs.c
@@ -313,8 +313,8 @@ resource_size_t cxl_rcrb_to_component(struct device *dev,
enum cxl_rcrb which)
{
resource_size_t component_reg_phys;
+ void __iomem *addr;
u32 bar0, bar1;
- void *addr;
u16 cmd;
u32 id;
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cxl/regs: Fix sparse warning
2022-12-03 17:14 [PATCH] cxl/regs: Fix sparse warning Dan Williams
@ 2022-12-03 19:59 ` Alison Schofield
2022-12-05 12:02 ` Robert Richter
1 sibling, 0 replies; 3+ messages in thread
From: Alison Schofield @ 2022-12-03 19:59 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-cxl, kernel test robot, rrichter, terry.bowman
On Sat, Dec 03, 2022 at 09:14:41AM -0800, Dan Williams wrote:
> The 0day robot belatedly points out that @addr is not properly tagged as
> an iomap pointer:
>
> "drivers/cxl/core/regs.c:332:14: sparse: sparse: incorrect type in
> assignment (different address spaces) @@ expected void *addr @@
> got void [noderef] __iomem * @@"
>
> Fixes: 1168271ca054 ("cxl/acpi: Extract component registers of restricted hosts from RCRB")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
> ---
> drivers/cxl/core/regs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c
> index 1173912b9cf7..5a812583aee1 100644
> --- a/drivers/cxl/core/regs.c
> +++ b/drivers/cxl/core/regs.c
> @@ -313,8 +313,8 @@ resource_size_t cxl_rcrb_to_component(struct device *dev,
> enum cxl_rcrb which)
> {
> resource_size_t component_reg_phys;
> + void __iomem *addr;
> u32 bar0, bar1;
> - void *addr;
> u16 cmd;
> u32 id;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cxl/regs: Fix sparse warning
2022-12-03 17:14 [PATCH] cxl/regs: Fix sparse warning Dan Williams
2022-12-03 19:59 ` Alison Schofield
@ 2022-12-05 12:02 ` Robert Richter
1 sibling, 0 replies; 3+ messages in thread
From: Robert Richter @ 2022-12-05 12:02 UTC (permalink / raw)
To: Dan Williams; +Cc: linux-cxl, kernel test robot, terry.bowman
On 03.12.22 09:14:41, Dan Williams wrote:
> The 0day robot belatedly points out that @addr is not properly tagged as
> an iomap pointer:
>
> "drivers/cxl/core/regs.c:332:14: sparse: sparse: incorrect type in
> assignment (different address spaces) @@ expected void *addr @@
> got void [noderef] __iomem * @@"
>
> Fixes: 1168271ca054 ("cxl/acpi: Extract component registers of restricted hosts from RCRB")
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Reviewed-by: Robert Richter <rrichter@amd.com>
> ---
> drivers/cxl/core/regs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-12-05 12:03 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-03 17:14 [PATCH] cxl/regs: Fix sparse warning Dan Williams
2022-12-03 19:59 ` Alison Schofield
2022-12-05 12:02 ` Robert Richter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.