From: Peter Xu <peterx@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: mst@redhat.com, qemu-devel@nongnu.org, eric.auger@redhat.com,
viktor@daynix.com
Subject: Re: [PATCH 2/3] intel-iommu: fail DEVIOTLB_UNMAP without dt mode
Date: Tue, 29 Nov 2022 10:38:50 -0500 [thread overview]
Message-ID: <Y4YnihBw2DBi/7wz@x1n> (raw)
In-Reply-To: <20221129081037.12099-3-jasowang@redhat.com>
On Tue, Nov 29, 2022 at 04:10:36PM +0800, Jason Wang wrote:
> Without dt mode, device IOTLB notifier won't work since guest won't
> send device IOTLB invalidation descriptor in this case. Let's fail
> early instead of misbehaving silently.
>
> Signed-off-by: Jason Wang <jasowang@redhat.com>
> ---
> hw/i386/intel_iommu.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index 9143376677..d025ef2873 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -3179,6 +3179,7 @@ static int vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
> {
> VTDAddressSpace *vtd_as = container_of(iommu, VTDAddressSpace, iommu);
> IntelIOMMUState *s = vtd_as->iommu_state;
> + X86IOMMUState *x86_iommu = X86_IOMMU_DEVICE(s);
>
> /* TODO: add support for VFIO and vhost users */
> if (s->snoop_control) {
> @@ -3193,6 +3194,13 @@ static int vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
> PCI_FUNC(vtd_as->devfn));
> return -ENOTSUP;
> }
> + if (!x86_iommu->dt_supported && (new & IOMMU_NOTIFIER_DEVIOTLB_UNMAP)) {
> + error_setg_errno(errp, ENOTSUP,
> + "device %02x.%02x.%x requires device IOTLB mode",
> + pci_bus_num(vtd_as->bus), PCI_SLOT(vtd_as->devfn),
> + PCI_FUNC(vtd_as->devfn));
> + return -ENOTSUP;
> + }
Hmm I thought we have had this already, so we don't?... :-(
Reviewed-by: Peter Xu <peterx@redhat.com>
--
Peter Xu
next prev parent reply other threads:[~2022-11-29 15:39 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 8:10 [PATCH 0/3] Fix UNMAP notifier for intel-iommu Jason Wang
2022-11-29 8:10 ` [PATCH 1/3] intel-iommu: fail MAP notifier without caching mode Jason Wang
2022-11-29 15:35 ` Peter Xu
2022-11-30 6:23 ` Jason Wang
2022-11-30 15:06 ` Peter Xu
2022-12-01 8:46 ` Jason Wang
2022-12-06 13:23 ` Eric Auger
2022-11-29 8:10 ` [PATCH 2/3] intel-iommu: fail DEVIOTLB_UNMAP without dt mode Jason Wang
2022-11-29 15:38 ` Peter Xu [this message]
2022-12-01 16:03 ` Peter Xu
2023-02-23 3:19 ` Jason Wang
2022-12-06 13:33 ` Eric Auger
2023-02-03 9:08 ` Laurent Vivier
2023-02-07 16:17 ` Laurent Vivier
2023-02-07 16:35 ` Peter Xu
2022-11-29 8:10 ` [PATCH 3/3] intel-iommu: build iova tree during IOMMU translation Jason Wang
2022-11-29 15:57 ` Peter Xu
2022-11-30 6:33 ` Jason Wang
2022-11-30 15:17 ` Peter Xu
2022-12-01 8:35 ` Jason Wang
2022-12-01 14:58 ` Peter Xu
2022-12-05 4:12 ` Jason Wang
2022-12-05 23:18 ` Peter Xu
2022-12-06 3:18 ` Jason Wang
2022-12-06 13:58 ` Peter Xu
2022-12-23 8:02 ` Jason Wang
2022-12-23 16:22 ` Peter Xu
2022-11-30 16:37 ` [PATCH 0/3] Fix UNMAP notifier for intel-iommu Michael S. Tsirkin
2022-12-01 8:29 ` Jason Wang
2022-12-20 13:53 ` Michael S. Tsirkin
2022-12-21 3:17 ` Jason Wang
2023-01-15 23:30 ` Viktor Prutyanov
2023-01-16 7:06 ` Jason Wang
2023-01-27 13:17 ` Michael S. Tsirkin
2023-01-29 5:43 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y4YnihBw2DBi/7wz@x1n \
--to=peterx@redhat.com \
--cc=eric.auger@redhat.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=viktor@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.