* [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
@ 2022-11-27 16:16 Christophe JAILLET
2022-11-28 4:27 ` Pavan Chebbi
0 siblings, 1 reply; 4+ messages in thread
From: Christophe JAILLET @ 2022-11-27 16:16 UTC (permalink / raw)
To: Saeed Mahameed, Leon Romanovsky, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni
Cc: linux-kernel, kernel-janitors, Christophe JAILLET, netdev, linux-rdma
The mlx5 net files don't use io_mapping functionalities. So there is no
point in including <linux/io-mapping.h>.
Remove it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 1 -
drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
drivers/net/ethernet/mellanox/mlx5/core/uar.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
index 74bd05e5dda2..597907fd63f5 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
@@ -37,7 +37,6 @@
#include <linux/slab.h>
#include <linux/delay.h>
#include <linux/random.h>
-#include <linux/io-mapping.h>
#include <linux/mlx5/driver.h>
#include <linux/mlx5/eq.h>
#include <linux/debugfs.h>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
index 70e8dc305bec..25e87e5d9270 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
@@ -37,7 +37,6 @@
#include <linux/pci.h>
#include <linux/dma-mapping.h>
#include <linux/slab.h>
-#include <linux/io-mapping.h>
#include <linux/interrupt.h>
#include <linux/delay.h>
#include <linux/mlx5/driver.h>
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
index 8455e79bc44a..1513112ecec8 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
@@ -31,7 +31,6 @@
*/
#include <linux/kernel.h>
-#include <linux/io-mapping.h>
#include <linux/mlx5/driver.h>
#include "mlx5_core.h"
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
2022-11-27 16:16 [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include Christophe JAILLET
@ 2022-11-28 4:27 ` Pavan Chebbi
2022-11-28 4:57 ` Pavan Chebbi
0 siblings, 1 reply; 4+ messages in thread
From: Pavan Chebbi @ 2022-11-28 4:27 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Saeed Mahameed, Leon Romanovsky, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-kernel, kernel-janitors,
netdev, linux-rdma
[-- Attachment #1: Type: text/plain, Size: 1973 bytes --]
On Sun, Nov 27, 2022 at 9:47 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> The mlx5 net files don't use io_mapping functionalities. So there is no
> point in including <linux/io-mapping.h>.
> Remove it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 1 -
> drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> drivers/net/ethernet/mellanox/mlx5/core/uar.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> index 74bd05e5dda2..597907fd63f5 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> @@ -37,7 +37,6 @@
> #include <linux/slab.h>
> #include <linux/delay.h>
> #include <linux/random.h>
> -#include <linux/io-mapping.h>
> #include <linux/mlx5/driver.h>
> #include <linux/mlx5/eq.h>
> #include <linux/debugfs.h>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 70e8dc305bec..25e87e5d9270 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -37,7 +37,6 @@
> #include <linux/pci.h>
> #include <linux/dma-mapping.h>
> #include <linux/slab.h>
> -#include <linux/io-mapping.h>
> #include <linux/interrupt.h>
> #include <linux/delay.h>
> #include <linux/mlx5/driver.h>
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> index 8455e79bc44a..1513112ecec8 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> @@ -31,7 +31,6 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/io-mapping.h>
> #include <linux/mlx5/driver.h>
> #include "mlx5_core.h"
>
> --
> 2.34.1
>
Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
2022-11-28 4:27 ` Pavan Chebbi
@ 2022-11-28 4:57 ` Pavan Chebbi
2022-11-30 4:20 ` Saeed Mahameed
0 siblings, 1 reply; 4+ messages in thread
From: Pavan Chebbi @ 2022-11-28 4:57 UTC (permalink / raw)
To: Christophe JAILLET
Cc: Saeed Mahameed, Leon Romanovsky, David S. Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, linux-kernel, kernel-janitors,
netdev, linux-rdma
[-- Attachment #1: Type: text/plain, Size: 2302 bytes --]
Though I think having the target tree specified conventionally in the
subject line [PATCH net] would be more complying with the process.
On Mon, Nov 28, 2022 at 9:57 AM Pavan Chebbi <pavan.chebbi@broadcom.com> wrote:
>
> On Sun, Nov 27, 2022 at 9:47 PM Christophe JAILLET
> <christophe.jaillet@wanadoo.fr> wrote:
> >
> > The mlx5 net files don't use io_mapping functionalities. So there is no
> > point in including <linux/io-mapping.h>.
> > Remove it.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> > ---
> > drivers/net/ethernet/mellanox/mlx5/core/cmd.c | 1 -
> > drivers/net/ethernet/mellanox/mlx5/core/main.c | 1 -
> > drivers/net/ethernet/mellanox/mlx5/core/uar.c | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > index 74bd05e5dda2..597907fd63f5 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/cmd.c
> > @@ -37,7 +37,6 @@
> > #include <linux/slab.h>
> > #include <linux/delay.h>
> > #include <linux/random.h>
> > -#include <linux/io-mapping.h>
> > #include <linux/mlx5/driver.h>
> > #include <linux/mlx5/eq.h>
> > #include <linux/debugfs.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > index 70e8dc305bec..25e87e5d9270 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> > @@ -37,7 +37,6 @@
> > #include <linux/pci.h>
> > #include <linux/dma-mapping.h>
> > #include <linux/slab.h>
> > -#include <linux/io-mapping.h>
> > #include <linux/interrupt.h>
> > #include <linux/delay.h>
> > #include <linux/mlx5/driver.h>
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/uar.c b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > index 8455e79bc44a..1513112ecec8 100644
> > --- a/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > +++ b/drivers/net/ethernet/mellanox/mlx5/core/uar.c
> > @@ -31,7 +31,6 @@
> > */
> >
> > #include <linux/kernel.h>
> > -#include <linux/io-mapping.h>
> > #include <linux/mlx5/driver.h>
> > #include "mlx5_core.h"
> >
> > --
> > 2.34.1
> >
>
> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4209 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include
2022-11-28 4:57 ` Pavan Chebbi
@ 2022-11-30 4:20 ` Saeed Mahameed
0 siblings, 0 replies; 4+ messages in thread
From: Saeed Mahameed @ 2022-11-30 4:20 UTC (permalink / raw)
To: Pavan Chebbi
Cc: Christophe JAILLET, Saeed Mahameed, Leon Romanovsky,
David S. Miller, Eric Dumazet, Jakub Kicinski, Paolo Abeni,
linux-kernel, kernel-janitors, netdev, linux-rdma
On 28 Nov 10:27, Pavan Chebbi wrote:
>Though I think having the target tree specified conventionally in the
>subject line [PATCH net] would be more complying with the process.
For such cleanup patches I think [PATCH net-next] is better.
[...]
>>
>> Reviewed-by: Pavan Chebbi <pavan.chebbi@broadcom.com>
Thanks you Pavan & Christophe
applied to net-next-mlx5 will be sent to net-next shortly
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-11-30 4:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-27 16:16 [PATCH] net/mlx5e: Remove unneeded io-mapping.h #include Christophe JAILLET
2022-11-28 4:27 ` Pavan Chebbi
2022-11-28 4:57 ` Pavan Chebbi
2022-11-30 4:20 ` Saeed Mahameed
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.