From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Hanna Hawa <hhhawa@amazon.com>
Cc: jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
jsd@semihalf.com, linux-i2c@vger.kernel.org,
linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, benh@amazon.com,
ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com,
hanochu@amazon.com, farbere@amazon.com, itamark@amazon.com
Subject: Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl
Date: Wed, 14 Dec 2022 18:09:55 +0200 [thread overview]
Message-ID: <Y5n1U1lYbcbJ5U1k@smile.fi.intel.com> (raw)
In-Reply-To: <20221214142725.23881-1-hhhawa@amazon.com>
On Wed, Dec 14, 2022 at 02:27:25PM +0000, Hanna Hawa wrote:
> The current implementation of designware recovery mechanism fit for
> specific device (Intel / Altera Cyclone V SOC) which have two separated
> "wired" GPIOs to the i2c bus via the SOC FPGA for the i2c recovery.
>
> Make pinctrl recovery information to points to the device pinctrl by
> setting the rinfo->pinctrl to dev->pins->p.
> Change Log v1->v2:
> - set the rinfo->pinctrl to dev->pins->p instead calling
> devm_pinctrl_get().
Wrong place for a changelog...
> Signed-off-by: Hanna Hawa <hhhawa@amazon.com>
> ---
...should be located here.
...
> + if (dev->dev->pins && dev->dev->pins->p)
> + rinfo->pinctrl = dev->dev->pins->p;
Hmm... I don't see how this field is being used.
Can you elaborate?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2022-12-14 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 14:27 [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl Hanna Hawa
2022-12-14 16:09 ` Andy Shevchenko [this message]
2022-12-15 8:15 ` Hawa, Hanna
2022-12-15 10:27 ` Andy Shevchenko
2022-12-15 14:06 ` Linus Walleij
2022-12-15 14:25 ` Hawa, Hanna
2022-12-15 15:22 ` Andy Shevchenko
2022-12-16 13:50 ` Hawa, Hanna
2022-12-16 14:46 ` Andy Shevchenko
2022-12-19 19:35 ` Hawa, Hanna
2022-12-20 10:54 ` Andy Shevchenko
2022-12-14 19:14 ` kernel test robot
2022-12-15 0:17 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Y5n1U1lYbcbJ5U1k@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=benh@amazon.com \
--cc=dwmw@amazon.co.uk \
--cc=farbere@amazon.com \
--cc=hanochu@amazon.com \
--cc=hhhawa@amazon.com \
--cc=itamark@amazon.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=jonnyc@amazon.com \
--cc=jsd@semihalf.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=ronenk@amazon.com \
--cc=talel@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.