Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: "Hawa, Hanna" <hhhawa@amazon.com>
Cc: Wolfram Sang <wsa@kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	jarkko.nikula@linux.intel.com, mika.westerberg@linux.intel.com,
	jsd@semihalf.com, linux-i2c@vger.kernel.org,
	linux-kernel@vger.kernel.org, dwmw@amazon.co.uk, benh@amazon.com,
	ronenk@amazon.com, talel@amazon.com, jonnyc@amazon.com,
	hanochu@amazon.com, farbere@amazon.com, itamark@amazon.com
Subject: Re: [PATCH v2 1/1] i2c: designware: set pinctrl recovery information from device pinctrl
Date: Fri, 16 Dec 2022 16:46:41 +0200	[thread overview]
Message-ID: <Y5yE0SsfGrwaB5zA@smile.fi.intel.com> (raw)
In-Reply-To: <1408bbef-10e3-f76b-b66d-b95e84748e18@amazon.com>

On Fri, Dec 16, 2022 at 03:50:19PM +0200, Hawa, Hanna wrote:
> On 12/15/2022 12:27 PM, Andy Shevchenko wrote:
> > OK, but why that function doesn't use the dev->pins->p if it's defined?
> > (As a fallback when rinfo->pinctrl is NULL. >
> 
> The solution will look like the below diff (get_device_pinctrl() is new
> function that i've added that return the dev->pins->p)

Naming is not aligned with a namespace.

I would rather name it dev_pinctrl() and locate it in pinctrl/devinfo.h.

...

> -       struct pinctrl *p = bri->pinctrl;
> +       struct pinctrl *p;
> +
> +       if (!bri->pinctrl)
> +               bri->pinctrl = get_device_pinctrl(dev->parent);
> +       p = bri->pinctrl;

Can be simplified with help of Elvis:

	p = bri->pinctrl ?: dev_pinctrl(dev->parent);

> > Wolfram?
> > 
> > Hanna, it seems you missed I²C maintainer to Cc...
> 
> I based my CC/TO on get_maintainer.pl script. Will make sure that Wolfram on
> CC next time.

All the same about Linus W., who is pin control subsystem maintainer, and be
sure the respective mailing lists are also included.

-- 
With Best Regards,
Andy Shevchenko