All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luis Chamberlain <mcgrof@kernel.org>
To: Bart Van Assche <bvanassche@acm.org>
Cc: osandov@fb.com, linux-block@vger.kernel.org
Subject: Re: [PATCH v2] blktests: replace module removal with patient module removal
Date: Tue, 20 Dec 2022 13:28:43 -0800	[thread overview]
Message-ID: <Y6IpC3Rv5QRSRCs0@bombadil.infradead.org> (raw)
In-Reply-To: <71af1a93-1950-b480-afbb-d61b6590f6fe@acm.org>

On Wed, May 11, 2022 at 11:22:52AM -0700, Bart Van Assche wrote:
> On 5/11/22 10:44, Luis Chamberlain wrote:
> > I suspect you ran into the issue of the refcnt being bumped by anything
> > multipathd tried, and not being able to remove the module, but  if it is
> > adding *new* mpath devices that would seem like a bug which we'd need to
> > address. The point to the patient module removal is to keep on trying
> > until the recnt  is 0 and if that fails wait and keep trying, until the
> > the timeout. Anytihng userspace does, say multipathd does, like
> > bdev_open(), would be yielded to.
> > 
> > So I'd like to keep this change as it is exactly the sort of hack I am
> > chasing after with this crusade.
> > 
> > Let me know how you'd like to proceed so I can punt a v3.
> 
> Please implement the patient module removal and the stop_srp_ini() behavior
> changes as separate patches such that the stop_srp_ini() behavioral changes
> can be reverted easily in case these would trigger a regression.

I had dropped the ball here, because well, it takes a bit of time to
re-test everything. And also just around this time I was also ironing
out how to properly automate testing for srp. That's all done now
and I finally had time to re-test so will send a v3 out shortly.

  Luis

      reply	other threads:[~2022-12-20 21:28 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-16  1:49 [PATCH v2] blktests: replace module removal with patient module removal Luis Chamberlain
2022-04-16  4:01 ` Bart Van Assche
2022-04-18 15:57   ` Luis Chamberlain
2022-04-18 16:39     ` Bart Van Assche
2022-05-11 17:44       ` Luis Chamberlain
2022-05-11 18:22         ` Bart Van Assche
2022-12-20 21:28           ` Luis Chamberlain [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Y6IpC3Rv5QRSRCs0@bombadil.infradead.org \
    --to=mcgrof@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    --cc=osandov@fb.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.