* [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
@ 2022-12-21 7:02 ` Jianhua Lu
0 siblings, 0 replies; 12+ messages in thread
From: Jianhua Lu @ 2022-12-21 7:02 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski
Cc: linux-kernel, dri-devel, linux-leds, devicetree, Jianhua Lu
Add device tree bindings for the Kinetic KTZ8866 backlight driver.
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
.../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
new file mode 100644
index 000000000000..7286c3fc7f5d
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Kinetic Technologies KTZ8866 backlight
+
+maintainers:
+ - Jianhua Lu <lujianhua000@gmail.com>
+
+description: |
+ The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight
+ with dual lcd bias power.
+ https://www.kinet-ic.com/ktz8866/
+
+allOf:
+ - $ref: common.yaml#
+
+properties:
+ compatible:
+ items:
+ const: kinetic,ktz8866
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ backlight {
+ compatible = "kinetic,ktz8866";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&bl_en_default>;
+ };
--
2.38.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
@ 2022-12-21 7:02 ` Jianhua Lu
0 siblings, 0 replies; 12+ messages in thread
From: Jianhua Lu @ 2022-12-21 7:02 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski
Cc: devicetree, Jianhua Lu, linux-leds, linux-kernel, dri-devel
Add device tree bindings for the Kinetic KTZ8866 backlight driver.
Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
---
.../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
1 file changed, 37 insertions(+)
create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
new file mode 100644
index 000000000000..7286c3fc7f5d
--- /dev/null
+++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
@@ -0,0 +1,37 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Kinetic Technologies KTZ8866 backlight
+
+maintainers:
+ - Jianhua Lu <lujianhua000@gmail.com>
+
+description: |
+ The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight
+ with dual lcd bias power.
+ https://www.kinet-ic.com/ktz8866/
+
+allOf:
+ - $ref: common.yaml#
+
+properties:
+ compatible:
+ items:
+ const: kinetic,ktz8866
+
+required:
+ - compatible
+
+additionalProperties: false
+
+examples:
+ - |
+ backlight {
+ compatible = "kinetic,ktz8866";
+
+ pinctrl-names = "default";
+ pinctrl-0 = <&bl_en_default>;
+ };
--
2.38.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
2022-12-21 7:02 ` Jianhua Lu
@ 2022-12-21 8:13 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 8:13 UTC (permalink / raw)
To: Jianhua Lu, Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski
Cc: linux-kernel, dri-devel, linux-leds, devicetree
On 21/12/2022 08:02, Jianhua Lu wrote:
> Add device tree bindings for the Kinetic KTZ8866 backlight driver.
1. Your patches are not properly threaded which makes it difficult to
review and handle them. Resend with proper threads.
2. Subject: drop second, redundant "binding for".
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> new file mode 100644
> index 000000000000..7286c3fc7f5d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kinetic Technologies KTZ8866 backlight
> +
> +maintainers:
> + - Jianhua Lu <lujianhua000@gmail.com>
> +
> +description: |
> + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight
> + with dual lcd bias power.
> + https://www.kinet-ic.com/ktz8866/
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + const: kinetic,ktz8866
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
This should be rather unevaluatedProperties: false, otherwise you do not
allow any other properties, except compatible. Was this the intention?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
@ 2022-12-21 8:13 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 8:13 UTC (permalink / raw)
To: Jianhua Lu, Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski
Cc: devicetree, linux-leds, linux-kernel, dri-devel
On 21/12/2022 08:02, Jianhua Lu wrote:
> Add device tree bindings for the Kinetic KTZ8866 backlight driver.
1. Your patches are not properly threaded which makes it difficult to
review and handle them. Resend with proper threads.
2. Subject: drop second, redundant "binding for".
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> new file mode 100644
> index 000000000000..7286c3fc7f5d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> @@ -0,0 +1,37 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Kinetic Technologies KTZ8866 backlight
> +
> +maintainers:
> + - Jianhua Lu <lujianhua000@gmail.com>
> +
> +description: |
> + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led backlight
> + with dual lcd bias power.
> + https://www.kinet-ic.com/ktz8866/
> +
> +allOf:
> + - $ref: common.yaml#
> +
> +properties:
> + compatible:
> + items:
> + const: kinetic,ktz8866
Does not look like you tested the bindings. Please run `make
dt_binding_check` (see
Documentation/devicetree/bindings/writing-schema.rst for instructions).
> +
> +required:
> + - compatible
> +
> +additionalProperties: false
This should be rather unevaluatedProperties: false, otherwise you do not
allow any other properties, except compatible. Was this the intention?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
2022-12-21 8:13 ` Krzysztof Kozlowski
(?)
@ 2022-12-21 9:40 ` jianhua lu
2022-12-21 9:46 ` Krzysztof Kozlowski
-1 siblings, 1 reply; 12+ messages in thread
From: jianhua lu @ 2022-12-21 9:40 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Daniel Thompson, Pavel Machek, Jingoo Han, Lee Jones,
linux-kernel, dri-devel, Rob Herring, Krzysztof Kozlowski,
linux-leds
[-- Attachment #1: Type: text/plain, Size: 2235 bytes --]
Thanks for review, I will resend this path.
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于 2022年12月21日周三
16:13写道:
> On 21/12/2022 08:02, Jianhua Lu wrote:
> > Add device tree bindings for the Kinetic KTZ8866 backlight driver.
>
> 1. Your patches are not properly threaded which makes it difficult to
> review and handle them. Resend with proper threads.
>
> 2. Subject: drop second, redundant "binding for".
>
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644
> Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > new file mode 100644
> > index 000000000000..7286c3fc7f5d
> > --- /dev/null
> > +++
> b/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> > @@ -0,0 +1,37 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/leds/backlight/kinetic,ktz8866.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Kinetic Technologies KTZ8866 backlight
> > +
> > +maintainers:
> > + - Jianhua Lu <lujianhua000@gmail.com>
> > +
> > +description: |
> > + The Kinetic Technologies KTZ8866 is a high efficiency 6-sinks led
> backlight
> > + with dual lcd bias power.
> > + https://www.kinet-ic.com/ktz8866/
> > +
> > +allOf:
> > + - $ref: common.yaml#
> > +
> > +properties:
> > + compatible:
> > + items:
> > + const: kinetic,ktz8866
>
> Does not look like you tested the bindings. Please run `make
> dt_binding_check` (see
> Documentation/devicetree/bindings/writing-schema.rst for instructions).
>
> > +
> > +required:
> > + - compatible
> > +
> > +additionalProperties: false
>
> This should be rather unevaluatedProperties: false, otherwise you do not
> allow any other properties, except compatible. Was this the intention?
>
> Best regards,
> Krzysztof
>
>
[-- Attachment #2: Type: text/html, Size: 3258 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
2022-12-21 9:40 ` jianhua lu
@ 2022-12-21 9:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 9:46 UTC (permalink / raw)
To: jianhua lu
Cc: devicetree, Daniel Thompson, Pavel Machek, Jingoo Han, Lee Jones,
linux-kernel, dri-devel, Rob Herring, Krzysztof Kozlowski,
linux-leds
On 21/12/2022 10:40, jianhua lu wrote:
> Thanks for review, I will resend this path.
Are you going to test it, before sending?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
@ 2022-12-21 9:46 ` Krzysztof Kozlowski
0 siblings, 0 replies; 12+ messages in thread
From: Krzysztof Kozlowski @ 2022-12-21 9:46 UTC (permalink / raw)
To: jianhua lu
Cc: Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski, linux-kernel, dri-devel,
linux-leds, devicetree
On 21/12/2022 10:40, jianhua lu wrote:
> Thanks for review, I will resend this path.
Are you going to test it, before sending?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
2022-12-21 9:46 ` Krzysztof Kozlowski
(?)
@ 2022-12-21 9:51 ` jianhua lu
-1 siblings, 0 replies; 12+ messages in thread
From: jianhua lu @ 2022-12-21 9:51 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Daniel Thompson, Pavel Machek, Jingoo Han, Lee Jones,
linux-kernel, dri-devel, Rob Herring, Krzysztof Kozlowski,
linux-leds
[-- Attachment #1: Type: text/plain, Size: 293 bytes --]
Yes, I will
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> 于 2022年12月21日周三
17:46写道:
> On 21/12/2022 10:40, jianhua lu wrote:
> > Thanks for review, I will resend this path.
>
> Are you going to test it, before sending?
>
> Best regards,
> Krzysztof
>
>
[-- Attachment #2: Type: text/html, Size: 594 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
2022-12-21 7:02 ` Jianhua Lu
@ 2022-12-21 13:45 ` Rob Herring
-1 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2022-12-21 13:45 UTC (permalink / raw)
To: Jianhua Lu
Cc: linux-leds, devicetree, dri-devel, Rob Herring, Jingoo Han,
Pavel Machek, Daniel Thompson, linux-kernel, Lee Jones,
Krzysztof Kozlowski
On Wed, 21 Dec 2022 15:02:16 +0800, Jianhua Lu wrote:
> Add device tree bindings for the Kinetic KTZ8866 backlight driver.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml: properties:compatible:items: {'const': 'kinetic,ktz8866'} is not of type 'array'
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221221070216.17850-1-lujianhua000@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
@ 2022-12-21 13:45 ` Rob Herring
0 siblings, 0 replies; 12+ messages in thread
From: Rob Herring @ 2022-12-21 13:45 UTC (permalink / raw)
To: Jianhua Lu
Cc: devicetree, Daniel Thompson, Krzysztof Kozlowski, Jingoo Han,
Lee Jones, linux-kernel, dri-devel, Rob Herring, Pavel Machek,
linux-leds
On Wed, 21 Dec 2022 15:02:16 +0800, Jianhua Lu wrote:
> Add device tree bindings for the Kinetic KTZ8866 backlight driver.
>
> Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> ---
> .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
> 1 file changed, 37 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml: properties:compatible:items: {'const': 'kinetic,ktz8866'} is not of type 'array'
from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221221070216.17850-1-lujianhua000@gmail.com
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
2022-12-21 13:45 ` Rob Herring
@ 2022-12-21 14:08 ` Jianhua Lu
-1 siblings, 0 replies; 12+ messages in thread
From: Jianhua Lu @ 2022-12-21 14:08 UTC (permalink / raw)
To: Rob Herring
Cc: linux-leds, devicetree, dri-devel, Rob Herring, Jingoo Han,
Pavel Machek, Daniel Thompson, linux-kernel, Lee Jones,
Krzysztof Kozlowski
On Wed, Dec 21, 2022 at 07:45:59AM -0600, Rob Herring wrote:
>
> On Wed, 21 Dec 2022 15:02:16 +0800, Jianhua Lu wrote:
> > Add device tree bindings for the Kinetic KTZ8866 backlight driver.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml: properties:compatible:items: {'const': 'kinetic,ktz8866'} is not of type 'array'
> from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221221070216.17850-1-lujianhua000@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
I have resent a new patch and gotten rip of errors of the old dt-binding yaml.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight
@ 2022-12-21 14:08 ` Jianhua Lu
0 siblings, 0 replies; 12+ messages in thread
From: Jianhua Lu @ 2022-12-21 14:08 UTC (permalink / raw)
To: Rob Herring
Cc: devicetree, Daniel Thompson, Krzysztof Kozlowski, Jingoo Han,
Lee Jones, linux-kernel, dri-devel, Rob Herring, Pavel Machek,
linux-leds
On Wed, Dec 21, 2022 at 07:45:59AM -0600, Rob Herring wrote:
>
> On Wed, 21 Dec 2022 15:02:16 +0800, Jianhua Lu wrote:
> > Add device tree bindings for the Kinetic KTZ8866 backlight driver.
> >
> > Signed-off-by: Jianhua Lu <lujianhua000@gmail.com>
> > ---
> > .../leds/backlight/kinetic,ktz8866.yaml | 37 +++++++++++++++++++
> > 1 file changed, 37 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml
> >
>
> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
> on your patch (DT_CHECKER_FLAGS is new in v5.13):
>
> yamllint warnings/errors:
>
> dtschema/dtc warnings/errors:
> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/leds/backlight/kinetic,ktz8866.yaml: properties:compatible:items: {'const': 'kinetic,ktz8866'} is not of type 'array'
> from schema $id: http://devicetree.org/meta-schemas/string-array.yaml#
>
> doc reference errors (make refcheckdocs):
>
> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20221221070216.17850-1-lujianhua000@gmail.com
>
> The base for the series is generally the latest rc1. A different dependency
> should be noted in *this* patch.
>
> If you already ran 'make dt_binding_check' and didn't see the above
> error(s), then make sure 'yamllint' is installed and dt-schema is up to
> date:
>
> pip3 install dtschema --upgrade
>
> Please check and re-submit after running the above command yourself. Note
> that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> your schema. However, it must be unset to test all examples with your schema.
>
I have resent a new patch and gotten rip of errors of the old dt-binding yaml.
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2022-12-23 8:45 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-21 7:02 [PATCH 2/2] dt-bindings: leds: backlight: add binding for Kinetic KTZ8866 backlight Jianhua Lu
2022-12-21 7:02 ` Jianhua Lu
2022-12-21 8:13 ` Krzysztof Kozlowski
2022-12-21 8:13 ` Krzysztof Kozlowski
2022-12-21 9:40 ` jianhua lu
2022-12-21 9:46 ` Krzysztof Kozlowski
2022-12-21 9:46 ` Krzysztof Kozlowski
2022-12-21 9:51 ` jianhua lu
2022-12-21 13:45 ` Rob Herring
2022-12-21 13:45 ` Rob Herring
2022-12-21 14:08 ` Jianhua Lu
2022-12-21 14:08 ` Jianhua Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.